* [PATCH] xen: arm: use physical processor ID (MPIDR) when calling psci CPU_ON
@ 2014-07-14 16:21 Ian Campbell
2014-07-14 18:13 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2014-07-14 16:21 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Xen's logical CPU map can differ from the underlying layout.
Also add an emacs magic block to this file.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/psci.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 25a8697..b6360d5 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -54,7 +54,8 @@ static uint32_t psci_cpu_on_nr;
int call_psci_cpu_on(int cpu)
{
- return __invoke_psci_fn_smc(psci_cpu_on_nr, cpu, __pa(init_secondary), 0);
+ return __invoke_psci_fn_smc(psci_cpu_on_nr,
+ cpu_logical_map(cpu), __pa(init_secondary), 0);
}
int __init psci_init(void)
@@ -96,3 +97,12 @@ int __init psci_init(void)
return 0;
}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: use physical processor ID (MPIDR) when calling psci CPU_ON
2014-07-14 16:21 [PATCH] xen: arm: use physical processor ID (MPIDR) when calling psci CPU_ON Ian Campbell
@ 2014-07-14 18:13 ` Julien Grall
2014-07-15 9:32 ` Ian Campbell
2014-07-18 12:52 ` Ian Campbell
0 siblings, 2 replies; 4+ messages in thread
From: Julien Grall @ 2014-07-14 18:13 UTC (permalink / raw)
To: Ian Campbell, xen-devel; +Cc: tim, stefano.stabellini
Hi Ian,
On 07/14/2014 05:21 PM, Ian Campbell wrote:
> Xen's logical CPU map can differ from the underlying layout.
>
> Also add an emacs magic block to this file.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
Any plan to backport this patch for Xen 4.4? I suspect we have the same
issue on the Versatile Express when PSCI and A7 are used.
> ---
> xen/arch/arm/psci.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
> index 25a8697..b6360d5 100644
> --- a/xen/arch/arm/psci.c
> +++ b/xen/arch/arm/psci.c
> @@ -54,7 +54,8 @@ static uint32_t psci_cpu_on_nr;
>
> int call_psci_cpu_on(int cpu)
> {
> - return __invoke_psci_fn_smc(psci_cpu_on_nr, cpu, __pa(init_secondary), 0);
> + return __invoke_psci_fn_smc(psci_cpu_on_nr,
> + cpu_logical_map(cpu), __pa(init_secondary), 0);
> }
>
> int __init psci_init(void)
> @@ -96,3 +97,12 @@ int __init psci_init(void)
>
> return 0;
> }
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: use physical processor ID (MPIDR) when calling psci CPU_ON
2014-07-14 18:13 ` Julien Grall
@ 2014-07-15 9:32 ` Ian Campbell
2014-07-18 12:52 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-07-15 9:32 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Mon, 2014-07-14 at 19:13 +0100, Julien Grall wrote:
> Hi Ian,
>
> On 07/14/2014 05:21 PM, Ian Campbell wrote:
> > Xen's logical CPU map can differ from the underlying layout.
> >
> > Also add an emacs magic block to this file.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Julien Grall <julien.grall@linaro.org>
Thanks.
> Any plan to backport this patch for Xen 4.4? I suspect we have the same
> issue on the Versatile Express when PSCI and A7 are used.
True. I've added it to my list.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen: arm: use physical processor ID (MPIDR) when calling psci CPU_ON
2014-07-14 18:13 ` Julien Grall
2014-07-15 9:32 ` Ian Campbell
@ 2014-07-18 12:52 ` Ian Campbell
1 sibling, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-07-18 12:52 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Mon, 2014-07-14 at 19:13 +0100, Julien Grall wrote:
> Hi Ian,
>
> On 07/14/2014 05:21 PM, Ian Campbell wrote:
> > Xen's logical CPU map can differ from the underlying layout.
> >
> > Also add an emacs magic block to this file.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> Acked-by: Julien Grall <julien.grall@linaro.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-18 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-14 16:21 [PATCH] xen: arm: use physical processor ID (MPIDR) when calling psci CPU_ON Ian Campbell
2014-07-14 18:13 ` Julien Grall
2014-07-15 9:32 ` Ian Campbell
2014-07-18 12:52 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.