From: daniel.thompson@linaro.org (Daniel Thompson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/4] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)
Date: Tue, 15 Jul 2014 11:54:25 +0100 [thread overview]
Message-ID: <53C50861.3060300@linaro.org> (raw)
In-Reply-To: <4736066.znnQ63vBqX@wuerfel>
On 15/07/14 11:32, Arnd Bergmann wrote:
> On Monday 14 July 2014 17:27:49 Arnd Bergmann wrote:
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index 8f90595069a1..0f89d1b84524 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -200,6 +200,14 @@ choice
>> Say Y here if you want the debug print routines to direct
>> their output to the serial port in the DC21285 (Footbridge).
>>
>> + config DEBUG_EP93XX
>> + bool "Kernel low-level debugging messages via ep93xx UART"
>> + depends on ARCH_EP93XX
>> + select DEBUG_UART_PL01X
>> + help
>> + Say Y here if you want kernel low-level debugging support
>> + on Cirrus Logic EP93xx based platforms.
>> +
>
> FWIW, this part was broken, fixup below. The problem is that the decompress.h
> for ep93xx uses CONFIG_DEBUG_UART_PHYS even when DEBUG_LL is disabled.
Thanks (this fix is already in my patchset but your proposal means it
needs changing slightly).
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 362d764cd358..a99b28029983 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1139,7 +1139,7 @@ config DEBUG_UART_PHYS
> default 0x80070000 if DEBUG_IMX23_UART
> default 0x80074000 if DEBUG_IMX28_UART
> default 0x80230000 if DEBUG_PICOXCELL_UART
> - default 0x808c0000 if DEBUG_EP93XX
> + default 0x808c0000 if DEBUG_EP93XX || ARCH_EP93XX
> default 0x90020000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART
> default 0xa9a00000 if DEBUG_MSM_UART
> default 0xb0090000 if DEBUG_VEXPRESS_UART0_CRX
> @@ -1166,7 +1166,8 @@ config DEBUG_UART_PHYS
> depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
> DEBUG_LL_UART_EFM32 || \
> DEBUG_UART_8250 || DEBUG_UART_PL01X || \
> - DEBUG_MSM_UART || DEBUG_QCOM_UARTDM || DEBUG_S3C24XX_UART
> + DEBUG_MSM_UART || DEBUG_QCOM_UARTDM || DEBUG_S3C24XX_UART || \
> + ARCH_EP93XX
>
> config DEBUG_UART_VIRT
> hex "Virtual base address of debug UART"
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Paul Bolle <pebolle@tiscali.nl>,
linaro-kernel@lists.linaro.org, patches@linaro.org,
spear-devel@list.st.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/4] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)
Date: Tue, 15 Jul 2014 11:54:25 +0100 [thread overview]
Message-ID: <53C50861.3060300@linaro.org> (raw)
In-Reply-To: <4736066.znnQ63vBqX@wuerfel>
On 15/07/14 11:32, Arnd Bergmann wrote:
> On Monday 14 July 2014 17:27:49 Arnd Bergmann wrote:
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index 8f90595069a1..0f89d1b84524 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -200,6 +200,14 @@ choice
>> Say Y here if you want the debug print routines to direct
>> their output to the serial port in the DC21285 (Footbridge).
>>
>> + config DEBUG_EP93XX
>> + bool "Kernel low-level debugging messages via ep93xx UART"
>> + depends on ARCH_EP93XX
>> + select DEBUG_UART_PL01X
>> + help
>> + Say Y here if you want kernel low-level debugging support
>> + on Cirrus Logic EP93xx based platforms.
>> +
>
> FWIW, this part was broken, fixup below. The problem is that the decompress.h
> for ep93xx uses CONFIG_DEBUG_UART_PHYS even when DEBUG_LL is disabled.
Thanks (this fix is already in my patchset but your proposal means it
needs changing slightly).
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 362d764cd358..a99b28029983 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -1139,7 +1139,7 @@ config DEBUG_UART_PHYS
> default 0x80070000 if DEBUG_IMX23_UART
> default 0x80074000 if DEBUG_IMX28_UART
> default 0x80230000 if DEBUG_PICOXCELL_UART
> - default 0x808c0000 if DEBUG_EP93XX
> + default 0x808c0000 if DEBUG_EP93XX || ARCH_EP93XX
> default 0x90020000 if DEBUG_NSPIRE_CLASSIC_UART || DEBUG_NSPIRE_CX_UART
> default 0xa9a00000 if DEBUG_MSM_UART
> default 0xb0090000 if DEBUG_VEXPRESS_UART0_CRX
> @@ -1166,7 +1166,8 @@ config DEBUG_UART_PHYS
> depends on DEBUG_LL_UART_8250 || DEBUG_LL_UART_PL01X || \
> DEBUG_LL_UART_EFM32 || \
> DEBUG_UART_8250 || DEBUG_UART_PL01X || \
> - DEBUG_MSM_UART || DEBUG_QCOM_UARTDM || DEBUG_S3C24XX_UART
> + DEBUG_MSM_UART || DEBUG_QCOM_UARTDM || DEBUG_S3C24XX_UART || \
> + ARCH_EP93XX
>
> config DEBUG_UART_VIRT
> hex "Virtual base address of debug UART"
>
next prev parent reply other threads:[~2014-07-15 10:54 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:17 [PATCH] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-04-04 11:17 ` Daniel Thompson
2014-04-04 11:39 ` Arnd Bergmann
2014-04-04 11:39 ` Arnd Bergmann
2014-04-04 14:02 ` Daniel Thompson
2014-04-04 14:02 ` Daniel Thompson
2014-04-04 14:14 ` Paul Bolle
2014-04-04 14:14 ` Paul Bolle
2014-04-04 14:52 ` Paul Bolle
2014-04-04 14:52 ` Paul Bolle
2014-04-04 14:41 ` Russell King - ARM Linux
2014-04-04 14:41 ` Russell King - ARM Linux
2014-04-04 15:18 ` Daniel Thompson
2014-04-04 15:18 ` Daniel Thompson
2014-04-04 14:47 ` [PATCH v2] " Daniel Thompson
2014-04-04 14:47 ` Daniel Thompson
2014-04-04 15:41 ` [PATCH v3] " Daniel Thompson
2014-04-04 15:41 ` Daniel Thompson
2014-04-07 12:48 ` Daniel Thompson
2014-04-07 12:48 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 0/5] " Daniel Thompson
2014-04-07 15:54 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-04-07 15:54 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 2/5] ARM: ep93xx: " Daniel Thompson
2014-04-07 15:54 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-04-07 15:54 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-04-07 15:54 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-04-07 15:54 ` Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 0/5] " Daniel Thompson
2014-04-24 16:00 ` Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-04-24 16:00 ` Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 2/5] ARM: ep93xx: " Daniel Thompson
2014-04-24 16:00 ` Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-04-24 16:00 ` Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-04-24 16:00 ` Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-04-24 16:00 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 0/5] " Daniel Thompson
2014-05-23 15:10 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-05-23 15:10 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 2/5] ARM: ep93xx: " Daniel Thompson
2014-05-23 15:10 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-05-23 15:10 ` Daniel Thompson
2014-05-23 15:35 ` Arnd Bergmann
2014-05-23 15:35 ` Arnd Bergmann
2014-05-26 13:39 ` Arnd Bergmann
2014-05-26 13:39 ` Arnd Bergmann
2014-05-27 13:13 ` Daniel Thompson
2014-05-27 13:13 ` Daniel Thompson
2014-05-27 13:37 ` Arnd Bergmann
2014-05-27 13:37 ` Arnd Bergmann
2014-05-27 13:52 ` Daniel Thompson
2014-05-27 13:52 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-05-23 15:10 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-05-23 15:10 ` Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 0/5] " Daniel Thompson
2014-05-27 16:00 ` Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-05-27 16:00 ` Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 2/5] ARM: ep93xx: " Daniel Thompson
2014-05-27 16:00 ` Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 3/5] ARM: Hide DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-05-27 16:00 ` Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-05-27 16:00 ` Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-05-27 16:00 ` Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 0/4] " Daniel Thompson
2014-06-30 11:30 ` Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 1/4] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-06-30 11:30 ` Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 2/4] ARM: ep93xx: " Daniel Thompson
2014-06-30 11:30 ` Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 3/4] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-06-30 11:30 ` Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 4/4] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-06-30 11:30 ` Daniel Thompson
2014-06-30 13:20 ` [PATCH v7 0/4] " Arnd Bergmann
2014-06-30 13:20 ` Arnd Bergmann
2014-07-12 10:16 ` Russell King - ARM Linux
2014-07-12 10:16 ` Russell King - ARM Linux
2014-07-12 11:10 ` Russell King - ARM Linux
2014-07-12 11:10 ` Russell King - ARM Linux
2014-07-14 9:05 ` Daniel Thompson
2014-07-14 9:05 ` Daniel Thompson
2014-07-14 10:39 ` Daniel Thompson
2014-07-14 10:39 ` Daniel Thompson
2014-07-14 15:27 ` Arnd Bergmann
2014-07-14 15:27 ` Arnd Bergmann
2014-07-15 10:32 ` Arnd Bergmann
2014-07-15 10:32 ` Arnd Bergmann
2014-07-15 10:54 ` Daniel Thompson [this message]
2014-07-15 10:54 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 0/9] " Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 1/9] arm: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 2/9] arm: ep93xx: " Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 3/9] arm: Remove DEBUG_LL_UART_NONE Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 4/9] arm: ks8695: Migrate debug_ll macros to shared directory Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 6/9] arm: netx: Migrate DEBUG_LL macros to shared directory Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-09-15 16:34 ` Paul Bolle
2014-09-15 16:34 ` Paul Bolle
2014-09-15 21:47 ` Daniel Thompson
2014-09-15 21:47 ` Daniel Thompson
2014-09-16 22:37 ` Daniel Thompson
2014-09-16 22:37 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 7/9] arm: sa1100: " Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 8/9] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 9/9] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-08-19 14:48 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 0/9] " Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 1/9] arm: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 2/9] arm: ep93xx: " Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 3/9] arm: Remove DEBUG_LL_UART_NONE Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 4/9] arm: ks8695: Migrate debug_ll macros to shared directory Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-21 11:46 ` Greg Ungerer
2014-08-21 11:46 ` Greg Ungerer
2014-09-01 9:04 ` Daniel Thompson
2014-09-01 9:04 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-09-08 23:04 ` Tony Lindgren
2014-09-08 23:04 ` Tony Lindgren
2014-08-19 15:16 ` [PATCH v9 6/9] arm: netx: Migrate DEBUG_LL macros to shared directory Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 7/9] arm: sa1100: " Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 8/9] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 9/9] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-08-19 15:16 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C50861.3060300@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.