From: Tomasz Figa <t.figa@samsung.com>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
linux-arm-kernel@lists.infradead.org,
spi-devel-general@lists.sourceforge.net,
linux-samsung-soc@vger.kernel.org
Cc: naveenkrishna.ch@gmail.com, broonie@kernel.org,
grant.likely@secretlab.ca, jaswinder.singh@linaro.org,
kgene.kim@samsung.com, cpgs@samsung.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3 v6] spi: s3c64xx: fix broken "cs_gpios" usage in the driver
Date: Tue, 15 Jul 2014 18:55:51 +0200 [thread overview]
Message-ID: <53C55D17.90109@samsung.com> (raw)
In-Reply-To: <1405316506-27855-2-git-send-email-ch.naveen@samsung.com>
Hi Naveen,
On 14.07.2014 07:41, Naveen Krishna Chatradhi wrote:
> Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin)
>
> spi-s3c64xx.c driver expects
> 1. chip select gpios from "cs-gpio"(singular) under the
> "controller-data" node of the client/slave device of the SPI.
Please work a bit more on readability of your commit messages,
especially in terms of using correct terminology to avoid unnecessary
confusion.
s/'chip select gpios'/'chip select GPIO pins'/
s/'"cs-gpio"(singular)'/'"cs-gpio" property'/
s/'client/slave device of the SPI'/'SPI device'/
More things like this follow in rest of the text below.
Otherwise I believe the code after this patch does the right thing, so:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3 v6] spi: s3c64xx: fix broken "cs_gpios" usage in the driver
Date: Tue, 15 Jul 2014 18:55:51 +0200 [thread overview]
Message-ID: <53C55D17.90109@samsung.com> (raw)
In-Reply-To: <1405316506-27855-2-git-send-email-ch.naveen@samsung.com>
Hi Naveen,
On 14.07.2014 07:41, Naveen Krishna Chatradhi wrote:
> Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin)
>
> spi-s3c64xx.c driver expects
> 1. chip select gpios from "cs-gpio"(singular) under the
> "controller-data" node of the client/slave device of the SPI.
Please work a bit more on readability of your commit messages,
especially in terms of using correct terminology to avoid unnecessary
confusion.
s/'chip select gpios'/'chip select GPIO pins'/
s/'"cs-gpio"(singular)'/'"cs-gpio" property'/
s/'client/slave device of the SPI'/'SPI device'/
More things like this follow in rest of the text below.
Otherwise I believe the code after this patch does the right thing, so:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-15 16:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 5:41 [PATCH 0/3 v6] spi: s3c64xx: use "cs-gpios" in spi node instead of "cs-gpio" Naveen Krishna Chatradhi
2014-07-14 5:41 ` Naveen Krishna Chatradhi
2014-07-14 5:41 ` [PATCH 1/3 v6] spi: s3c64xx: fix broken "cs_gpios" usage in the driver Naveen Krishna Chatradhi
2014-07-14 5:41 ` Naveen Krishna Chatradhi
2014-07-14 17:25 ` Mark Brown
2014-07-14 17:25 ` Mark Brown
2014-07-14 19:01 ` Naveen Krishna Ch
2014-07-14 19:01 ` Naveen Krishna Ch
[not found] ` <CAHfPSqAzab931yurSs+3zj=uoFj93FuAdd24AQKm1fZm07Nq8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-14 19:15 ` Mark Brown
2014-07-14 19:15 ` Mark Brown
2014-07-15 4:03 ` Naveen Krishna Ch
2014-07-15 4:03 ` Naveen Krishna Ch
2014-07-15 11:00 ` Mark Brown
2014-07-15 11:00 ` Mark Brown
2014-07-15 10:38 ` Javier Martinez Canillas
2014-07-15 10:38 ` Javier Martinez Canillas
2014-07-15 12:35 ` Mark Brown
2014-07-15 12:35 ` Mark Brown
2014-07-15 16:55 ` Tomasz Figa [this message]
2014-07-15 16:55 ` Tomasz Figa
2014-07-15 17:21 ` Naveen Krishna Ch
2014-07-15 17:21 ` Naveen Krishna Ch
2014-07-15 17:22 ` Tomasz Figa
2014-07-15 17:22 ` Tomasz Figa
2014-07-14 5:41 ` [PATCH 2/3 v6] spi: s3c64xx: for DT platofrms always get the chipselect info from DT node Naveen Krishna Chatradhi
2014-07-14 5:41 ` Naveen Krishna Chatradhi
2014-07-14 5:41 ` [PATCH 3/3 v6] ARM: DTS: fix the chip select gpios definition in the SPI nodes Naveen Krishna Chatradhi
2014-07-14 5:41 ` Naveen Krishna Chatradhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C55D17.90109@samsung.com \
--to=t.figa@samsung.com \
--cc=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=jaswinder.singh@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.