[PATCH v3 0/2] Add mask-tpm-reset DT node to the exynos5

[PATCH v3 0/2] Add mask-tpm-reset DT node to the exynos5

[Vikas Sajjan]

Adds mask-tpm-reset DT node to the exynos5420 and exynos5800.

rebase on for-next branch of kgene tree
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/

Tested on exynos5420 and exynos5800 based Chromebooks (both pit and pi).

changes since v2:
	- reordered the dt node based on gpio number
	- included the exynos5800-peach-pi patch in this series

changes since v1:
	- removed fixed regulator and used hogs instead.

Doug Anderson (1):
  ARM: dts: Add mask-tpm-reset to the device tree

Vikas Sajjan (1):
  ARM: dts: Add mask-tpm-reset DT node to the exynos5800-peach-pi

 arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |   12 ++++++++++++
 2 files changed, 24 insertions(+)

-- 
1.7.9.5

[PATCH v3 0/2] Add mask-tpm-reset DT node to the exynos5

[Vikas Sajjan]

Adds mask-tpm-reset DT node to the exynos5420 and exynos5800.

rebase on for-next branch of kgene tree
https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/

Tested on exynos5420 and exynos5800 based Chromebooks (both pit and pi).

changes since v2:
	- reordered the dt node based on gpio number
	- included the exynos5800-peach-pi patch in this series

changes since v1:
	- removed fixed regulator and used hogs instead.

Doug Anderson (1):
  ARM: dts: Add mask-tpm-reset to the device tree

Vikas Sajjan (1):
  ARM: dts: Add mask-tpm-reset DT node to the exynos5800-peach-pi

 arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |   12 ++++++++++++
 2 files changed, 24 insertions(+)

-- 
1.7.9.5

[PATCH v3 1/2] ARM: dts: Add mask-tpm-reset to the device tree

[Vikas Sajjan]

From: Doug Anderson <dianders@chromium.org>

The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
being reset across sleep/wake.  If we don't set it to anything then
the TPM will be reset.  U-Boot will detect this as invalid
and will reset the system on resume time. This GPIO can always be low
and not hurt anything.  It will get pulled back high again during a
normal warm reset when it will default back to an input.

To properly preserve the TPM state across suspend/resume and to make
the chrome U-Boot happy, properly set the GPIO to mask the
reset to the TPM.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 6c7cab0..c7b2bba 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -211,6 +211,9 @@
 
 
 &pinctrl_0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mask_tpm_reset>;
+
 	max98090_irq: max98090-irq {
 		samsung,pins = "gpx0-2";
 		samsung,pin-function = <0>;
@@ -218,6 +221,15 @@
 		samsung,pin-drv = <0>;
 	};
 
+	/* We need GPX0_6 to be low at sleep time; just keep it low always */
+	mask_tpm_reset: mask-tpm-reset {
+		samsung,pins = "gpx0-6";
+		samsung,pin-function = <1>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+		samsung,pin-val = <0>;
+	};
+
 	tpm_irq: tpm-irq {
 		samsung,pins = "gpx1-0";
 		samsung,pin-function = <0>;
-- 
1.7.9.5

[PATCH v3 1/2] ARM: dts: Add mask-tpm-reset to the device tree

[Vikas Sajjan]

From: Doug Anderson <dianders@chromium.org>

The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
being reset across sleep/wake.  If we don't set it to anything then
the TPM will be reset.  U-Boot will detect this as invalid
and will reset the system on resume time. This GPIO can always be low
and not hurt anything.  It will get pulled back high again during a
normal warm reset when it will default back to an input.

To properly preserve the TPM state across suspend/resume and to make
the chrome U-Boot happy, properly set the GPIO to mask the
reset to the TPM.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
---
 arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 6c7cab0..c7b2bba 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -211,6 +211,9 @@
 
 
 &pinctrl_0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mask_tpm_reset>;
+
 	max98090_irq: max98090-irq {
 		samsung,pins = "gpx0-2";
 		samsung,pin-function = <0>;
@@ -218,6 +221,15 @@
 		samsung,pin-drv = <0>;
 	};
 
+	/* We need GPX0_6 to be low at sleep time; just keep it low always */
+	mask_tpm_reset: mask-tpm-reset {
+		samsung,pins = "gpx0-6";
+		samsung,pin-function = <1>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+		samsung,pin-val = <0>;
+	};
+
 	tpm_irq: tpm-irq {
 		samsung,pins = "gpx1-0";
 		samsung,pin-function = <0>;
-- 
1.7.9.5

[PATCH v3 2/2] ARM: dts: Add mask-tpm-reset DT node to the exynos5800-peach-pi

[Vikas Sajjan]

The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
being reset across sleep/wake.  If we don't set it to anything then
the TPM will be reset.  U-Boot will detect this as invalid
and will reset the system on resume time. This GPIO can always be low
and not hurt anything.  It will get pulled back high again during a
normal warm reset when it will default back to an input.

To properly preserve the TPM state across suspend/resume and to make
the chrome U-Boot happy, properly set the GPIO to mask the
reset to the TPM.

Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
---
 arch/arm/boot/dts/exynos5800-peach-pi.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 28f2a25..0bc97d9 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -209,6 +209,9 @@
 
 
 &pinctrl_0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mask_tpm_reset>;
+
 	max98091_irq: max98091-irq {
 		samsung,pins = "gpx0-2";
 		samsung,pin-function = <0>;
@@ -216,6 +219,15 @@
 		samsung,pin-drv = <0>;
 	};
 
+	/* We need GPX0_6 to be low at sleep time; just keep it low always */
+	mask_tpm_reset: mask-tpm-reset {
+		samsung,pins = "gpx0-6";
+		samsung,pin-function = <1>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+		samsung,pin-val = <0>;
+	};
+
 	tpm_irq: tpm-irq {
 		samsung,pins = "gpx1-0";
 		samsung,pin-function = <0>;
-- 
1.7.9.5

[PATCH v3 2/2] ARM: dts: Add mask-tpm-reset DT node to the exynos5800-peach-pi

[Vikas Sajjan]

The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
being reset across sleep/wake.  If we don't set it to anything then
the TPM will be reset.  U-Boot will detect this as invalid
and will reset the system on resume time. This GPIO can always be low
and not hurt anything.  It will get pulled back high again during a
normal warm reset when it will default back to an input.

To properly preserve the TPM state across suspend/resume and to make
the chrome U-Boot happy, properly set the GPIO to mask the
reset to the TPM.

Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
---
 arch/arm/boot/dts/exynos5800-peach-pi.dts |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 28f2a25..0bc97d9 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -209,6 +209,9 @@
 
 
 &pinctrl_0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mask_tpm_reset>;
+
 	max98091_irq: max98091-irq {
 		samsung,pins = "gpx0-2";
 		samsung,pin-function = <0>;
@@ -216,6 +219,15 @@
 		samsung,pin-drv = <0>;
 	};
 
+	/* We need GPX0_6 to be low at sleep time; just keep it low always */
+	mask_tpm_reset: mask-tpm-reset {
+		samsung,pins = "gpx0-6";
+		samsung,pin-function = <1>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+		samsung,pin-val = <0>;
+	};
+
 	tpm_irq: tpm-irq {
 		samsung,pins = "gpx1-0";
 		samsung,pin-function = <0>;
-- 
1.7.9.5

Re: [PATCH v3 1/2] ARM: dts: Add mask-tpm-reset to the device tree

[Doug Anderson]

Vikas,

On Tue, Jul 15, 2014 at 3:31 AM, Vikas Sajjan <vikas.sajjan@samsung.com> wrote:
> From: Doug Anderson <dianders@chromium.org>
>
> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
> being reset across sleep/wake.  If we don't set it to anything then
> the TPM will be reset.  U-Boot will detect this as invalid
> and will reset the system on resume time. This GPIO can always be low
> and not hurt anything.  It will get pulled back high again during a
> normal warm reset when it will default back to an input.
>
> To properly preserve the TPM state across suspend/resume and to make
> the chrome U-Boot happy, properly set the GPIO to mask the
> reset to the TPM.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Looks good to me.  I'll assume Kukjin will add the words
"exynos5420-peach-pit" into the patch description when applying.

Reviewed-by: Doug Anderson <dianders@chromium.org>

-Doug

[PATCH v3 1/2] ARM: dts: Add mask-tpm-reset to the device tree

[Doug Anderson]

Vikas,

On Tue, Jul 15, 2014 at 3:31 AM, Vikas Sajjan <vikas.sajjan@samsung.com> wrote:
> From: Doug Anderson <dianders@chromium.org>
>
> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
> being reset across sleep/wake.  If we don't set it to anything then
> the TPM will be reset.  U-Boot will detect this as invalid
> and will reset the system on resume time. This GPIO can always be low
> and not hurt anything.  It will get pulled back high again during a
> normal warm reset when it will default back to an input.
>
> To properly preserve the TPM state across suspend/resume and to make
> the chrome U-Boot happy, properly set the GPIO to mask the
> reset to the TPM.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Looks good to me.  I'll assume Kukjin will add the words
"exynos5420-peach-pit" into the patch description when applying.

Reviewed-by: Doug Anderson <dianders@chromium.org>

-Doug

Re: [PATCH v3 2/2] ARM: dts: Add mask-tpm-reset DT node to the exynos5800-peach-pi

[Doug Anderson]

Vikas,

On Tue, Jul 15, 2014 at 3:31 AM, Vikas Sajjan <vikas.sajjan@samsung.com> wrote:
> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
> being reset across sleep/wake.  If we don't set it to anything then
> the TPM will be reset.  U-Boot will detect this as invalid
> and will reset the system on resume time. This GPIO can always be low
> and not hurt anything.  It will get pulled back high again during a
> normal warm reset when it will default back to an input.
>
> To properly preserve the TPM state across suspend/resume and to make
> the chrome U-Boot happy, properly set the GPIO to mask the
> reset to the TPM.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5800-peach-pi.dts |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Reviewed-by: Doug Anderson <dianders@chromium.org>

-Doug

[PATCH v3 2/2] ARM: dts: Add mask-tpm-reset DT node to the exynos5800-peach-pi

[Doug Anderson]

Vikas,

On Tue, Jul 15, 2014 at 3:31 AM, Vikas Sajjan <vikas.sajjan@samsung.com> wrote:
> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
> being reset across sleep/wake.  If we don't set it to anything then
> the TPM will be reset.  U-Boot will detect this as invalid
> and will reset the system on resume time. This GPIO can always be low
> and not hurt anything.  It will get pulled back high again during a
> normal warm reset when it will default back to an input.
>
> To properly preserve the TPM state across suspend/resume and to make
> the chrome U-Boot happy, properly set the GPIO to mask the
> reset to the TPM.
>
> Signed-off-by: Vikas Sajjan <vikas.sajjan@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5800-peach-pi.dts |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

Reviewed-by: Doug Anderson <dianders@chromium.org>

-Doug

Re: [PATCH v3 1/2] ARM: dts: Add mask-tpm-reset to the device tree

[Kukjin Kim]

On 07/16/14 01:19, Doug Anderson wrote:
> Vikas,
>
> On Tue, Jul 15, 2014 at 3:31 AM, Vikas Sajjan<vikas.sajjan@samsung.com>  wrote:
>> From: Doug Anderson<dianders@chromium.org>
>>
>> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
>> being reset across sleep/wake.  If we don't set it to anything then
>> the TPM will be reset.  U-Boot will detect this as invalid
>> and will reset the system on resume time. This GPIO can always be low
>> and not hurt anything.  It will get pulled back high again during a
>> normal warm reset when it will default back to an input.
>>
>> To properly preserve the TPM state across suspend/resume and to make
>> the chrome U-Boot happy, properly set the GPIO to mask the
>> reset to the TPM.
>>
>> Signed-off-by: Doug Anderson<dianders@chromium.org>
>> Signed-off-by: Vikas Sajjan<vikas.sajjan@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>
> Looks good to me.  I'll assume Kukjin will add the words
> "exynos5420-peach-pit" into the patch description when applying.
>
Yes :)

> Reviewed-by: Doug Anderson<dianders@chromium.org>
>
I've applied this series, thanks.

- Kukjin

[PATCH v3 1/2] ARM: dts: Add mask-tpm-reset to the device tree

[Kukjin Kim]

On 07/16/14 01:19, Doug Anderson wrote:
> Vikas,
>
> On Tue, Jul 15, 2014 at 3:31 AM, Vikas Sajjan<vikas.sajjan@samsung.com>  wrote:
>> From: Doug Anderson<dianders@chromium.org>
>>
>> The mask-tpm-reset GPIO is used by the kernel to prevent the TPM from
>> being reset across sleep/wake.  If we don't set it to anything then
>> the TPM will be reset.  U-Boot will detect this as invalid
>> and will reset the system on resume time. This GPIO can always be low
>> and not hurt anything.  It will get pulled back high again during a
>> normal warm reset when it will default back to an input.
>>
>> To properly preserve the TPM state across suspend/resume and to make
>> the chrome U-Boot happy, properly set the GPIO to mask the
>> reset to the TPM.
>>
>> Signed-off-by: Doug Anderson<dianders@chromium.org>
>> Signed-off-by: Vikas Sajjan<vikas.sajjan@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420-peach-pit.dts |   12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>
> Looks good to me.  I'll assume Kukjin will add the words
> "exynos5420-peach-pit" into the patch description when applying.
>
Yes :)

> Reviewed-by: Doug Anderson<dianders@chromium.org>
>
I've applied this series, thanks.

- Kukjin