[PATCH] qa/workunits/erasure-code/bench.sh: Using correcting parameter name when call ceph_erasure_code_benchmark.

[PATCH] qa/workunits/erasure-code/bench.sh: Using correcting parameter name when call ceph_erasure_code_benchmark.

[Ma, Jianpeng]

In commit bcc74879a, loic modifed the parameter name. But he forgot to
modify the name in qa/workunits/erasure-code/bench.sh. Now modify and make
bench.sh work.

Signed-off-by: Ma Jianpeng <jianpeng.ma@intel.com>
---
 qa/workunits/erasure-code/bench.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/qa/workunits/erasure-code/bench.sh b/qa/workunits/erasure-code/bench.sh
index db7c490..483450b 100755
--- a/qa/workunits/erasure-code/bench.sh
+++ b/qa/workunits/erasure-code/bench.sh
@@ -50,9 +50,9 @@ function bench() {
         --iterations $iterations \
         --size $size \
         --erasures $erasures \
-        --parameter erasure-code-k=$k \
-        --parameter erasure-code-m=$m \
-        --parameter erasure-code-directory=$PLUGIN_DIRECTORY)
+        --parameter k=$k \
+        --parameter m=$m \
+        --parameter directory=$PLUGIN_DIRECTORY)
     result=$($command "$@")
     echo -e "$result\t$plugin\t$k\t$m\t$workload\t$iterations\t$size\t$erasures\t$command ""$@"
 }
--
1.9.1

Re: [PATCH] qa/workunits/erasure-code/bench.sh: Using correcting parameter name when call ceph_erasure_code_benchmark.

[Loic Dachary]

[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]

Hi,

This is part of a larger pull request ( https://github.com/ceph/ceph/pull/1875 ), specifically https://github.com/dachary/ceph/commit/64175d9d6e1c8f6cbdc5396e85ba8c94168afba8#diff-8a5d2cfe0db7cb75615a5f6b2245148bL53 . But it's worth applying as suggested until it gets merged, to avoid confusion.

Thanks !

Reviewed-by:

On 15/07/2014 12:31, Ma, Jianpeng wrote:
> In commit bcc74879a, loic modifed the parameter name. But he forgot to
> modify the name in qa/workunits/erasure-code/bench.sh. Now modify and make
> bench.sh work.
> 
> Signed-off-by: Ma Jianpeng <jianpeng.ma@intel.com>
> ---
>  qa/workunits/erasure-code/bench.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qa/workunits/erasure-code/bench.sh b/qa/workunits/erasure-code/bench.sh
> index db7c490..483450b 100755
> --- a/qa/workunits/erasure-code/bench.sh
> +++ b/qa/workunits/erasure-code/bench.sh
> @@ -50,9 +50,9 @@ function bench() {
>          --iterations $iterations \
>          --size $size \
>          --erasures $erasures \
> -        --parameter erasure-code-k=$k \
> -        --parameter erasure-code-m=$m \
> -        --parameter erasure-code-directory=$PLUGIN_DIRECTORY)
> +        --parameter k=$k \
> +        --parameter m=$m \
> +        --parameter directory=$PLUGIN_DIRECTORY)
>      result=$($command "$@")
>      echo -e "$result\t$plugin\t$k\t$m\t$workload\t$iterations\t$size\t$erasures\t$command ""$@"
>  }
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]