From: Pranith Kumar <bobby.prani@gmail.com>
To: josh@joshtriplett.org
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
"open list:READ-COPY UPDATE..." <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] rcu: Remove stale comment in tree.c
Date: Tue, 15 Jul 2014 18:57:59 -0400 [thread overview]
Message-ID: <53C5B1F7.3000409@gmail.com> (raw)
In-Reply-To: <20140715225313.GB24290@cloud>
On 07/15/2014 06:53 PM, josh@joshtriplett.org wrote:
> On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote:
>> This commit removes a stale comment in rcu/tree.c.
>> FYI, an updated comment exists a few lines below this.
>>
>> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> In general, when removing a stale comment, I'd suggest explaining why
> the comment is stale. Was code removed without removing the
> corresponding comment, or was code changed such that the comment no
> longer applies, or...?
I guess it was left out when code was moved around previously. And I did mention that an updated comment is there a few lines below.
For reference this is the new comment which is below the old comment, they mean the same :)
/* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
next prev parent reply other threads:[~2014-07-15 22:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 22:31 [PATCH 1/3] rcu: tiny.c: Update reference to tree.c Pranith Kumar
2014-07-15 22:31 ` [PATCH 2/3] rcu: Remove stale comment in tree.c Pranith Kumar
2014-07-15 22:53 ` josh
2014-07-15 22:57 ` Pranith Kumar [this message]
2014-07-16 12:47 ` Paul E. McKenney
2014-07-16 13:29 ` Pranith Kumar
2014-07-16 23:32 ` josh
2014-07-17 0:55 ` Lai Jiangshan
2014-07-17 1:01 ` Pranith Kumar
2014-07-17 1:25 ` Lai Jiangshan
2014-07-17 1:26 ` Pranith Kumar
2014-07-17 2:14 ` Josh Triplett
2014-07-17 2:20 ` Pranith Kumar
2014-07-17 23:33 ` Paul E. McKenney
2014-07-15 22:31 ` [PATCH 3/3] rcu: Use rcu_num_nodes instead of NUM_RCU_NODES Pranith Kumar
2014-07-15 22:54 ` josh
2014-07-16 12:45 ` Paul E. McKenney
2014-07-16 13:26 ` Pranith Kumar
2014-07-15 22:52 ` [PATCH 1/3] rcu: tiny.c: Update reference to tree.c josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5B1F7.3000409@gmail.com \
--to=bobby.prani@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.