From: Jason Wang <jasowang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next] virtio-net: rx busy polling support
Date: Wed, 16 Jul 2014 10:44:46 +0800 [thread overview]
Message-ID: <53C5E71E.7050706@redhat.com> (raw)
In-Reply-To: <1405419703.10255.26.camel@edumazet-glaptop2.roam.corp.google.com>
On 07/15/2014 06:21 PM, Eric Dumazet wrote:
> On Tue, 2014-07-15 at 17:41 +0800, Jason Wang wrote:
>> Add basic support for rx busy polling.
>>
>> 1 byte netperf tcp_rr on mlx4 shows 116% improvement: the transaction
>> rate was increased from 9151.94 to 19787.37.
> This is a misleading changelog.
>
> You forgot to describe how you allowed busy polling, as it is not
> 'automatic'
>
> If not, this patch adds two spinlock/unlock pairs in fast path.
Ok.
> Also, it looks like you could split this in smaller patches.
>
> virtnet_napi_disable_all() & virtnet_napi_enable_all() could be added in
> a separate patch for example.
Sure, will split this patch into smaller ones in V2.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: rusty@rustcorp.com.au, mst@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vlad Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH net-next] virtio-net: rx busy polling support
Date: Wed, 16 Jul 2014 10:44:46 +0800 [thread overview]
Message-ID: <53C5E71E.7050706@redhat.com> (raw)
In-Reply-To: <1405419703.10255.26.camel@edumazet-glaptop2.roam.corp.google.com>
On 07/15/2014 06:21 PM, Eric Dumazet wrote:
> On Tue, 2014-07-15 at 17:41 +0800, Jason Wang wrote:
>> Add basic support for rx busy polling.
>>
>> 1 byte netperf tcp_rr on mlx4 shows 116% improvement: the transaction
>> rate was increased from 9151.94 to 19787.37.
> This is a misleading changelog.
>
> You forgot to describe how you allowed busy polling, as it is not
> 'automatic'
>
> If not, this patch adds two spinlock/unlock pairs in fast path.
Ok.
> Also, it looks like you could split this in smaller patches.
>
> virtnet_napi_disable_all() & virtnet_napi_enable_all() could be added in
> a separate patch for example.
Sure, will split this patch into smaller ones in V2.
Thanks
next prev parent reply other threads:[~2014-07-16 2:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 9:41 [PATCH net-next] virtio-net: rx busy polling support Jason Wang
2014-07-15 9:41 ` Jason Wang
2014-07-15 10:21 ` Eric Dumazet
2014-07-15 10:21 ` Eric Dumazet
2014-07-16 2:44 ` Jason Wang [this message]
2014-07-16 2:44 ` Jason Wang
2014-07-15 11:46 ` Rusty Russell
2014-07-15 11:46 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5E71E.7050706@redhat.com \
--to=jasowang@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.