From: Stuart Longland <stuartl-EoQOJlg3kTYQrrorzV6ljw@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Roman Fietze
<roman.fietze-rVvtEhYSWBkAey3BTtE3dg@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support
Date: Wed, 16 Jul 2014 19:35:21 +1000 [thread overview]
Message-ID: <53C64759.8020505@vrt.com.au> (raw)
In-Reply-To: <20140716085904.GA26951@leverpostej>
Hi Mark,
On 16/07/14 18:59, Mark Rutland wrote:
> On Wed, Jul 16, 2014 at 03:28:25AM +0100, Stuart Longland wrote:
>> Add some support for configuring isl12020/isl12022 devices using the
>> Device Tree blob.
>>
>> Signed-off-by: Stuart Longland <stuartl-EoQOJlg3kTYQrrorzV6ljw@public.gmane.org>
>
> Please document this as with isl,isl12057, in
> Documentation/devicetree/bindings/i2c/trivial-devices.txt
>
> The string itself looks fine.
No problems. I'll do this shortly.
>> +#ifdef CONFIG_OF
>> + .of_match_table = of_match_ptr(isl12022_dt_match),
>> +#endif
>
> You can drop the ifdef here, of_match_ptr(x) is NULL if !CONFIG_OF.
Ahh okay, I wasn't sure how of_match_ptr worked, so I thought I'd play
it safe. A revised patch is coming right up.
Regards,
--
Stuart Longland
Systems Engineer
_ ___
\ /|_) | T: +61 7 3535 9619
\/ | \ | 38b Douglas Street F: +61 7 3535 9699
SYSTEMS Milton QLD 4064 http://www.vrt.com.au
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stuart Longland <stuartl@vrt.com.au>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Roman Fietze <roman.fietze@telemotive.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support
Date: Wed, 16 Jul 2014 19:35:21 +1000 [thread overview]
Message-ID: <53C64759.8020505@vrt.com.au> (raw)
In-Reply-To: <20140716085904.GA26951@leverpostej>
Hi Mark,
On 16/07/14 18:59, Mark Rutland wrote:
> On Wed, Jul 16, 2014 at 03:28:25AM +0100, Stuart Longland wrote:
>> Add some support for configuring isl12020/isl12022 devices using the
>> Device Tree blob.
>>
>> Signed-off-by: Stuart Longland <stuartl@vrt.com.au>
>
> Please document this as with isl,isl12057, in
> Documentation/devicetree/bindings/i2c/trivial-devices.txt
>
> The string itself looks fine.
No problems. I'll do this shortly.
>> +#ifdef CONFIG_OF
>> + .of_match_table = of_match_ptr(isl12022_dt_match),
>> +#endif
>
> You can drop the ifdef here, of_match_ptr(x) is NULL if !CONFIG_OF.
Ahh okay, I wasn't sure how of_match_ptr worked, so I thought I'd play
it safe. A revised patch is coming right up.
Regards,
--
Stuart Longland
Systems Engineer
_ ___
\ /|_) | T: +61 7 3535 9619
\/ | \ | 38b Douglas Street F: +61 7 3535 9699
SYSTEMS Milton QLD 4064 http://www.vrt.com.au
next prev parent reply other threads:[~2014-07-16 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 2:28 Add device tree support to ISL12022 driver Stuart Longland
[not found] ` <1405477705-16885-1-git-send-email-stuartl-EoQOJlg3kTYQrrorzV6ljw@public.gmane.org>
2014-07-16 2:28 ` [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support Stuart Longland
2014-07-16 2:28 ` Stuart Longland
2014-07-16 8:59 ` Mark Rutland
2014-07-16 9:35 ` Stuart Longland [this message]
2014-07-16 9:35 ` Stuart Longland
2014-07-16 21:31 ` [REVISED PATCH] " Stuart Longland
2014-07-16 21:31 ` [PATCH 1/2] " Stuart Longland
2014-07-16 21:31 ` [PATCH 2/2] devicetree: Document binding for isl12022 driver Stuart Longland
[not found] ` <1405477705-16885-2-git-send-email-stuartl-EoQOJlg3kTYQrrorzV6ljw@public.gmane.org>
2014-07-21 23:25 ` [PATCH] drivers/rtc/rtc-isl12022.c: Device tree support Andrew Morton
2014-07-21 23:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C64759.8020505@vrt.com.au \
--to=stuartl-eoqojlg3ktyqrrorzv6ljw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=roman.fietze-rVvtEhYSWBkAey3BTtE3dg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.