Re: [PATCH ARM v6 05/14] mini-os: import libfdt

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 16/07/14 12:07, Thomas Leonard wrote:
> From: Karim Raslan <karim.allah.ahmed@gmail.com>
>
> Looks like this is revision v1.3.0-47-gbe60268 from
> http://git.jdl.com/gitweb/?p=dtc.git
>
> The memmove implementation is from FreeBSD's
> contrib/ldns/compat/memmove.c (r246827).
>
> Signed-off-by: Karim Allah Ahmed <karim.allah.ahmed@gmail.com>
> [talex5@gmail.com: split out FDT support into a separate patch]
> [talex5@gmail.com: fixed "make clean" for FDT]
> [talex5@gmail.com: replaced GPL memmove with BSD one]
> Signed-off-by: Thomas Leonard <talex5@gmail.com>

Xen already has a copy of libfdt in xen/common/libfdt.

I think it sets a poor precedent to have multiple different copies of
the same library in the source tree.

Libraries like this should live in their own part of the Xen source tree
(libs/ or perhaps common/) and each component wanting to use them (Xen,
libxc, mini-os) can VPATH themselves access to the headers/source.

This would have the added advantage of making it obvious which shared
libraries are used by multiple components in the tree (libelf is another
example), and avoids duplication and stagnation.

~Andrew