Re: [PATCH ARM v6 12/14] mini-os: arm: interrupt controller

[Julien Grall <julien.grall@linaro.org>]

Hi Thomas,

On 07/16/2014 12:07 PM, Thomas Leonard wrote:
> +/* Note: not thread safe (but we only support one CPU for now anyway) */
> +static void gic_enable_interrupt(struct gic *gic, int irq_number,
> +        unsigned char cpu_set, unsigned char level_sensitive, unsigned char ppi)
> +{
> +    void *set_enable_reg;
> +    void *cfg_reg;
> +
> +    // set priority
> +    gic_set_priority(gic, irq_number, 0x0);
> +
> +    // set target cpus for this interrupt
> +    gic_route_interrupt(gic, irq_number, cpu_set);
> +
> +    // set level/edge triggered
> +    cfg_reg = (void *)gicd(gic, GICD_ICFGR);
> +    level_sensitive ? clear_bit_non_atomic((irq_number * 2) + 1, cfg_reg) : set_bit_non_atomic((irq_number * 2) + 1, cfg_reg);

I didn't spot this before. Why didn't you use if (level_sensitive)...?

I found this line very hard to read.

[..]

> +//FIXME Get event_irq from dt
> +#define EVENTS_IRQ 31
> +#define VIRTUALTIMER_IRQ 27

Any plan to get this from the DT soon?

The rest of the patch looks good to me.

Regards,


-- 
Julien Grall