From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>, ath10k@lists.infradead.org
Cc: vh.nguyen@actiasodielec.fr, svens@stackframe.org,
linux-wireless@vger.kernel.org
Subject: Re: [RFC/RFT 2/2] ath10k: don't start monitor vdev for promisc
Date: Wed, 16 Jul 2014 08:28:50 -0700 [thread overview]
Message-ID: <53C69A32.3090305@candelatech.com> (raw)
In-Reply-To: <1405516873-26411-2-git-send-email-michal.kazior@tieto.com>
On 07/16/2014 06:21 AM, Michal Kazior wrote:
> ath10k doesn't apply any extra rx filters so
> there's no need to start monitor vdev for
> promiscuous mode.
>
> This fixes crashes with 4addr station interface
> bridging and some very rare crashes of AP
> interfaces with bridging as well.
Ahh, I was just working on some related hack-arounds to make sure
I left a vdev slot open for the monitor interface in case some poor
person started a sniffer on an interface and made it go promisc...
With this patch, I can be sure monitor interfaces will not
be automatically created without explicit user request?
Any idea if it will be a problem to apply this to what is
effectively a 3.15 kernel?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, svens@stackframe.org,
vh.nguyen@actiasodielec.fr
Subject: Re: [RFC/RFT 2/2] ath10k: don't start monitor vdev for promisc
Date: Wed, 16 Jul 2014 08:28:50 -0700 [thread overview]
Message-ID: <53C69A32.3090305@candelatech.com> (raw)
In-Reply-To: <1405516873-26411-2-git-send-email-michal.kazior@tieto.com>
On 07/16/2014 06:21 AM, Michal Kazior wrote:
> ath10k doesn't apply any extra rx filters so
> there's no need to start monitor vdev for
> promiscuous mode.
>
> This fixes crashes with 4addr station interface
> bridging and some very rare crashes of AP
> interfaces with bridging as well.
Ahh, I was just working on some related hack-arounds to make sure
I left a vdev slot open for the monitor interface in case some poor
person started a sniffer on an interface and made it go promisc...
With this patch, I can be sure monitor interfaces will not
be automatically created without explicit user request?
Any idea if it will be a problem to apply this to what is
effectively a 3.15 kernel?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-07-16 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 13:21 [RFC/RFT 1/2] ath10k: fix monitor start/stop sequences Michal Kazior
2014-07-16 13:21 ` Michal Kazior
2014-07-16 13:21 ` [RFC/RFT 2/2] ath10k: don't start monitor vdev for promisc Michal Kazior
2014-07-16 13:21 ` Michal Kazior
2014-07-16 15:28 ` Ben Greear [this message]
2014-07-16 15:28 ` Ben Greear
2014-07-17 5:15 ` Michal Kazior
2014-07-17 5:15 ` Michal Kazior
2014-07-21 17:39 ` [RFC/RFT 1/2] ath10k: fix monitor start/stop sequences Kalle Valo
2014-07-21 17:39 ` Kalle Valo
2014-07-22 8:14 ` Michal Kazior
2014-07-22 8:14 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C69A32.3090305@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=svens@stackframe.org \
--cc=vh.nguyen@actiasodielec.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.