All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs/007: add project quota Q_XQUOTRM test
Date: Thu, 17 Jul 2014 22:02:46 +0800	[thread overview]
Message-ID: <53C7D786.1050509@oracle.com> (raw)
In-Reply-To: <20140717090714.GA16015@infradead.org>


On 07/17/2014 17:07 PM, Christoph Hellwig wrote:
> On Thu, Jul 17, 2014 at 10:30:58AM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Add test for project quota Q_XQUOTRM operations, this patch also
>> update the golden output file to match the new output.
> 
> Changing the test to require crc filesystems seems like a bad idea.
> 
> I'd suggest to simply do two passes instead: the first one unchanged,
> and the second one testing project instead of group quotas.

Sounds reasonable to me, will post an updated version soon.

Cheers,
-Jeff

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: fstests@vger.kernel.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs/007: add project quota Q_XQUOTRM test
Date: Thu, 17 Jul 2014 22:02:46 +0800	[thread overview]
Message-ID: <53C7D786.1050509@oracle.com> (raw)
In-Reply-To: <20140717090714.GA16015@infradead.org>


On 07/17/2014 17:07 PM, Christoph Hellwig wrote:
> On Thu, Jul 17, 2014 at 10:30:58AM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Add test for project quota Q_XQUOTRM operations, this patch also
>> update the golden output file to match the new output.
> 
> Changing the test to require crc filesystems seems like a bad idea.
> 
> I'd suggest to simply do two passes instead: the first one unchanged,
> and the second one testing project instead of group quotas.

Sounds reasonable to me, will post an updated version soon.

Cheers,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-07-17 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  2:30 [PATCH] xfs/007: add project quota Q_XQUOTRM test Jeff Liu
2014-07-17  2:30 ` Jeff Liu
2014-07-17  9:07 ` Christoph Hellwig
2014-07-17  9:07   ` Christoph Hellwig
2014-07-17 14:02   ` Jeff Liu [this message]
2014-07-17 14:02     ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C7D786.1050509@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.