All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Bharat Bhushan <Bharat.Bhushan@freescale.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, scottwood@freescale.com, stuart.yoder@freescale.com
Subject: Re: [PATCH] kvm: ppc: bookehv: Save restore SPRN_SPRG9 on guest entry exit
Date: Thu, 17 Jul 2014 16:16:49 +0000	[thread overview]
Message-ID: <53C7F6F1.7000100@suse.de> (raw)
In-Reply-To: <1405489773-10822-1-git-send-email-Bharat.Bhushan@freescale.com>


On 16.07.14 07:49, Bharat Bhushan wrote:
> SPRN_SPRG is used by debug interrupt handler, so this is required
> for debug support.
>
> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@freescale.com>
> ---
>   arch/powerpc/include/asm/kvm_host.h   | 1 +
>   arch/powerpc/kernel/asm-offsets.c     | 1 +
>   arch/powerpc/kvm/bookehv_interrupts.S | 4 ++++
>   3 files changed, 6 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h
> index 372b977..f9e94ed 100644
> --- a/arch/powerpc/include/asm/kvm_host.h
> +++ b/arch/powerpc/include/asm/kvm_host.h
> @@ -588,6 +588,7 @@ struct kvm_vcpu_arch {
>   	u32 mmucfg;
>   	u32 eptcfg;
>   	u32 epr;
> +	u32 sprg9;

u32? really?


Alex

>   	u32 pwrmgtcr0;
>   	u32 crit_save;
>   	/* guest debug registers*/
> diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c
> index 17ffcb4..ab9ae04 100644
> --- a/arch/powerpc/kernel/asm-offsets.c
> +++ b/arch/powerpc/kernel/asm-offsets.c
> @@ -668,6 +668,7 @@ int main(void)
>   	DEFINE(VCPU_LR, offsetof(struct kvm_vcpu, arch.lr));
>   	DEFINE(VCPU_CTR, offsetof(struct kvm_vcpu, arch.ctr));
>   	DEFINE(VCPU_PC, offsetof(struct kvm_vcpu, arch.pc));
> +	DEFINE(VCPU_SPRG9, offsetof(struct kvm_vcpu, arch.sprg9));
>   	DEFINE(VCPU_LAST_INST, offsetof(struct kvm_vcpu, arch.last_inst));
>   	DEFINE(VCPU_FAULT_DEAR, offsetof(struct kvm_vcpu, arch.fault_dear));
>   	DEFINE(VCPU_FAULT_ESR, offsetof(struct kvm_vcpu, arch.fault_esr));
> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
> index a1712b8..f45da85 100644
> --- a/arch/powerpc/kvm/bookehv_interrupts.S
> +++ b/arch/powerpc/kvm/bookehv_interrupts.S
> @@ -441,6 +441,7 @@ _GLOBAL(kvmppc_resume_host)
>   #ifdef CONFIG_64BIT
>   	PPC_LL	r3, PACA_SPRG_VDSO(r13)
>   #endif
> +	mfspr	r5, SPRN_SPRG9
>   	PPC_STD(r6, VCPU_SHARED_SPRG4, r11)
>   	mfspr	r8, SPRN_SPRG6
>   	PPC_STD(r7, VCPU_SHARED_SPRG5, r11)
> @@ -448,6 +449,7 @@ _GLOBAL(kvmppc_resume_host)
>   #ifdef CONFIG_64BIT
>   	mtspr	SPRN_SPRG_VDSO_WRITE, r3
>   #endif
> +	PPC_STD(r5, VCPU_SPRG9, r4)
>   	PPC_STD(r8, VCPU_SHARED_SPRG6, r11)
>   	mfxer	r3
>   	PPC_STD(r9, VCPU_SHARED_SPRG7, r11)
> @@ -682,7 +684,9 @@ lightweight_exit:
>   	mtspr	SPRN_SPRG5W, r6
>   	PPC_LD(r8, VCPU_SHARED_SPRG7, r11)
>   	mtspr	SPRN_SPRG6W, r7
> +	PPC_LD(r5, VCPU_SPRG9, r4)
>   	mtspr	SPRN_SPRG7W, r8
> +	mtspr	SPRN_SPRG9, r5
>   
>   	/* Load some guest volatiles. */
>   	PPC_LL	r3, VCPU_LR(r4)


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Bharat Bhushan <Bharat.Bhushan@freescale.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, scottwood@freescale.com, stuart.yoder@freescale.com
Subject: Re: [PATCH] kvm: ppc: bookehv: Save restore SPRN_SPRG9 on guest entry exit
Date: Thu, 17 Jul 2014 18:16:49 +0200	[thread overview]
Message-ID: <53C7F6F1.7000100@suse.de> (raw)
In-Reply-To: <1405489773-10822-1-git-send-email-Bharat.Bhushan@freescale.com>


On 16.07.14 07:49, Bharat Bhushan wrote:
> SPRN_SPRG is used by debug interrupt handler, so this is required
> for debug support.
>
> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@freescale.com>
> ---
>   arch/powerpc/include/asm/kvm_host.h   | 1 +
>   arch/powerpc/kernel/asm-offsets.c     | 1 +
>   arch/powerpc/kvm/bookehv_interrupts.S | 4 ++++
>   3 files changed, 6 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h
> index 372b977..f9e94ed 100644
> --- a/arch/powerpc/include/asm/kvm_host.h
> +++ b/arch/powerpc/include/asm/kvm_host.h
> @@ -588,6 +588,7 @@ struct kvm_vcpu_arch {
>   	u32 mmucfg;
>   	u32 eptcfg;
>   	u32 epr;
> +	u32 sprg9;

u32? really?


Alex

>   	u32 pwrmgtcr0;
>   	u32 crit_save;
>   	/* guest debug registers*/
> diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c
> index 17ffcb4..ab9ae04 100644
> --- a/arch/powerpc/kernel/asm-offsets.c
> +++ b/arch/powerpc/kernel/asm-offsets.c
> @@ -668,6 +668,7 @@ int main(void)
>   	DEFINE(VCPU_LR, offsetof(struct kvm_vcpu, arch.lr));
>   	DEFINE(VCPU_CTR, offsetof(struct kvm_vcpu, arch.ctr));
>   	DEFINE(VCPU_PC, offsetof(struct kvm_vcpu, arch.pc));
> +	DEFINE(VCPU_SPRG9, offsetof(struct kvm_vcpu, arch.sprg9));
>   	DEFINE(VCPU_LAST_INST, offsetof(struct kvm_vcpu, arch.last_inst));
>   	DEFINE(VCPU_FAULT_DEAR, offsetof(struct kvm_vcpu, arch.fault_dear));
>   	DEFINE(VCPU_FAULT_ESR, offsetof(struct kvm_vcpu, arch.fault_esr));
> diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S
> index a1712b8..f45da85 100644
> --- a/arch/powerpc/kvm/bookehv_interrupts.S
> +++ b/arch/powerpc/kvm/bookehv_interrupts.S
> @@ -441,6 +441,7 @@ _GLOBAL(kvmppc_resume_host)
>   #ifdef CONFIG_64BIT
>   	PPC_LL	r3, PACA_SPRG_VDSO(r13)
>   #endif
> +	mfspr	r5, SPRN_SPRG9
>   	PPC_STD(r6, VCPU_SHARED_SPRG4, r11)
>   	mfspr	r8, SPRN_SPRG6
>   	PPC_STD(r7, VCPU_SHARED_SPRG5, r11)
> @@ -448,6 +449,7 @@ _GLOBAL(kvmppc_resume_host)
>   #ifdef CONFIG_64BIT
>   	mtspr	SPRN_SPRG_VDSO_WRITE, r3
>   #endif
> +	PPC_STD(r5, VCPU_SPRG9, r4)
>   	PPC_STD(r8, VCPU_SHARED_SPRG6, r11)
>   	mfxer	r3
>   	PPC_STD(r9, VCPU_SHARED_SPRG7, r11)
> @@ -682,7 +684,9 @@ lightweight_exit:
>   	mtspr	SPRN_SPRG5W, r6
>   	PPC_LD(r8, VCPU_SHARED_SPRG7, r11)
>   	mtspr	SPRN_SPRG6W, r7
> +	PPC_LD(r5, VCPU_SPRG9, r4)
>   	mtspr	SPRN_SPRG7W, r8
> +	mtspr	SPRN_SPRG9, r5
>   
>   	/* Load some guest volatiles. */
>   	PPC_LL	r3, VCPU_LR(r4)

  reply	other threads:[~2014-07-17 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  5:49 [PATCH] kvm: ppc: bookehv: Save restore SPRN_SPRG9 on guest entry exit Bharat Bhushan
2014-07-16  5:51 ` Bharat Bhushan
2014-07-17 16:16 ` Alexander Graf [this message]
2014-07-17 16:16   ` Alexander Graf
2014-07-17 16:26   ` Bharat.Bhushan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C7F6F1.7000100@suse.de \
    --to=agraf@suse.de \
    --cc=Bharat.Bhushan@freescale.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=scottwood@freescale.com \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.