Re: [Qemu-devel] [PATCH for-2.1] po: Fix Makefile rules

[Stefan Weil <sw@weilnetz.de>]

Am 17.07.2014 19:56, schrieb Stefan Weil:
> Adding 'update' to the phony targets fixes this error:
> 
> $ LANG=C make -C po update
> make: Entering directory `/qemu/po'
>   LINK  update
> /qemu/po/de_DE.po: file not recognized: File format not recognized
> collect2: error: ld returned 1 exit status
> make: *** [update] Error 1
> make: Leaving directory `/qemu/po'
> 
> Some other phony targets (build, install) were also added, and the
> existing .PHONY statement was moved to a more prominent position at
> the beginning of the Makefile.
> 
> The patch also fixes a 2nd bug. The default target should be 'all',
> but instead 'modules' (from rules.mak) was the default. Fix this by
> adding 'all' as a target before any include statement.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> 

I just noticed that both errors which I mentioned in the commit message
only occur when there was no "make configure" run in the source tree.

My normal builds are always out-of-tree, but for po updates, running
"make -C po update" is the fastest solution, and it should work without
a prior configuration step because that is not needed for the resulting
.po files.

Stefan