* [PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0.
@ 2014-07-17 19:38 Luis Alves
2014-07-17 21:34 ` Antti Palosaari
0 siblings, 1 reply; 2+ messages in thread
From: Luis Alves @ 2014-07-17 19:38 UTC (permalink / raw)
To: linux-media; +Cc: crope, Luis Alves
Signed-off-by: Luis Alves <ljalvs@gmail.com>
---
drivers/media/dvb-frontends/si2168.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 7980741..3fed522 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -619,8 +619,10 @@ static int si2168_probe(struct i2c_client *client,
/* create mux i2c adapter for tuner */
s->adapter = i2c_add_mux_adapter(client->adapter, &client->dev, s,
0, 0, 0, si2168_select, si2168_deselect);
- if (s->adapter == NULL)
+ if (s->adapter == NULL) {
+ ret = -ENODEV;
goto err;
+ }
/* create dvb_frontend */
memcpy(&s->fe.ops, &si2168_ops, sizeof(struct dvb_frontend_ops));
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0.
2014-07-17 19:38 [PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0 Luis Alves
@ 2014-07-17 21:34 ` Antti Palosaari
0 siblings, 0 replies; 2+ messages in thread
From: Antti Palosaari @ 2014-07-17 21:34 UTC (permalink / raw)
To: Luis Alves, linux-media
Gah, there was a bug. Will apply that. Have to check if there is same
mistake on other drivers I have used I2C mux.
regards
Antti
On 07/17/2014 10:38 PM, Luis Alves wrote:
> Signed-off-by: Luis Alves <ljalvs@gmail.com>
> ---
> drivers/media/dvb-frontends/si2168.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> index 7980741..3fed522 100644
> --- a/drivers/media/dvb-frontends/si2168.c
> +++ b/drivers/media/dvb-frontends/si2168.c
> @@ -619,8 +619,10 @@ static int si2168_probe(struct i2c_client *client,
> /* create mux i2c adapter for tuner */
> s->adapter = i2c_add_mux_adapter(client->adapter, &client->dev, s,
> 0, 0, 0, si2168_select, si2168_deselect);
> - if (s->adapter == NULL)
> + if (s->adapter == NULL) {
> + ret = -ENODEV;
> goto err;
> + }
>
> /* create dvb_frontend */
> memcpy(&s->fe.ops, &si2168_ops, sizeof(struct dvb_frontend_ops));
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-17 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-17 19:38 [PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0 Luis Alves
2014-07-17 21:34 ` Antti Palosaari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.