From: Varka Bhadram <varkabhadram@gmail.com>
To: Yue Zhang <yuezha@microsoft.com>,
netdev@vger.kernel.org, driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
olaf@aepfle.de, jasowang@redhat.com, davem@davemloft.net
Cc: haiyangz@microsoft.com, kys@microsoft.com, huishao@microsoft.com,
decui@microsoft.com
Subject: Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation
Date: Fri, 18 Jul 2014 15:43:06 +0530 [thread overview]
Message-ID: <53C8F332.8010604@gmail.com> (raw)
In-Reply-To: <1405680903-28176-1-git-send-email-yuezha@microsoft.com>
On 07/18/2014 04:25 PM, Yue Zhang wrote:
> @@ -816,8 +816,21 @@ static void netvsc_link_change(struct work_struct *w)
>
> rtnl_unlock();
>
> - if (refresh)
> - call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC);
> + if (refresh) {
> + /*
> + * Keep the carrier offline for 10 seconds
> + * to notify ifplugd daemon network change
> + */
This should be networking comment style..
/* bla bla..
* bla
*/
--
Regards,
Varka Bhadram.
WARNING: multiple messages have this Message-ID (diff)
From: Varka Bhadram <varkabhadram@gmail.com>
To: Yue Zhang <yuezha@microsoft.com>,
netdev@vger.kernel.org, driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
olaf@aepfle.de, jasowang@redhat.com, davem@davemloft.net
Cc: huishao@microsoft.com, haiyangz@microsoft.com
Subject: Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation
Date: Fri, 18 Jul 2014 15:43:06 +0530 [thread overview]
Message-ID: <53C8F332.8010604@gmail.com> (raw)
In-Reply-To: <1405680903-28176-1-git-send-email-yuezha@microsoft.com>
On 07/18/2014 04:25 PM, Yue Zhang wrote:
> @@ -816,8 +816,21 @@ static void netvsc_link_change(struct work_struct *w)
>
> rtnl_unlock();
>
> - if (refresh)
> - call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC);
> + if (refresh) {
> + /*
> + * Keep the carrier offline for 10 seconds
> + * to notify ifplugd daemon network change
> + */
This should be networking comment style..
/* bla bla..
* bla
*/
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-18 10:14 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 10:55 [PATCH] Hyperv: Trigger DHCP renew after host hibernation Yue Zhang
2014-07-18 10:55 ` Yue Zhang
2014-07-18 10:13 ` Varka Bhadram [this message]
2014-07-18 10:13 ` Varka Bhadram
2014-07-21 2:45 ` Yue Zhang (OSTC DEV)
2014-07-21 2:45 ` Yue Zhang (OSTC DEV)
2014-07-18 13:40 ` Richard Weinberger
2014-07-18 13:40 ` Richard Weinberger
2014-07-21 2:44 ` Yue Zhang (OSTC DEV)
2014-07-21 2:44 ` Yue Zhang (OSTC DEV)
2014-07-21 6:55 ` Richard Weinberger
2014-07-21 6:55 ` Richard Weinberger
2014-07-21 8:05 ` Yue Zhang (OSTC DEV)
2014-07-21 8:05 ` Yue Zhang (OSTC DEV)
2014-07-21 8:17 ` Richard Weinberger
2014-07-21 8:17 ` Richard Weinberger
2014-07-21 8:44 ` Yue Zhang (OSTC DEV)
2014-07-21 8:44 ` Yue Zhang (OSTC DEV)
2014-07-21 9:01 ` Richard Weinberger
2014-07-21 9:18 ` Olaf Hering
2014-07-21 21:32 ` David Miller
2014-07-21 21:32 ` David Miller
2014-08-07 22:37 ` Richard Weinberger
2014-08-07 22:37 ` Richard Weinberger
2014-08-08 3:13 ` Dexuan Cui
2014-08-08 3:13 ` Dexuan Cui
2014-08-08 3:32 ` Greg KH
2014-08-08 3:32 ` Greg KH
2014-08-08 8:11 ` Dexuan Cui
2014-08-08 8:11 ` Dexuan Cui
2014-08-08 13:45 ` Greg KH
2014-08-08 13:45 ` Greg KH
2014-08-08 16:28 ` Stephen Hemminger
2014-08-11 3:23 ` Dexuan Cui
2014-08-11 3:51 ` Florian Fainelli
2014-08-11 4:22 ` Bill Fink
2014-08-11 4:22 ` Bill Fink
2014-08-12 7:51 ` Dexuan Cui
2014-08-12 7:51 ` Dexuan Cui
2014-08-12 7:48 ` Dexuan Cui
2014-08-12 7:48 ` Dexuan Cui
2014-08-11 10:45 ` Tom Gundersen
2014-08-11 10:45 ` Tom Gundersen
2014-08-12 8:29 ` Dexuan Cui
2014-08-12 8:29 ` Dexuan Cui
2014-08-13 13:15 ` Tom Gundersen
2014-08-13 13:15 ` Tom Gundersen
2014-08-13 13:34 ` Dan Williams
2014-08-13 13:34 ` Dan Williams
2014-08-14 5:19 ` Dexuan Cui
2014-08-14 5:19 ` Dexuan Cui
2014-08-11 3:29 ` Dexuan Cui
2014-08-11 3:29 ` Dexuan Cui
2014-07-21 9:42 ` Tom Gundersen
2014-07-21 10:21 ` Yue Zhang (OSTC DEV)
2014-07-21 10:21 ` Yue Zhang (OSTC DEV)
2014-07-21 13:11 ` Lennart Poettering
2014-07-21 13:11 ` Lennart Poettering
2014-07-21 17:17 ` Dan Williams
2014-07-21 17:17 ` Dan Williams
2014-07-21 14:06 ` Tom Gundersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C8F332.8010604@gmail.com \
--to=varkabhadram@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=huishao@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=yuezha@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.