From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent
Date: Fri, 18 Jul 2014 17:48:30 +0400 [thread overview]
Message-ID: <53C925AE.3010404@msgid.tls.msk.ru> (raw)
In-Reply-To: <1405674265-24058-5-git-send-email-pbonzini@redhat.com>
18.07.2014 13:04, Paolo Bonzini wrote:
> From: Andreas Färber <afaerber@suse.de>
>
> The current implementation depends on a configure-time generated list of
> block modules. When any of them is absent, module_load() emits a warning.
>
> This is suboptimal because extracting code to modules was mainly done to
> allow separate packaging of modules with intrusive dependencies. Absence
> of optional packages then leads to absence of modules and an error
> message, which users may recognize as new and report as error.
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
ACK!
/mjt
next prev parent reply other threads:[~2014-07-18 13:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 9:04 [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18 Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700 Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 3/6] module: Simplify module_load() Paolo Bonzini
2014-07-18 9:04 ` [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent Paolo Bonzini
2014-07-18 13:48 ` Michael Tokarev [this message]
2014-07-18 9:04 ` [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation" Paolo Bonzini
2014-07-18 11:31 ` Amit Shah
2014-07-18 11:36 ` Alexander Graf
2014-07-18 11:45 ` Amit Shah
2014-07-18 9:04 ` [Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward" Paolo Bonzini
2014-07-18 12:46 ` [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18 Peter Maydell
2014-07-18 12:55 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2014-07-18 13:31 [Qemu-devel] [PULL v2 " Paolo Bonzini
2014-07-18 13:31 ` [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C925AE.3010404@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.