All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: at91sam9x5: correct typo error for ohci clock
Date: Fri, 18 Jul 2014 15:50:56 +0200	[thread overview]
Message-ID: <53C92640.1000609@atmel.com> (raw)
In-Reply-To: <20140714081421.5f539287@bbrezillon>

On 14/07/2014 08:14, Boris BREZILLON :
> On Mon, 14 Jul 2014 11:08:14 +0800
> Bo Shen <voice.shen@atmel.com> wrote:
> 
>> Correct the typo error for the second "uhphs_clk".
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> 
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> sam9n12 dtsi has the same bug, I'll fix it

Ok, thanks to Voice and you: I try to queue them for 3.16-fixes.

Bye,

> And sorry for the mess when moving sam9n12 and sam9x5 to the CCF, I
> should have checked my clock definitions more carefully :-(.

I admit that these values are pretty hard to read: the eye get bored
quite quickly ;-)

Bye,


>> ---
>>  arch/arm/boot/dts/at91sam9x5.dtsi | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index 2ebc421..727d3a4 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -1155,8 +1155,7 @@
>>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>>  			reg = <0x00600000 0x100000>;
>>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
>> -			clocks = <&usb>, <&uhphs_clk>, <&udphs_clk>,
>> -				 <&uhpck>;
>> +			clocks = <&usb>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>>  			clock-names = "usb_clk", "ohci_clk", "hclk", "uhpck";
>>  			status = "disabled";
>>  		};
> 
> 
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Bo Shen <voice.shen@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: at91: at91sam9x5: correct typo error for ohci clock
Date: Fri, 18 Jul 2014 15:50:56 +0200	[thread overview]
Message-ID: <53C92640.1000609@atmel.com> (raw)
In-Reply-To: <20140714081421.5f539287@bbrezillon>

On 14/07/2014 08:14, Boris BREZILLON :
> On Mon, 14 Jul 2014 11:08:14 +0800
> Bo Shen <voice.shen@atmel.com> wrote:
> 
>> Correct the typo error for the second "uhphs_clk".
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> 
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> sam9n12 dtsi has the same bug, I'll fix it

Ok, thanks to Voice and you: I try to queue them for 3.16-fixes.

Bye,

> And sorry for the mess when moving sam9n12 and sam9x5 to the CCF, I
> should have checked my clock definitions more carefully :-(.

I admit that these values are pretty hard to read: the eye get bored
quite quickly ;-)

Bye,


>> ---
>>  arch/arm/boot/dts/at91sam9x5.dtsi | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index 2ebc421..727d3a4 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -1155,8 +1155,7 @@
>>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>>  			reg = <0x00600000 0x100000>;
>>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
>> -			clocks = <&usb>, <&uhphs_clk>, <&udphs_clk>,
>> -				 <&uhpck>;
>> +			clocks = <&usb>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>>  			clock-names = "usb_clk", "ohci_clk", "hclk", "uhpck";
>>  			status = "disabled";
>>  		};
> 
> 
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Bo Shen <voice.shen@atmel.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: at91: at91sam9x5: correct typo error for ohci clock
Date: Fri, 18 Jul 2014 15:50:56 +0200	[thread overview]
Message-ID: <53C92640.1000609@atmel.com> (raw)
In-Reply-To: <20140714081421.5f539287@bbrezillon>

On 14/07/2014 08:14, Boris BREZILLON :
> On Mon, 14 Jul 2014 11:08:14 +0800
> Bo Shen <voice.shen@atmel.com> wrote:
> 
>> Correct the typo error for the second "uhphs_clk".
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> 
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> sam9n12 dtsi has the same bug, I'll fix it

Ok, thanks to Voice and you: I try to queue them for 3.16-fixes.

Bye,

> And sorry for the mess when moving sam9n12 and sam9x5 to the CCF, I
> should have checked my clock definitions more carefully :-(.

I admit that these values are pretty hard to read: the eye get bored
quite quickly ;-)

Bye,


>> ---
>>  arch/arm/boot/dts/at91sam9x5.dtsi | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index 2ebc421..727d3a4 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -1155,8 +1155,7 @@
>>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>>  			reg = <0x00600000 0x100000>;
>>  			interrupts = <22 IRQ_TYPE_LEVEL_HIGH 2>;
>> -			clocks = <&usb>, <&uhphs_clk>, <&udphs_clk>,
>> -				 <&uhpck>;
>> +			clocks = <&usb>, <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
>>  			clock-names = "usb_clk", "ohci_clk", "hclk", "uhpck";
>>  			status = "disabled";
>>  		};
> 
> 
> 


-- 
Nicolas Ferre

  reply	other threads:[~2014-07-18 13:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14  3:08 [PATCH] ARM: at91: at91sam9x5: correct typo error for ohci clock Bo Shen
2014-07-14  3:08 ` Bo Shen
2014-07-14  3:08 ` Bo Shen
2014-07-14  6:14 ` Boris BREZILLON
2014-07-14  6:14   ` Boris BREZILLON
2014-07-14  6:14   ` Boris BREZILLON
2014-07-18 13:50   ` Nicolas Ferre [this message]
2014-07-18 13:50     ` Nicolas Ferre
2014-07-18 13:50     ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C92640.1000609@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.