From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, aliguori@amazon.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names
Date: Fri, 18 Jul 2014 16:19:17 +0200 [thread overview]
Message-ID: <53C92CE5.8020806@redhat.com> (raw)
In-Reply-To: <53C92C02.5020608@suse.de>
Il 18/07/2014 16:15, Andreas Färber ha scritto:
> I was mainly concerned about qom-set, but same goes for qom-get. The
> breakage would be in 2.2, if in 2.1 we introduce properties with foo_bar
> and rename them to foo-bar in 2.2. Since they're not in 2.0, I had asked
> Marcel to rename them for 2.1 on a KVM call.
>
> I checked that sPAPR is not affected, so the only issue is the trivial
> g_free(). Since apart from sPAPR we have a compact snippet of properties
> being added, grep'ing for occurrences of the old strings and verifying
> that the patch changes all properties should be safe for -rc3 if Peter
> would be willing to take a pull.
Okay, I agree.
Paolo
next prev parent reply other threads:[~2014-07-18 14:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 9:09 [Qemu-devel] [PATCH] machine: replace underscores in machine's property names Marcel Apfelbaum
2014-06-29 11:37 ` Michael S. Tsirkin
2014-07-17 14:15 ` Marcel Apfelbaum
2014-07-17 14:20 ` Paolo Bonzini
2014-07-17 15:48 ` Andreas Färber
2014-07-17 16:47 ` Michael Roth
2014-07-17 17:00 ` Paolo Bonzini
2014-07-18 14:15 ` Andreas Färber
2014-07-18 14:19 ` Paolo Bonzini [this message]
2014-07-18 16:06 ` Marcel Apfelbaum
2014-07-17 16:55 ` Peter Maydell
2014-07-17 16:59 ` Marcel Apfelbaum
2014-07-18 14:25 ` Andreas Färber
2014-07-18 14:38 ` Paolo Bonzini
2014-07-18 15:59 ` Marcel Apfelbaum
2014-07-18 16:10 ` Andreas Färber
2014-07-18 16:23 ` Marcel Apfelbaum
2014-07-18 16:32 ` Andreas Färber
2014-07-18 16:35 ` Marcel Apfelbaum
2014-07-18 20:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C92CE5.8020806@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=marcel.a@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.