All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Wang Nan <wangnan0@huawei.com>, Ingo Molnar <mingo@redhat.com>,
	Yinghai Lu <yinghai@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Pei Feiyue <peifeiyue@huawei.com>,
	linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] memory-hotplug: x86_64: suitable memory should go to ZONE_MOVABLE
Date: Fri, 18 Jul 2014 15:00:43 +0000	[thread overview]
Message-ID: <53C9369B.4070608@intel.com> (raw)
In-Reply-To: <1405670163-53747-2-git-send-email-wangnan0@huawei.com>

On 07/18/2014 12:55 AM, Wang Nan wrote:
> +	if (!zone_is_empty(movable_zone))
> +		if (zone_spans_pfn(movable_zone, start_pfn) ||
> +				(zone_end_pfn(movable_zone) <= start_pfn))
> +			zone = movable_zone;
> +

It's nice that you hit so many architectures, but is there a way to do
this that doesn't involve copying and pasting the same bit of code in to
each architecture?

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Wang Nan <wangnan0@huawei.com>, Ingo Molnar <mingo@redhat.com>,
	Yinghai Lu <yinghai@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-ia64@vger.kernel.org, Pei Feiyue <peifeiyue@huawei.com>,
	linux-sh@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/5] memory-hotplug: x86_64: suitable memory should go to ZONE_MOVABLE
Date: Fri, 18 Jul 2014 08:00:43 -0700	[thread overview]
Message-ID: <53C9369B.4070608@intel.com> (raw)
In-Reply-To: <1405670163-53747-2-git-send-email-wangnan0@huawei.com>

On 07/18/2014 12:55 AM, Wang Nan wrote:
> +	if (!zone_is_empty(movable_zone))
> +		if (zone_spans_pfn(movable_zone, start_pfn) ||
> +				(zone_end_pfn(movable_zone) <= start_pfn))
> +			zone = movable_zone;
> +

It's nice that you hit so many architectures, but is there a way to do
this that doesn't involve copying and pasting the same bit of code in to
each architecture?

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Wang Nan <wangnan0@huawei.com>, Ingo Molnar <mingo@redhat.com>,
	Yinghai Lu <yinghai@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Pei Feiyue <peifeiyue@huawei.com>,
	linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] memory-hotplug: x86_64: suitable memory should go to ZONE_MOVABLE
Date: Fri, 18 Jul 2014 08:00:43 -0700	[thread overview]
Message-ID: <53C9369B.4070608@intel.com> (raw)
In-Reply-To: <1405670163-53747-2-git-send-email-wangnan0@huawei.com>

On 07/18/2014 12:55 AM, Wang Nan wrote:
> +	if (!zone_is_empty(movable_zone))
> +		if (zone_spans_pfn(movable_zone, start_pfn) ||
> +				(zone_end_pfn(movable_zone) <= start_pfn))
> +			zone = movable_zone;
> +

It's nice that you hit so many architectures, but is there a way to do
this that doesn't involve copying and pasting the same bit of code in to
each architecture?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Wang Nan <wangnan0@huawei.com>, Ingo Molnar <mingo@redhat.com>,
	Yinghai Lu <yinghai@kernel.org>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Pei Feiyue <peifeiyue@huawei.com>,
	linux-mm@kvack.org, x86@kernel.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] memory-hotplug: x86_64: suitable memory should go to ZONE_MOVABLE
Date: Fri, 18 Jul 2014 08:00:43 -0700	[thread overview]
Message-ID: <53C9369B.4070608@intel.com> (raw)
In-Reply-To: <1405670163-53747-2-git-send-email-wangnan0@huawei.com>

On 07/18/2014 12:55 AM, Wang Nan wrote:
> +	if (!zone_is_empty(movable_zone))
> +		if (zone_spans_pfn(movable_zone, start_pfn) ||
> +				(zone_end_pfn(movable_zone) <= start_pfn))
> +			zone = movable_zone;
> +

It's nice that you hit so many architectures, but is there a way to do
this that doesn't involve copying and pasting the same bit of code in to
each architecture?

  reply	other threads:[~2014-07-18 15:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18  7:55 [PATCH 0/5] memory-hotplug: suitable memory should go to ZONE_MOVABLE Wang Nan
2014-07-18  7:55 ` Wang Nan
2014-07-18  7:55 ` Wang Nan
2014-07-18  7:55 ` Wang Nan
2014-07-18  7:55 ` [PATCH 1/5] memory-hotplug: x86_64: " Wang Nan
2014-07-18  7:55   ` Wang Nan
2014-07-18  7:55   ` Wang Nan
2014-07-18  7:55   ` Wang Nan
2014-07-18 15:00   ` Dave Hansen [this message]
2014-07-18 15:00     ` Dave Hansen
2014-07-18 15:00     ` Dave Hansen
2014-07-18 15:00     ` Dave Hansen
2014-07-18  7:56 ` [PATCH 2/5] memory-hotplug: x86_32: " Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  9:52   ` Wang Nan
2014-07-18  9:52     ` Wang Nan
2014-07-18  9:52     ` Wang Nan
2014-07-18  9:52     ` Wang Nan
2014-07-18  7:56 ` [PATCH 3/5] memory-hotplug: ia64: " Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56 ` [PATCH 4/5] memory-hotplug: sh: " Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56 ` [PATCH 5/5] memory-hotplug: powerpc: " Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  7:56   ` Wang Nan
2014-07-18  9:16 ` [PATCH 0/5] memory-hotplug: " Zhang Yanfei
2014-07-18  9:16   ` Zhang Yanfei
2014-07-18  9:16   ` Zhang Yanfei
2014-07-18  9:16   ` Zhang Yanfei
2014-07-18  9:56   ` Wang Nan
2014-07-18  9:56     ` Wang Nan
2014-07-18  9:56     ` Wang Nan
2014-07-18  9:56     ` Wang Nan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C9369B.4070608@intel.com \
    --to=dave.hansen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peifeiyue@huawei.com \
    --cc=wangnan0@huawei.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.