From: Johannes Sixt <j6t@kdbg.org>
To: John Keeping <john@keeping.me.uk>, git@vger.kernel.org
Subject: Re: [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules`
Date: Sat, 19 Jul 2014 13:37:26 +0200 [thread overview]
Message-ID: <53CA5876.40007@kdbg.org> (raw)
In-Reply-To: <a3317a7692675483f60ee10ff98e1e95a3dc4b5a.1405763157.git.john@keeping.me.uk>
Am 19.07.2014 11:45, schrieb John Keeping:
> Since the argument to `--recurse-submodules` is mandatory, it does not
> need to be stuck to the option with `=`.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
> contrib/completion/git-completion.bash | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d0b2895..06211a6 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1624,6 +1624,10 @@ __git_push_recurse_submodules="check on-demand"
> _git_push ()
> {
> case "$prev" in
> + --recurse_submodules)
This would need a dash, not an underscore.
> + __gitcomp "$__git_push_recurse_submodules"
> + return
> + ;;
> --repo)
> __gitcomp_nl "$(__git_remotes)"
> return
>
next prev parent reply other threads:[~2014-07-19 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 9:45 [PATCH 1/4] completion: add missing terminator in case statement John Keeping
2014-07-19 9:45 ` [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules` John Keeping
2014-07-19 11:37 ` Johannes Sixt [this message]
2014-07-19 15:10 ` John Keeping
2014-07-19 9:45 ` [PATCH 3/4] completion: add some missing options to `git push` John Keeping
2014-07-19 9:45 ` [PATCH 4/4] completion: complete `git push --force-with-lease=` John Keeping
2014-07-21 17:26 ` [PATCH 1/4] completion: add missing terminator in case statement Junio C Hamano
2014-07-21 20:09 ` Junio C Hamano
2014-07-22 18:22 ` John Keeping
2014-07-22 20:18 ` Junio C Hamano
2014-07-22 18:24 ` [PATCH v2 1/3] completion: complete "unstuck" `git push --recurse-submodules` John Keeping
2014-07-22 18:24 ` [PATCH v2 2/3] completion: add some missing options to `git push` John Keeping
2014-07-22 18:24 ` [PATCH v2 3/3] completion: complete `git push --force-with-lease=` John Keeping
2014-07-22 20:23 ` [PATCH v2 1/3] completion: complete "unstuck" `git push --recurse-submodules` Junio C Hamano
2014-07-22 20:57 ` John Keeping
2014-07-22 21:17 ` Junio C Hamano
2014-07-23 19:35 ` John Keeping
2014-07-23 21:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CA5876.40007@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.