From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] completion: add missing terminator in case statement
Date: Mon, 21 Jul 2014 13:09:13 -0700 [thread overview]
Message-ID: <xmqqk376iidy.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqmwc2k4h4.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 21 Jul 2014 10:26:47 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> John Keeping <john@keeping.me.uk> writes:
>
>> Signed-off-by: John Keeping <john@keeping.me.uk>
>> ---
>
> As these ;; are separators not terminators, this is not strictly
> necessary. Squashing it into a change that adds more case arms to
> this case statement is of course not just good but necessary,
> though.
s/necessary/may be &/; if you add new arms before this one, you
won't need it. But if you add one after this, you would ;-).
>> contrib/completion/git-completion.bash | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 7a6e1d7..d0b2895 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -1627,6 +1627,7 @@ _git_push ()
>> --repo)
>> __gitcomp_nl "$(__git_remotes)"
>> return
>> + ;;
>> esac
>> case "$cur" in
>> --repo=*)
next prev parent reply other threads:[~2014-07-21 20:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 9:45 [PATCH 1/4] completion: add missing terminator in case statement John Keeping
2014-07-19 9:45 ` [PATCH 2/4] completion: complete "unstuck" `git push --recurse-submodules` John Keeping
2014-07-19 11:37 ` Johannes Sixt
2014-07-19 15:10 ` John Keeping
2014-07-19 9:45 ` [PATCH 3/4] completion: add some missing options to `git push` John Keeping
2014-07-19 9:45 ` [PATCH 4/4] completion: complete `git push --force-with-lease=` John Keeping
2014-07-21 17:26 ` [PATCH 1/4] completion: add missing terminator in case statement Junio C Hamano
2014-07-21 20:09 ` Junio C Hamano [this message]
2014-07-22 18:22 ` John Keeping
2014-07-22 20:18 ` Junio C Hamano
2014-07-22 18:24 ` [PATCH v2 1/3] completion: complete "unstuck" `git push --recurse-submodules` John Keeping
2014-07-22 18:24 ` [PATCH v2 2/3] completion: add some missing options to `git push` John Keeping
2014-07-22 18:24 ` [PATCH v2 3/3] completion: complete `git push --force-with-lease=` John Keeping
2014-07-22 20:23 ` [PATCH v2 1/3] completion: complete "unstuck" `git push --recurse-submodules` Junio C Hamano
2014-07-22 20:57 ` John Keeping
2014-07-22 21:17 ` Junio C Hamano
2014-07-23 19:35 ` John Keeping
2014-07-23 21:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk376iidy.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.