All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] iio:kxcjk-1013: Correct error messages
Date: Sun, 20 Jul 2014 17:51:45 +0100	[thread overview]
Message-ID: <53CBF3A1.6030508@kernel.org> (raw)
In-Reply-To: <53C46095.9020002@linux.intel.com>

On 14/07/14 23:58, Srinivas Pandruvada wrote:
> On 07/14/2014 01:38 PM, Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
This one doesn't apply cleanly on top of Srinivas' patches that I took
earlier today.  I'll hold it for now as it's not as urgent as the next
one and sort it out after Srinivas' series is all in place.

J
>> ---
>>   drivers/iio/accel/kxcjk-1013.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
>> index 72a6dbb..a11588c 100644
>> --- a/drivers/iio/accel/kxcjk-1013.c
>> +++ b/drivers/iio/accel/kxcjk-1013.c
>> @@ -144,7 +144,7 @@ static int kxcjk1013_chip_ack_intr(struct kxcjk1013_data *data)
>>
>>       ret = i2c_smbus_read_byte_data(data->client, KXCJK1013_REG_INT_REL);
>>       if (ret < 0) {
>> -        dev_err(&data->client->dev, "Error writing reg_int_rel\n");
>> +        dev_err(&data->client->dev, "Error reading reg_int_rel\n");
>>           return ret;
>>       }
>>
>> @@ -183,7 +183,7 @@ static int kxcjk1013_chip_init(struct kxcjk1013_data *data)
>>       ret = i2c_smbus_write_byte_data(data->client, KXCJK1013_REG_CTRL1,
>>                       ret);
>>       if (ret < 0) {
>> -        dev_err(&data->client->dev, "Error reading reg_ctrl\n");
>> +        dev_err(&data->client->dev, "Error writing reg_ctrl1\n");
>>           return ret;
>>       }
>>
>> @@ -337,7 +337,7 @@ static int kxcjk1013_get_acc_reg(struct kxcjk1013_data *data, int axis)
>>       ret = i2c_smbus_read_word_data(data->client, reg);
>>       if (ret < 0) {
>>           dev_err(&data->client->dev,
>> -            "failed to read accel_%c registers\n", 'x' + axis);
>> +            "failed to read accel_%c register\n", 'x' + axis);
>>           return ret;
>>       }
>>
>>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>


  reply	other threads:[~2014-07-20 16:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 20:38 [PATCH 0/3] iio: accel driver fixes Peter Meerwald
2014-07-14 20:38 ` [PATCH 1/3] iio:kxcjk-1013: Correct error messages Peter Meerwald
2014-07-14 22:58   ` Srinivas Pandruvada
2014-07-20 16:51     ` Jonathan Cameron [this message]
2014-09-14 19:54       ` Jonathan Cameron
2014-07-14 20:38 ` [PATCH 2/3] iio:kxcjk-1013: Fix endianness in scan_type Peter Meerwald
2014-07-15 18:46   ` Srinivas Pandruvada
2014-07-20 16:53     ` Jonathan Cameron
2014-07-14 20:38 ` [PATCH 3/3] iio:bma180: Fix scale factors to report correct acceleration units Peter Meerwald
2014-07-15  6:54   ` Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CBF3A1.6030508@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.