All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] iio:kxcjk-1013: Fix endianness in scan_type
Date: Sun, 20 Jul 2014 17:53:10 +0100	[thread overview]
Message-ID: <53CBF3F6.2060601@kernel.org> (raw)
In-Reply-To: <53C576F6.2070604@linux.intel.com>

On 15/07/14 19:46, Srinivas Pandruvada wrote:
> On 07/14/2014 01:38 PM, Peter Meerwald wrote:
>> driver uses i2c_smbus_read_word_data() to the data in the trigger handler and hence
>> already does endianness conversion; the I2C chip has data in little endian, but the
>> value is provides in CPU endianness
>>
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the togreg branch of iio.git

Thanks,

>> ---
>>   drivers/iio/accel/kxcjk-1013.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
>> index a11588c..ea96170 100644
>> --- a/drivers/iio/accel/kxcjk-1013.c
>> +++ b/drivers/iio/accel/kxcjk-1013.c
>> @@ -466,7 +466,7 @@ static const struct attribute_group kxcjk1013_attrs_group = {
>>           .realbits = 12,                        \
>>           .storagebits = 16,                    \
>>           .shift = 4,                        \
>> -        .endianness = IIO_LE,                    \
>> +        .endianness = IIO_CPU,                    \
>>       },                                \
>>   }
>>
>>
> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2014-07-20 16:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 20:38 [PATCH 0/3] iio: accel driver fixes Peter Meerwald
2014-07-14 20:38 ` [PATCH 1/3] iio:kxcjk-1013: Correct error messages Peter Meerwald
2014-07-14 22:58   ` Srinivas Pandruvada
2014-07-20 16:51     ` Jonathan Cameron
2014-09-14 19:54       ` Jonathan Cameron
2014-07-14 20:38 ` [PATCH 2/3] iio:kxcjk-1013: Fix endianness in scan_type Peter Meerwald
2014-07-15 18:46   ` Srinivas Pandruvada
2014-07-20 16:53     ` Jonathan Cameron [this message]
2014-07-14 20:38 ` [PATCH 3/3] iio:bma180: Fix scale factors to report correct acceleration units Peter Meerwald
2014-07-15  6:54   ` Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CBF3F6.2060601@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.