All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Kukjin Kim <kgene.kim@samsung.com>, Kukjin Kim <kgene@kernel.org>,
	Kukjin Kim <kgene.kim@gmail.com>
Cc: Tomasz Figa <t.figa@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Abhilash Kesavan <kesavan.abhilash@gmail.com>,
	Chander Kashyap <k.chander@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"arm@kernel.org" <arm@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences
Date: Mon, 21 Jul 2014 12:23:51 +0200	[thread overview]
Message-ID: <53CCEA37.4060104@gmail.com> (raw)
In-Reply-To: <53C53A1A.6060701@samsung.com>

Hi,

On 15.07.2014 16:26, Tomasz Figa wrote:
> Forgot to CC Daniel and linux-pm. Sorry for the noise.
> 
> On 15.07.2014 16:24, Tomasz Figa wrote:
>> Due to recent consolidation of Exynos suspend and cpuidle code, some
>> parts of suspend and resume sequences are executed two times, once from
>> exynos_pm_syscore_ops and then from exynos_cpu_pm_notifier() and thus it
>> breaks suspend, at least on Exynos4-based boards. In addition, simple
>> core power down from a cpuidle driver could, in case of CPU 0 could
>> result in calling functions that are specific to suspend and deeper idle
>> states.
>>
>> This patch fixes the issue by moving those operations outside the CPU PM
>> notifier into suspend and AFTR code paths. This leads to a bit of code
>> duplication, but allows additional code simplification, so in the end
>> more code is removed than added.
>>
>> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
>> ---
>>  arch/arm/mach-exynos/pm.c        | 164 ++++++++++++++++++---------------------
>>  drivers/cpuidle/cpuidle-exynos.c |  25 +-----
>>  2 files changed, 80 insertions(+), 109 deletions(-)
>>

This is an important regression fix for 3.16 and today 3.16-rc6 was
already released...

Kukjin, could you pick up this patch and few others you missed and make
sure that it is included in 3.16-rc7? If you are busy, maybe Arnd or
Olof could take them directly?

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences
Date: Mon, 21 Jul 2014 12:23:51 +0200	[thread overview]
Message-ID: <53CCEA37.4060104@gmail.com> (raw)
In-Reply-To: <53C53A1A.6060701@samsung.com>

Hi,

On 15.07.2014 16:26, Tomasz Figa wrote:
> Forgot to CC Daniel and linux-pm. Sorry for the noise.
> 
> On 15.07.2014 16:24, Tomasz Figa wrote:
>> Due to recent consolidation of Exynos suspend and cpuidle code, some
>> parts of suspend and resume sequences are executed two times, once from
>> exynos_pm_syscore_ops and then from exynos_cpu_pm_notifier() and thus it
>> breaks suspend, at least on Exynos4-based boards. In addition, simple
>> core power down from a cpuidle driver could, in case of CPU 0 could
>> result in calling functions that are specific to suspend and deeper idle
>> states.
>>
>> This patch fixes the issue by moving those operations outside the CPU PM
>> notifier into suspend and AFTR code paths. This leads to a bit of code
>> duplication, but allows additional code simplification, so in the end
>> more code is removed than added.
>>
>> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
>> ---
>>  arch/arm/mach-exynos/pm.c        | 164 ++++++++++++++++++---------------------
>>  drivers/cpuidle/cpuidle-exynos.c |  25 +-----
>>  2 files changed, 80 insertions(+), 109 deletions(-)
>>

This is an important regression fix for 3.16 and today 3.16-rc6 was
already released...

Kukjin, could you pick up this patch and few others you missed and make
sure that it is included in 3.16-rc7? If you are busy, maybe Arnd or
Olof could take them directly?

Best regards,
Tomasz

  parent reply	other threads:[~2014-07-21 10:23 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 13:57 [PATCH 0/6] Various Samsung fixes for v3.16-rc3 Tomasz Figa
2014-06-24 13:57 ` Tomasz Figa
2014-06-24 13:57 ` [PATCH 1/6] mmc: sdhci-s3c: Fix local I/O clock gating Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-07-14  8:05   ` Jaehoon Chung
2014-07-14  8:05     ` Jaehoon Chung
2014-06-24 13:57 ` [PATCH 2/6] ARM: EXYNOS: Fix core ID used by platsmp and hotplug code Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-07-08 13:21   ` Kukjin Kim
2014-07-08 13:21     ` Kukjin Kim
2014-07-14  9:50     ` Tomasz Figa
2014-07-14  9:50       ` Tomasz Figa
2014-07-14  9:50       ` Tomasz Figa
2014-07-15 18:00       ` Kukjin Kim
2014-07-15 18:00         ` Kukjin Kim
2014-06-24 13:57 ` [PATCH 3/6] clk: samsung: exynos4: Remove SRC_MASK_ISP gates Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-25  9:58   ` Daniel Drake
2014-06-25  9:58     ` Daniel Drake
2014-06-25 10:10     ` Tomasz Figa
2014-06-25 10:10       ` Tomasz Figa
2014-06-30 13:50   ` Tomasz Figa
2014-06-30 13:50     ` Tomasz Figa
2014-06-24 13:57 ` [PATCH 4/6] ARM: SAMSUNG: Restore Samsung PM Debug functionality Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-25 10:09   ` Daniel Drake
2014-06-25 10:09     ` Daniel Drake
2014-06-25 11:41     ` Tomasz Figa
2014-06-25 11:41       ` Tomasz Figa
2014-06-25 11:43   ` [PATCH v2 " Tomasz Figa
2014-06-25 11:43     ` Tomasz Figa
2014-06-26  9:24     ` Daniel Drake
2014-06-26  9:24       ` Daniel Drake
2014-07-14  9:52     ` Tomasz Figa
2014-07-14  9:52       ` Tomasz Figa
2014-07-08 13:48   ` [PATCH " Kukjin Kim
2014-07-08 13:48     ` Kukjin Kim
2014-07-08 13:54     ` Tomasz Figa
2014-07-08 13:54       ` Tomasz Figa
2014-07-15 18:02       ` Kukjin Kim
2014-07-15 18:02         ` Kukjin Kim
2014-07-15 23:59         ` Tomasz Figa
2014-07-15 23:59           ` Tomasz Figa
2014-07-21 10:30           ` Tomasz Figa
2014-07-21 10:30             ` Tomasz Figa
2014-06-24 13:57 ` [PATCH 5/6] ARM: EXYNOS: Fix suspend/resume sequencies Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-06-24 15:33   ` Abhilash Kesavan
2014-06-24 15:33     ` Abhilash Kesavan
2014-07-08 14:02   ` Kukjin Kim
2014-07-08 14:02     ` Kukjin Kim
2014-06-24 13:57 ` [PATCH 6/6] ARM: EXYNOS: Register cpuidle device only on Exynos4210 and 5250 Tomasz Figa
2014-06-24 13:57   ` Tomasz Figa
2014-07-08 14:15   ` Kukjin Kim
2014-07-08 14:15     ` Kukjin Kim
2014-07-08 15:45     ` Bartlomiej Zolnierkiewicz
2014-07-08 15:45       ` Bartlomiej Zolnierkiewicz
2014-07-10 13:30       ` Kukjin Kim
2014-07-10 13:30         ` Kukjin Kim
2014-06-25 11:52 ` [PATCH v2 5/6] ARM: EXYNOS: Fix suspend/resume sequences Tomasz Figa
2014-06-25 11:52   ` Tomasz Figa
2014-07-14  9:54   ` Tomasz Figa
2014-07-14  9:54     ` Tomasz Figa
2014-07-15 11:19     ` Bartlomiej Zolnierkiewicz
2014-07-15 11:19       ` Bartlomiej Zolnierkiewicz
2014-07-15 12:15       ` Tomasz Figa
2014-07-15 12:15         ` Tomasz Figa
2014-07-15 14:24         ` [PATCH v3] " Tomasz Figa
2014-07-15 14:24           ` Tomasz Figa
2014-07-15 14:26           ` Tomasz Figa
2014-07-15 14:26             ` Tomasz Figa
2014-07-17 14:42             ` Tomasz Figa
2014-07-17 14:42               ` Tomasz Figa
2014-07-21 10:23             ` Tomasz Figa [this message]
2014-07-21 10:23               ` Tomasz Figa
2014-07-15 17:31         ` [PATCH v2 5/6] " Chander Kashyap
2014-07-15 17:31           ` Chander Kashyap
2014-07-01 13:54 ` [PATCH 0/6] Various Samsung fixes for v3.16-rc3 Tomasz Figa
2014-07-01 13:54   ` Tomasz Figa
2014-07-07 23:25   ` Kukjin Kim
2014-07-07 23:25     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CCEA37.4060104@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=k.chander@samsung.com \
    --cc=kesavan.abhilash@gmail.com \
    --cc=kgene.kim@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=olof@lixom.net \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.