From: David Marchand <david.marchand@6wind.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
claudio.fontana@huawei.com, jani.kokkonen@huawei.com,
cam@cs.ualberta.ca, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v2 1/2] contrib: add ivshmem client and server
Date: Mon, 21 Jul 2014 17:26:16 +0200 [thread overview]
Message-ID: <53CD3118.7060403@6wind.com> (raw)
In-Reply-To: <53CD21E1.1010908@redhat.com>
Hello Eric,
On 07/21/2014 04:21 PM, Eric Blake wrote:
> On 07/20/2014 03:38 AM, David Marchand wrote:
>> +# Copyright 2014 6WIND S.A.
>> +# All rights reserved
>
> This file has no other license, and is therefore incompatible with
> GPLv2. You'll need to resubmit under an appropriately open license.
missed the makefiles ...
>
>> +++ b/contrib/ivshmem-client/ivshmem-client.h
>> @@ -0,0 +1,238 @@
>> +/*
>> + * Copyright(c) 2014 6WIND S.A.
>> + * All rights reserved.
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2. See
>> + * the COPYING file in the top-level directory.
>
> I'm not a lawyer, but to me, this license is self-contradictory. You
> can't have "All rights reserved" and still be GPL, because the point of
> the GPL is that you are NOT reserving all rights, but explicitly
> granting your user various rights (on condition that they likewise grant
> those rights to others). But you're not the only file in the qemu code
> base with this questionable mix.
>
Hum, ok, will update.
--
David Marchand
WARNING: multiple messages have this Message-ID (diff)
From: David Marchand <david.marchand@6wind.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Olivier Matz <olivier.matz@6wind.com>,
kvm@vger.kernel.org, claudio.fontana@huawei.com,
pbonzini@redhat.com, jani.kokkonen@huawei.com,
cam@cs.ualberta.ca
Subject: Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server
Date: Mon, 21 Jul 2014 17:26:16 +0200 [thread overview]
Message-ID: <53CD3118.7060403@6wind.com> (raw)
In-Reply-To: <53CD21E1.1010908@redhat.com>
Hello Eric,
On 07/21/2014 04:21 PM, Eric Blake wrote:
> On 07/20/2014 03:38 AM, David Marchand wrote:
>> +# Copyright 2014 6WIND S.A.
>> +# All rights reserved
>
> This file has no other license, and is therefore incompatible with
> GPLv2. You'll need to resubmit under an appropriately open license.
missed the makefiles ...
>
>> +++ b/contrib/ivshmem-client/ivshmem-client.h
>> @@ -0,0 +1,238 @@
>> +/*
>> + * Copyright(c) 2014 6WIND S.A.
>> + * All rights reserved.
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2. See
>> + * the COPYING file in the top-level directory.
>
> I'm not a lawyer, but to me, this license is self-contradictory. You
> can't have "All rights reserved" and still be GPL, because the point of
> the GPL is that you are NOT reserving all rights, but explicitly
> granting your user various rights (on condition that they likewise grant
> those rights to others). But you're not the only file in the qemu code
> base with this questionable mix.
>
Hum, ok, will update.
--
David Marchand
next prev parent reply other threads:[~2014-07-21 15:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 9:38 [PATCH v2 0/2] ivshmem: update documentation, add client/server tools David Marchand
2014-07-20 9:38 ` [Qemu-devel] " David Marchand
2014-07-20 9:38 ` [PATCH v2 1/2] contrib: add ivshmem client and server David Marchand
2014-07-20 9:38 ` [Qemu-devel] " David Marchand
2014-07-21 14:21 ` Eric Blake
2014-07-21 14:21 ` [Qemu-devel] " Eric Blake
2014-07-21 14:30 ` Daniel P. Berrange
2014-07-21 14:30 ` Daniel P. Berrange
2014-07-21 15:26 ` David Marchand [this message]
2014-07-21 15:26 ` David Marchand
2014-07-21 17:35 ` Markus Armbruster
2014-07-21 17:35 ` Markus Armbruster
2014-08-08 8:49 ` David Marchand
2014-08-08 8:49 ` David Marchand
2014-07-20 9:38 ` [PATCH v2 2/2] docs: update ivshmem device spec David Marchand
2014-07-20 9:38 ` [Qemu-devel] " David Marchand
2014-07-21 8:19 ` Claudio Fontana
2014-07-21 8:19 ` [Qemu-devel] " Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CD3118.7060403@6wind.com \
--to=david.marchand@6wind.com \
--cc=cam@cs.ualberta.ca \
--cc=claudio.fontana@huawei.com \
--cc=eblake@redhat.com \
--cc=jani.kokkonen@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=olivier.matz@6wind.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.