All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] v4l: Fix ARGB32 fourcc value in the documentation
@ 2014-07-21 22:41 Laurent Pinchart
  2014-07-21 22:45 ` Hans Verkuil
  0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-07-21 22:41 UTC (permalink / raw)
  To: linux-media; +Cc: Hans Verkuil

The ARGB32 pixel format's fourcc value is defined to 'BA24' in the
videodev2.h header, but documented as 'AX24'. Fix the documentation.

Reported-by: Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
index 32feac9..4209542 100644
--- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
+++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
@@ -489,7 +489,7 @@ colorspace <constant>V4L2_COLORSPACE_SRGB</constant>.</para>
 	  </row>
 	  <row id="V4L2-PIX-FMT-ARGB32">
 	    <entry><constant>V4L2_PIX_FMT_ARGB32</constant></entry>
-	    <entry>'AX24'</entry>
+	    <entry>'BA24'</entry>
 	    <entry></entry>
 	    <entry>a<subscript>7</subscript></entry>
 	    <entry>a<subscript>6</subscript></entry>
-- 
Regards,

Laurent Pinchart


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] v4l: Fix ARGB32 fourcc value in the documentation
  2014-07-21 22:41 [PATCH] v4l: Fix ARGB32 fourcc value in the documentation Laurent Pinchart
@ 2014-07-21 22:45 ` Hans Verkuil
  2014-07-21 22:46   ` Laurent Pinchart
  0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2014-07-21 22:45 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media

On 07/22/2014 12:41 AM, Laurent Pinchart wrote:
> The ARGB32 pixel format's fourcc value is defined to 'BA24' in the
> videodev2.h header, but documented as 'AX24'. Fix the documentation.
> 
> Reported-by: Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Reported-by or Acked-by? :-)

Anyway:

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> index 32feac9..4209542 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> @@ -489,7 +489,7 @@ colorspace <constant>V4L2_COLORSPACE_SRGB</constant>.</para>
>  	  </row>
>  	  <row id="V4L2-PIX-FMT-ARGB32">
>  	    <entry><constant>V4L2_PIX_FMT_ARGB32</constant></entry>
> -	    <entry>'AX24'</entry>
> +	    <entry>'BA24'</entry>
>  	    <entry></entry>
>  	    <entry>a<subscript>7</subscript></entry>
>  	    <entry>a<subscript>6</subscript></entry>
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] v4l: Fix ARGB32 fourcc value in the documentation
  2014-07-21 22:45 ` Hans Verkuil
@ 2014-07-21 22:46   ` Laurent Pinchart
  2014-07-21 22:59     ` Hans Verkuil
  0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-07-21 22:46 UTC (permalink / raw)
  To: Hans Verkuil; +Cc: linux-media

On Tuesday 22 July 2014 00:45:05 Hans Verkuil wrote:
> On 07/22/2014 12:41 AM, Laurent Pinchart wrote:
> > The ARGB32 pixel format's fourcc value is defined to 'BA24' in the
> > videodev2.h header, but documented as 'AX24'. Fix the documentation.
> > 
> > Reported-by: Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Reported-by or Acked-by? :-)
> 
> Anyway:
> 
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

See ? git was predicting the future :-)

Linus is getting grumpy about the amount of 3.16-rc fixes. I'm thus 
considering delaying this patch to 3.17. Any objection ?

> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > 
> >  Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> > b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml index
> > 32feac9..4209542 100644
> > --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> > +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> > @@ -489,7 +489,7 @@ colorspace
> > <constant>V4L2_COLORSPACE_SRGB</constant>.</para>> 
> >  	  </row>
> >  	  <row id="V4L2-PIX-FMT-ARGB32">
> >  	    <entry><constant>V4L2_PIX_FMT_ARGB32</constant></entry>
> > -	    <entry>'AX24'</entry>
> > +	    <entry>'BA24'</entry>
> >  	    <entry></entry>
> >  	    <entry>a<subscript>7</subscript></entry>
> >  	    <entry>a<subscript>6</subscript></entry>

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] v4l: Fix ARGB32 fourcc value in the documentation
  2014-07-21 22:46   ` Laurent Pinchart
@ 2014-07-21 22:59     ` Hans Verkuil
  0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2014-07-21 22:59 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linux-media

On 07/22/2014 12:46 AM, Laurent Pinchart wrote:
> On Tuesday 22 July 2014 00:45:05 Hans Verkuil wrote:
>> On 07/22/2014 12:41 AM, Laurent Pinchart wrote:
>>> The ARGB32 pixel format's fourcc value is defined to 'BA24' in the
>>> videodev2.h header, but documented as 'AX24'. Fix the documentation.
>>>
>>> Reported-by: Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>>
>> Reported-by or Acked-by? :-)
>>
>> Anyway:
>>
>> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> 
> See ? git was predicting the future :-)
> 
> Linus is getting grumpy about the amount of 3.16-rc fixes. I'm thus 
> considering delaying this patch to 3.17. Any objection ?

No objection, the actual code is OK after all.

	Hans

> 
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> ---
>>>
>>>  Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
>>> b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml index
>>> 32feac9..4209542 100644
>>> --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
>>> +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
>>> @@ -489,7 +489,7 @@ colorspace
>>> <constant>V4L2_COLORSPACE_SRGB</constant>.</para>> 
>>>  	  </row>
>>>  	  <row id="V4L2-PIX-FMT-ARGB32">
>>>  	    <entry><constant>V4L2_PIX_FMT_ARGB32</constant></entry>
>>> -	    <entry>'AX24'</entry>
>>> +	    <entry>'BA24'</entry>
>>>  	    <entry></entry>
>>>  	    <entry>a<subscript>7</subscript></entry>
>>>  	    <entry>a<subscript>6</subscript></entry>
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-21 22:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21 22:41 [PATCH] v4l: Fix ARGB32 fourcc value in the documentation Laurent Pinchart
2014-07-21 22:45 ` Hans Verkuil
2014-07-21 22:46   ` Laurent Pinchart
2014-07-21 22:59     ` Hans Verkuil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.