From: Bart Van Assche <bvanassche@acm.org>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: multipath-tools: -fstack-protector to fstack-protector-strong change
Date: Tue, 22 Jul 2014 06:59:39 +0200 [thread overview]
Message-ID: <53CDEFBB.2040107@acm.org> (raw)
In-Reply-To: <20140721224544.GK10438@dhcp80-209.msp.redhat.com>
On 07/22/14 00:45, Benjamin Marzinski wrote:
> On Mon, Jul 21, 2014 at 05:17:32PM +0200, Sebastian Herbszt wrote:
>> Hello Benjamin,
>>
>> your patch "enable gcc format-security check" (9b7741c) not only added
>> -Wformat-security, but also changed fstack-protector to fstack-protector-strong.
>> Was this change intentional? It is not mentioned in the commit log and seems
>> to require a recent gcc:
>>
>> cc: error: unrecognized command line option ‘-fstack-protector-strong’
>> with
>> gcc version 4.8.2 20140324 [gcc-4_8-branch revision 208789] (SUSE Linux)
>
> I do think switching from fstack-protector to fstack-protector-strong is
> a good idea, and I use if for the redhat builds, but I didn't mean to
> include that change in my commit. I can send a commit to back it out if
> it's causing an annoyance. Once gcc 4.9 has been around for a while
> longer, I'll resend a commit to include it.
How about only using fstack-protector-strong if it is supported ? It
could be interesting to have a look at the Linux kernel build system. A
Makefile function called "cc-option" has been defined in
scripts/Kbuild.include that is used to test whether or not the compiler
supports a certain compiler flag.
Bart.
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2014-07-22 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 15:17 multipath-tools: -fstack-protector to fstack-protector-strong change Sebastian Herbszt
2014-07-21 22:45 ` Benjamin Marzinski
2014-07-22 4:59 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CDEFBB.2040107@acm.org \
--to=bvanassche@acm.org \
--cc=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
--cc=herbszt@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.