* multipath-tools: -fstack-protector to fstack-protector-strong change
@ 2014-07-21 15:17 Sebastian Herbszt
2014-07-21 22:45 ` Benjamin Marzinski
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Herbszt @ 2014-07-21 15:17 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: dm-devel, Sebastian Herbszt
Hello Benjamin,
your patch "enable gcc format-security check" (9b7741c) not only added
-Wformat-security, but also changed fstack-protector to fstack-protector-strong.
Was this change intentional? It is not mentioned in the commit log and seems
to require a recent gcc:
cc: error: unrecognized command line option ‘-fstack-protector-strong’
with
gcc version 4.8.2 20140324 [gcc-4_8-branch revision 208789] (SUSE Linux)
Sebastian
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: multipath-tools: -fstack-protector to fstack-protector-strong change
2014-07-21 15:17 multipath-tools: -fstack-protector to fstack-protector-strong change Sebastian Herbszt
@ 2014-07-21 22:45 ` Benjamin Marzinski
2014-07-22 4:59 ` Bart Van Assche
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Marzinski @ 2014-07-21 22:45 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: dm-devel
On Mon, Jul 21, 2014 at 05:17:32PM +0200, Sebastian Herbszt wrote:
> Hello Benjamin,
>
> your patch "enable gcc format-security check" (9b7741c) not only added
> -Wformat-security, but also changed fstack-protector to fstack-protector-strong.
> Was this change intentional? It is not mentioned in the commit log and seems
> to require a recent gcc:
>
> cc: error: unrecognized command line option ‘-fstack-protector-strong’
> with
> gcc version 4.8.2 20140324 [gcc-4_8-branch revision 208789] (SUSE Linux)
I do think switching from fstack-protector to fstack-protector-strong is
a good idea, and I use if for the redhat builds, but I didn't mean to
include that change in my commit. I can send a commit to back it out if
it's causing an annoyance. Once gcc 4.9 has been around for a while
longer, I'll resend a commit to include it.
-Ben
>
> Sebastian
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: multipath-tools: -fstack-protector to fstack-protector-strong change
2014-07-21 22:45 ` Benjamin Marzinski
@ 2014-07-22 4:59 ` Bart Van Assche
0 siblings, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2014-07-22 4:59 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: device-mapper development, Sebastian Herbszt
On 07/22/14 00:45, Benjamin Marzinski wrote:
> On Mon, Jul 21, 2014 at 05:17:32PM +0200, Sebastian Herbszt wrote:
>> Hello Benjamin,
>>
>> your patch "enable gcc format-security check" (9b7741c) not only added
>> -Wformat-security, but also changed fstack-protector to fstack-protector-strong.
>> Was this change intentional? It is not mentioned in the commit log and seems
>> to require a recent gcc:
>>
>> cc: error: unrecognized command line option ‘-fstack-protector-strong’
>> with
>> gcc version 4.8.2 20140324 [gcc-4_8-branch revision 208789] (SUSE Linux)
>
> I do think switching from fstack-protector to fstack-protector-strong is
> a good idea, and I use if for the redhat builds, but I didn't mean to
> include that change in my commit. I can send a commit to back it out if
> it's causing an annoyance. Once gcc 4.9 has been around for a while
> longer, I'll resend a commit to include it.
How about only using fstack-protector-strong if it is supported ? It
could be interesting to have a look at the Linux kernel build system. A
Makefile function called "cc-option" has been defined in
scripts/Kbuild.include that is used to test whether or not the compiler
supports a certain compiler flag.
Bart.
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-22 4:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-21 15:17 multipath-tools: -fstack-protector to fstack-protector-strong change Sebastian Herbszt
2014-07-21 22:45 ` Benjamin Marzinski
2014-07-22 4:59 ` Bart Van Assche
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.