From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: xen-devel@lists.xenproject.org,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open
Date: Tue, 22 Jul 2014 13:46:15 +0200 [thread overview]
Message-ID: <53CE4F07.40804@citrix.com> (raw)
In-Reply-To: <20140527132943.GD31463@stefanha-thinkpad.redhat.com>
On 27/05/14 15:29, Stefan Hajnoczi wrote:
> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
>> The current behaviour of tap_open for BSD systems differ greatly from
>> it's Linux counterpart. Since FreeBSD supports interface renaming and
>> tap device cloning by opening /dev/tap, implement a FreeBSD specific
>> version of tap_open that behaves like it's Linux counterpart.
>>
>> This is specially important for toolstacks that use Qemu (like Xen
>> libxl), in order to have a unified behaviour across suported
>> platforms.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: xen-devel@lists.xenproject.org
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Cc: Anthony Liguori <aliguori@us.ibm.com>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> net/tap-bsd.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 files changed, 69 insertions(+), 1 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
I still don't see this committed to the repository, should I ping someone?
Thanks, Roger.
WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: xen-devel@lists.xenproject.org,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open
Date: Tue, 22 Jul 2014 13:46:15 +0200 [thread overview]
Message-ID: <53CE4F07.40804@citrix.com> (raw)
In-Reply-To: <20140527132943.GD31463@stefanha-thinkpad.redhat.com>
On 27/05/14 15:29, Stefan Hajnoczi wrote:
> On Fri, May 23, 2014 at 05:57:48PM +0200, Roger Pau Monne wrote:
>> The current behaviour of tap_open for BSD systems differ greatly from
>> it's Linux counterpart. Since FreeBSD supports interface renaming and
>> tap device cloning by opening /dev/tap, implement a FreeBSD specific
>> version of tap_open that behaves like it's Linux counterpart.
>>
>> This is specially important for toolstacks that use Qemu (like Xen
>> libxl), in order to have a unified behaviour across suported
>> platforms.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>> Cc: xen-devel@lists.xenproject.org
>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> Cc: Anthony Liguori <aliguori@us.ibm.com>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> net/tap-bsd.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> 1 files changed, 69 insertions(+), 1 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
I still don't see this committed to the repository, should I ping someone?
Thanks, Roger.
next prev parent reply other threads:[~2014-07-22 11:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 15:57 [Qemu-devel] [PATCH v2 0/3] qemu-freebsd: fixes for running Xen guests Roger Pau Monne
2014-05-23 15:57 ` [Qemu-devel] [PATCH v2 1/3] xen: fix usage of ENODATA Roger Pau Monne
2014-05-27 17:18 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1405271816100.4779@kaball.uk.xensource.com>
2014-05-27 17:26 ` Roger Pau Monné
[not found] ` <5384CADF.8020003@citrix.com>
2014-05-28 11:28 ` [Qemu-devel] " Stefano Stabellini
2014-05-23 15:57 ` Roger Pau Monne
2014-05-23 15:57 ` [Qemu-devel] [PATCH v2 2/3] tap-bsd: implement a FreeBSD only version of tap_open Roger Pau Monne
2014-05-23 15:57 ` Roger Pau Monne
2014-05-27 13:29 ` Stefan Hajnoczi
2014-07-22 11:46 ` Roger Pau Monné [this message]
2014-07-22 11:46 ` Roger Pau Monné
2014-07-22 12:26 ` Stefano Stabellini
2014-07-22 12:26 ` [Qemu-devel] " Stefano Stabellini
2014-07-23 10:38 ` Stefan Hajnoczi
2014-07-23 10:38 ` Stefan Hajnoczi
2014-07-23 14:00 ` Roger Pau Monné
2014-07-23 14:00 ` [Qemu-devel] " Roger Pau Monné
2014-07-23 14:03 ` Stefano Stabellini
2014-07-23 14:03 ` Stefano Stabellini
2014-05-23 15:57 ` [Qemu-devel] [PATCH v2 3/3] serial: poll the serial console with G_IO_HUP Roger Pau Monne
2014-06-13 15:35 ` Roger Pau Monné
2014-06-13 15:35 ` [Qemu-devel] " Roger Pau Monné
2014-06-30 11:00 ` Roger Pau Monné
2014-06-30 11:00 ` Roger Pau Monné
2014-06-30 12:23 ` Paolo Bonzini
2014-06-30 12:23 ` Paolo Bonzini
2014-05-23 15:57 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE4F07.40804@citrix.com \
--to=roger.pau@citrix.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.