From: Varka Bhadram <varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
linux-input <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
heiko.stuebner-K3U4GQvHnyU@public.gmane.org,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support
Date: Tue, 22 Jul 2014 19:59:58 +0530 [thread overview]
Message-ID: <53CE7566.8020906@gmail.com> (raw)
In-Reply-To: <5068889.1KfVx3ksNo@wuerfel>
On Tuesday 22 July 2014 06:33 PM, Arnd Bergmann wrote:
(...)
>
> +static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
> +{
> + struct exynos_adc *info = iio_priv(indio_dev);
> + unsigned long timeout;
> + int ret;
> +
> + mutex_lock(&indio_dev->mlock);
> + info->read_ts = true;
> +
> + reinit_completion(&info->completion);
> +
> + writel(ADC_S3C2410_TSC_PULL_UP_DISABLE | ADC_TSC_AUTOPST,
> + ADC_V1_TSC(info->regs));
> +
> + /* Select the ts channel to be used and Trigger conversion */
> + info->data->start_conv(info, ADC_S3C2410_MUX_TS);
> +
> + timeout = wait_for_completion_timeout
> + (&info->completion, EXYNOS_ADC_TIMEOUT);
Should be properly aligned:
wait_for_completion_timeout(&info->completion,
EXYNOS_ADC_TIMEOUT);
--
Regards,
Varka Bhadram
WARNING: multiple messages have this Message-ID (diff)
From: Varka Bhadram <varkabhadram@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org
Cc: kgene.kim@samsung.com, pawel.moll@arm.com, t.figa@samsung.com,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Ben Dooks <ben-linux@fluff.org>,
galak@codeaurora.org, ch.naveen@samsung.com,
linux-input <linux-input@vger.kernel.org>,
heiko.stuebner@bq.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support
Date: Tue, 22 Jul 2014 19:59:58 +0530 [thread overview]
Message-ID: <53CE7566.8020906@gmail.com> (raw)
In-Reply-To: <5068889.1KfVx3ksNo@wuerfel>
On Tuesday 22 July 2014 06:33 PM, Arnd Bergmann wrote:
(...)
>
> +static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
> +{
> + struct exynos_adc *info = iio_priv(indio_dev);
> + unsigned long timeout;
> + int ret;
> +
> + mutex_lock(&indio_dev->mlock);
> + info->read_ts = true;
> +
> + reinit_completion(&info->completion);
> +
> + writel(ADC_S3C2410_TSC_PULL_UP_DISABLE | ADC_TSC_AUTOPST,
> + ADC_V1_TSC(info->regs));
> +
> + /* Select the ts channel to be used and Trigger conversion */
> + info->data->start_conv(info, ADC_S3C2410_MUX_TS);
> +
> + timeout = wait_for_completion_timeout
> + (&info->completion, EXYNOS_ADC_TIMEOUT);
Should be properly aligned:
wait_for_completion_timeout(&info->completion,
EXYNOS_ADC_TIMEOUT);
--
Regards,
Varka Bhadram
WARNING: multiple messages have this Message-ID (diff)
From: varkabhadram@gmail.com (Varka Bhadram)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] iio: exynos-adc: add experimental touchscreen support
Date: Tue, 22 Jul 2014 19:59:58 +0530 [thread overview]
Message-ID: <53CE7566.8020906@gmail.com> (raw)
In-Reply-To: <5068889.1KfVx3ksNo@wuerfel>
On Tuesday 22 July 2014 06:33 PM, Arnd Bergmann wrote:
(...)
>
> +static int exynos_read_s3c64xx_ts(struct iio_dev *indio_dev, int *x, int *y)
> +{
> + struct exynos_adc *info = iio_priv(indio_dev);
> + unsigned long timeout;
> + int ret;
> +
> + mutex_lock(&indio_dev->mlock);
> + info->read_ts = true;
> +
> + reinit_completion(&info->completion);
> +
> + writel(ADC_S3C2410_TSC_PULL_UP_DISABLE | ADC_TSC_AUTOPST,
> + ADC_V1_TSC(info->regs));
> +
> + /* Select the ts channel to be used and Trigger conversion */
> + info->data->start_conv(info, ADC_S3C2410_MUX_TS);
> +
> + timeout = wait_for_completion_timeout
> + (&info->completion, EXYNOS_ADC_TIMEOUT);
Should be properly aligned:
wait_for_completion_timeout(&info->completion,
EXYNOS_ADC_TIMEOUT);
--
Regards,
Varka Bhadram
next prev parent reply other threads:[~2014-07-22 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 13:03 [PATCH v2] iio: exynos-adc: add experimental touchscreen support Arnd Bergmann
2014-07-22 13:03 ` Arnd Bergmann
2014-07-22 13:03 ` Arnd Bergmann
2014-07-22 14:29 ` Varka Bhadram [this message]
2014-07-22 14:29 ` Varka Bhadram
2014-07-22 14:29 ` Varka Bhadram
2014-07-22 18:09 ` Dmitry Torokhov
2014-07-22 18:09 ` Dmitry Torokhov
[not found] ` <20140722180904.GB5489-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-07-22 18:33 ` Arnd Bergmann
2014-07-22 18:33 ` Arnd Bergmann
2014-07-22 18:33 ` Arnd Bergmann
2014-07-27 21:10 ` Hartmut Knaack
2014-07-27 21:10 ` Hartmut Knaack
2014-07-27 21:10 ` Hartmut Knaack
[not found] ` <53D56ABD.8080808-Mmb7MZpHnFY@public.gmane.org>
2014-07-27 21:50 ` Heiko Stübner
2014-07-27 21:50 ` Heiko Stübner
2014-07-27 21:50 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE7566.8020906@gmail.com \
--to=varkabhadram-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko.stuebner-K3U4GQvHnyU@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.