All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: ch.naveen@samsung.com, arnd@arndb.de, kgene.kim@samsung.com,
	kyungmin.park@samsung.com, t.figa@samsung.com,
	linux-iio@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org
Subject: Re: [PATCHv8 4/4] ARM: dts: Fix wrong compatible string for Exynos3250 ADC
Date: Wed, 23 Jul 2014 21:59:36 +0100	[thread overview]
Message-ID: <53D02238.40001@kernel.org> (raw)
In-Reply-To: <1405994696-3117-5-git-send-email-cw00.choi@samsung.com>

On 22/07/14 03:04, Chanwoo Choi wrote:
> This patchset fix wrong compatible string for Exynos3250 ADC. Exynos3250 SoC
> need to control only special clock for ADC. Exynos SoC except for Exynos3250
> has not included special clock for ADC. The exynos ADC driver can control
> special clock if compatible string is 'exynos3250-adc-v2'.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied to the togreg branch of iio.git - initially pushed out as testing.

Thanks

Jonathan
> ---
>   arch/arm/boot/dts/exynos3250.dtsi | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index 15c9c87..767189a 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -407,10 +407,11 @@
>   		};
>
>   		adc: adc@126C0000 {
> -			compatible = "samsung,exynos-adc-v3";
> +			compatible = "samsung,exynos3250-adc",
> +				     "samsung,exynos-adc-v2";
>   			reg = <0x126C0000 0x100>, <0x10020718 0x4>;
>   			interrupts = <0 137 0>;
> -			clock-names = "adc", "sclk_tsadc";
> +			clock-names = "adc", "sclk";
>   			clocks = <&cmu CLK_TSADC>, <&cmu CLK_SCLK_TSADC>;
>   			#io-channel-cells = <1>;
>   			io-channel-ranges;
>


WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv8 4/4] ARM: dts: Fix wrong compatible string for Exynos3250 ADC
Date: Wed, 23 Jul 2014 21:59:36 +0100	[thread overview]
Message-ID: <53D02238.40001@kernel.org> (raw)
In-Reply-To: <1405994696-3117-5-git-send-email-cw00.choi@samsung.com>

On 22/07/14 03:04, Chanwoo Choi wrote:
> This patchset fix wrong compatible string for Exynos3250 ADC. Exynos3250 SoC
> need to control only special clock for ADC. Exynos SoC except for Exynos3250
> has not included special clock for ADC. The exynos ADC driver can control
> special clock if compatible string is 'exynos3250-adc-v2'.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied to the togreg branch of iio.git - initially pushed out as testing.

Thanks

Jonathan
> ---
>   arch/arm/boot/dts/exynos3250.dtsi | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index 15c9c87..767189a 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -407,10 +407,11 @@
>   		};
>
>   		adc: adc at 126C0000 {
> -			compatible = "samsung,exynos-adc-v3";
> +			compatible = "samsung,exynos3250-adc",
> +				     "samsung,exynos-adc-v2";
>   			reg = <0x126C0000 0x100>, <0x10020718 0x4>;
>   			interrupts = <0 137 0>;
> -			clock-names = "adc", "sclk_tsadc";
> +			clock-names = "adc", "sclk";
>   			clocks = <&cmu CLK_TSADC>, <&cmu CLK_SCLK_TSADC>;
>   			#io-channel-cells = <1>;
>   			io-channel-ranges;
>

  reply	other threads:[~2014-07-23 20:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  2:04 [PATCHv8 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean Chanwoo Choi
2014-07-22  2:04 ` Chanwoo Choi
2014-07-22  2:04 ` [PATCHv8 1/4] iio: adc: exynos_adc: Add exynos_adc_data structure to improve readability Chanwoo Choi
2014-07-22  2:04   ` Chanwoo Choi
2014-07-23 20:55   ` Jonathan Cameron
2014-07-23 20:55     ` Jonathan Cameron
2014-07-23 20:55     ` Jonathan Cameron
2014-07-22  2:04 ` [PATCHv8 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC Chanwoo Choi
2014-07-22  2:04   ` Chanwoo Choi
2014-07-22  2:04   ` Chanwoo Choi
2014-07-23 20:57   ` Jonathan Cameron
2014-07-23 20:57     ` Jonathan Cameron
2014-07-22  2:04 ` [PATCHv8 3/4] iio: devicetree: Add DT binding documentation for " Chanwoo Choi
2014-07-22  2:04   ` Chanwoo Choi
2014-07-23 20:58   ` Jonathan Cameron
2014-07-23 20:58     ` Jonathan Cameron
2014-07-22  2:04 ` [PATCHv8 4/4] ARM: dts: Fix wrong compatible string " Chanwoo Choi
2014-07-22  2:04   ` Chanwoo Choi
2014-07-23 20:59   ` Jonathan Cameron [this message]
2014-07-23 20:59     ` Jonathan Cameron
2014-07-23  1:41 ` [PATCHv8 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean Chanwoo Choi
2014-07-23  1:41   ` Chanwoo Choi
2014-07-23  1:41   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D02238.40001@kernel.org \
    --to=jic23@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ch.naveen@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.