From: Mike Qiu <qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: WARNING: at kernel/cpuset.c:1139
Date: Thu, 24 Jul 2014 10:46:20 +0800 [thread overview]
Message-ID: <53D0737C.2030305@linux.vnet.ibm.com> (raw)
In-Reply-To: <53D052FC.3070409-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On 07/24/2014 08:27 AM, Li Zefan wrote:
> On 2014/7/23 23:12, Tejun Heo wrote:
>> On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
>>> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config
>>> changes") introduce the below warning in my server.
>>>
>>> [ 35.652137] ------------[ cut here ]------------
>>> [ 35.652141] WARNING: at kernel/cpuset.c:1139
>> Hah, can you reproduce it? If so, can you detail how?
>>
> It's a typo.
>
> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
> nodes_equal(cp->mems_allowed, cp->effective_mems));
>
> should be
>
> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
> !nodes_equal(cp->mems_allowed, cp->effective_mems));
Yes, it is. This warning disappeared after this patch.
Reported-and-Tested-by: Mike Qiu <qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
To: Li Zefan <lizefan@huawei.com>
Cc: Tejun Heo <tj@kernel.org>,
cgroups@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: at kernel/cpuset.c:1139
Date: Thu, 24 Jul 2014 10:46:20 +0800 [thread overview]
Message-ID: <53D0737C.2030305@linux.vnet.ibm.com> (raw)
In-Reply-To: <53D052FC.3070409@huawei.com>
On 07/24/2014 08:27 AM, Li Zefan wrote:
> On 2014/7/23 23:12, Tejun Heo wrote:
>> On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
>>> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config
>>> changes") introduce the below warning in my server.
>>>
>>> [ 35.652137] ------------[ cut here ]------------
>>> [ 35.652141] WARNING: at kernel/cpuset.c:1139
>> Hah, can you reproduce it? If so, can you detail how?
>>
> It's a typo.
>
> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
> nodes_equal(cp->mems_allowed, cp->effective_mems));
>
> should be
>
> WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
> !nodes_equal(cp->mems_allowed, cp->effective_mems));
Yes, it is. This warning disappeared after this patch.
Reported-and-Tested-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
>
next prev parent reply other threads:[~2014-07-24 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 2:50 WARNING: at kernel/cpuset.c:1139 Mike Qiu
2014-07-23 15:12 ` Tejun Heo
[not found] ` <20140723151220.GD7103-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-07-24 0:27 ` Li Zefan
2014-07-24 0:27 ` Li Zefan
[not found] ` <53D052FC.3070409-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-24 2:46 ` Mike Qiu [this message]
2014-07-24 2:46 ` Mike Qiu
2014-07-28 19:20 ` Tejun Heo
2014-07-28 19:20 ` Tejun Heo
[not found] ` <20140728192026.GI7462-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-07-29 9:07 ` Li Zefan
2014-07-29 9:07 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D0737C.2030305@linux.vnet.ibm.com \
--to=qiudayu-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.