All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
	linux-samsung-soc@vger.kernel.org,
	Tomasz Figa <t.figa@samsung.com>,
	Sachin Kamat <sachin.kamat@samsung.com>,
	Doug Anderson <dianders@chromium.org>,
	Olof Johansson <olof@lixom.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support
Date: Fri, 25 Jul 2014 08:36:19 +0900	[thread overview]
Message-ID: <53D19873.3040806@samsung.com> (raw)
In-Reply-To: <1406227380-3569-1-git-send-email-javier.martinez@collabora.co.uk>

On 07/25/14 03:43, Javier Martinez Canillas wrote:
> Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
> a SBS-compliant gas gauge battery. Enable it as module
> so the needed support is available for these boards.
>
> Suggested-by: Doug Anderson<dianders@chromium.org>
> Signed-off-by: Javier Martinez Canillas<javier.martinez@collabora.co.uk>
> ---
>   arch/arm/configs/exynos_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index fc7d168..c390bb9 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SPI_S3C64XX=y
>   CONFIG_I2C_S3C2410=y
>   CONFIG_DEBUG_GPIO=y
>   CONFIG_POWER_SUPPLY=y
> +CONFIG_BATTERY_SBS=m
>   CONFIG_CHARGER_TPS65090=y
>   # CONFIG_HWMON is not set
>   CONFIG_THERMAL=y

Looks good to me.

Olof, since previous exynos_defconfig has been updated in arm-soc and no 
branch for it in my tree at this time, picking this into arm-soc 
directly would be better and you may add my ack on this.

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks,
Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support
Date: Fri, 25 Jul 2014 08:36:19 +0900	[thread overview]
Message-ID: <53D19873.3040806@samsung.com> (raw)
In-Reply-To: <1406227380-3569-1-git-send-email-javier.martinez@collabora.co.uk>

On 07/25/14 03:43, Javier Martinez Canillas wrote:
> Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
> a SBS-compliant gas gauge battery. Enable it as module
> so the needed support is available for these boards.
>
> Suggested-by: Doug Anderson<dianders@chromium.org>
> Signed-off-by: Javier Martinez Canillas<javier.martinez@collabora.co.uk>
> ---
>   arch/arm/configs/exynos_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index fc7d168..c390bb9 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -77,6 +77,7 @@ CONFIG_SPI_S3C64XX=y
>   CONFIG_I2C_S3C2410=y
>   CONFIG_DEBUG_GPIO=y
>   CONFIG_POWER_SUPPLY=y
> +CONFIG_BATTERY_SBS=m
>   CONFIG_CHARGER_TPS65090=y
>   # CONFIG_HWMON is not set
>   CONFIG_THERMAL=y

Looks good to me.

Olof, since previous exynos_defconfig has been updated in arm-soc and no 
branch for it in my tree at this time, picking this into arm-soc 
directly would be better and you may add my ack on this.

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks,
Kukjin

  reply	other threads:[~2014-07-24 23:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 18:43 [PATCH 1/1] ARM: exynos_defconfig: Enable SBS battery support Javier Martinez Canillas
2014-07-24 18:43 ` Javier Martinez Canillas
2014-07-24 23:36 ` Kukjin Kim [this message]
2014-07-24 23:36   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D19873.3040806@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sachin.kamat@samsung.com \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.