* [PATCH] ceph: fix sizeof(struct tYpO *) typo
@ 2014-07-25 9:26 Ilya Dryomov
2014-07-25 12:52 ` Alex Elder
0 siblings, 1 reply; 4+ messages in thread
From: Ilya Dryomov @ 2014-07-25 9:26 UTC (permalink / raw)
To: ceph-devel; +Cc: Yan Zheng
struct ceph_xattr -> struct ceph_inode_xattr
Reported-by: Toralf Förster <toralf.foerster@gmx.de>
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
---
fs/ceph/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
index f89698cdbc41..12f58d22e017 100644
--- a/fs/ceph/xattr.c
+++ b/fs/ceph/xattr.c
@@ -592,7 +592,7 @@ start:
xattr_version = ci->i_xattrs.version;
spin_unlock(&ci->i_ceph_lock);
- xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *),
+ xattrs = kcalloc(numattr, sizeof(struct ceph_inode_xattr *),
GFP_NOFS);
err = -ENOMEM;
if (!xattrs)
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: fix sizeof(struct tYpO *) typo
2014-07-25 9:26 [PATCH] ceph: fix sizeof(struct tYpO *) typo Ilya Dryomov
@ 2014-07-25 12:52 ` Alex Elder
2014-07-25 13:27 ` Ilya Dryomov
0 siblings, 1 reply; 4+ messages in thread
From: Alex Elder @ 2014-07-25 12:52 UTC (permalink / raw)
To: Ilya Dryomov, ceph-devel; +Cc: Yan Zheng
On 07/25/2014 04:26 AM, Ilya Dryomov wrote:
> struct ceph_xattr -> struct ceph_inode_xattr
Looks good. I can't find the definition of ceph_xattr.
Reviewed-by: Alex Elder <elder@linaro.org>
> Reported-by: Toralf Förster <toralf.foerster@gmx.de>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
> fs/ceph/xattr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> index f89698cdbc41..12f58d22e017 100644
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -592,7 +592,7 @@ start:
> xattr_version = ci->i_xattrs.version;
> spin_unlock(&ci->i_ceph_lock);
>
> - xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *),
> + xattrs = kcalloc(numattr, sizeof(struct ceph_inode_xattr *),
> GFP_NOFS);
> err = -ENOMEM;
> if (!xattrs)
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: fix sizeof(struct tYpO *) typo
2014-07-25 12:52 ` Alex Elder
@ 2014-07-25 13:27 ` Ilya Dryomov
2014-07-25 15:53 ` Alex Elder
0 siblings, 1 reply; 4+ messages in thread
From: Ilya Dryomov @ 2014-07-25 13:27 UTC (permalink / raw)
To: Alex Elder; +Cc: Ceph Development, Yan Zheng
On Fri, Jul 25, 2014 at 4:52 PM, Alex Elder <elder@ieee.org> wrote:
> On 07/25/2014 04:26 AM, Ilya Dryomov wrote:
>> struct ceph_xattr -> struct ceph_inode_xattr
>
> Looks good. I can't find the definition of ceph_xattr.
That's the point of the patch ;)
Thanks,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ceph: fix sizeof(struct tYpO *) typo
2014-07-25 13:27 ` Ilya Dryomov
@ 2014-07-25 15:53 ` Alex Elder
0 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2014-07-25 15:53 UTC (permalink / raw)
To: Ilya Dryomov; +Cc: Ceph Development, Yan Zheng
On 07/25/2014 08:27 AM, Ilya Dryomov wrote:
> On Fri, Jul 25, 2014 at 4:52 PM, Alex Elder <elder@ieee.org> wrote:
>> On 07/25/2014 04:26 AM, Ilya Dryomov wrote:
>>> struct ceph_xattr -> struct ceph_inode_xattr
>>
>> Looks good. I can't find the definition of ceph_xattr.
>
> That's the point of the patch ;)
Well, I thought the point was that the type was
wrong; I was surprised that the type was non-existent.
-Alex
> Thanks,
>
> Ilya
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-25 15:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-25 9:26 [PATCH] ceph: fix sizeof(struct tYpO *) typo Ilya Dryomov
2014-07-25 12:52 ` Alex Elder
2014-07-25 13:27 ` Ilya Dryomov
2014-07-25 15:53 ` Alex Elder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.