From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Bob Liu <bob.liu@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v3] mm, thp: only collapse hugepages to nodes with affinity for zone_reclaim_mode
Date: Mon, 28 Jul 2014 10:42:05 +0200 [thread overview]
Message-ID: <53D60CDD.4080801@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1407161757500.23892@chino.kir.corp.google.com>
On 07/17/2014 02:59 AM, David Rientjes wrote:
> Commit 9f1b868a13ac ("mm: thp: khugepaged: add policy for finding target
> node") improved the previous khugepaged logic which allocated a
> transparent hugepages from the node of the first page being collapsed.
>
> However, it is still possible to collapse pages to remote memory which may
> suffer from additional access latency. With the current policy, it is
> possible that 255 pages (with PAGE_SHIFT == 12) will be collapsed remotely
> if the majority are allocated from that node.
>
> When zone_reclaim_mode is enabled, it means the VM should make every attempt
> to allocate locally to prevent NUMA performance degradation. In this case,
> we do not want to collapse hugepages to remote nodes that would suffer from
> increased access latency. Thus, when zone_reclaim_mode is enabled, only
> allow collapsing to nodes with RECLAIM_DISTANCE or less.
>
> There is no functional change for systems that disable zone_reclaim_mode.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Bob Liu <bob.liu@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v3] mm, thp: only collapse hugepages to nodes with affinity for zone_reclaim_mode
Date: Mon, 28 Jul 2014 10:42:05 +0200 [thread overview]
Message-ID: <53D60CDD.4080801@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.02.1407161757500.23892@chino.kir.corp.google.com>
On 07/17/2014 02:59 AM, David Rientjes wrote:
> Commit 9f1b868a13ac ("mm: thp: khugepaged: add policy for finding target
> node") improved the previous khugepaged logic which allocated a
> transparent hugepages from the node of the first page being collapsed.
>
> However, it is still possible to collapse pages to remote memory which may
> suffer from additional access latency. With the current policy, it is
> possible that 255 pages (with PAGE_SHIFT == 12) will be collapsed remotely
> if the majority are allocated from that node.
>
> When zone_reclaim_mode is enabled, it means the VM should make every attempt
> to allocate locally to prevent NUMA performance degradation. In this case,
> we do not want to collapse hugepages to remote nodes that would suffer from
> increased access latency. Thus, when zone_reclaim_mode is enabled, only
> allow collapsing to nodes with RECLAIM_DISTANCE or less.
>
> There is no functional change for systems that disable zone_reclaim_mode.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
next prev parent reply other threads:[~2014-07-28 8:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 1:09 [patch] mm, thp: only collapse hugepages to nodes with affinity David Rientjes
2014-07-15 1:09 ` David Rientjes
2014-07-15 4:47 ` Dave Hansen
2014-07-15 4:47 ` Dave Hansen
2014-07-15 23:17 ` David Rientjes
2014-07-15 23:17 ` David Rientjes
2014-07-16 0:13 ` [patch v2] mm, tmp: only collapse hugepages to nodes with affinity for zone_reclaim_mode David Rientjes
2014-07-16 0:13 ` David Rientjes
2014-07-16 1:22 ` Bob Liu
2014-07-16 1:22 ` Bob Liu
2014-07-16 15:47 ` Vlastimil Babka
2014-07-16 15:47 ` Vlastimil Babka
2014-07-16 19:37 ` Hugh Dickins
2014-07-16 19:37 ` Hugh Dickins
2014-07-17 0:49 ` David Rientjes
2014-07-17 0:49 ` David Rientjes
2014-07-16 15:38 ` Vlastimil Babka
2014-07-16 15:38 ` Vlastimil Babka
2014-07-17 0:54 ` David Rientjes
2014-07-17 0:54 ` David Rientjes
2014-07-17 0:59 ` [patch v3] mm, thp: " David Rientjes
2014-07-17 0:59 ` David Rientjes
2014-07-17 16:28 ` Dave Hansen
2014-07-17 16:28 ` Dave Hansen
2014-07-17 21:48 ` [patch v4] " David Rientjes
2014-07-17 21:48 ` David Rientjes
2014-07-25 15:34 ` Mel Gorman
2014-07-25 15:34 ` Mel Gorman
2014-07-28 8:42 ` Vlastimil Babka [this message]
2014-07-28 8:42 ` [patch v3] " Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D60CDD.4080801@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bob.liu@oracle.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.