From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: gic-v3: Only define gic_peek_irq() when building SMP
Date: Mon, 28 Jul 2014 17:01:13 +0100 [thread overview]
Message-ID: <53D673C9.2070005@arm.com> (raw)
In-Reply-To: <1406480224-24628-1-git-send-email-broonie@kernel.org>
On 27/07/14 17:57, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> If building with CONFIG_SMP disbled (for example, with allnoconfig) then
> GCC complains that the static function gic_peek_irq() is defined but not
> used since the only reference is in the SMP initialisation code. Fix this
> by moving the function definition inside the ifdef.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Looks sane to me.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] irqchip: gic-v3: Only define gic_peek_irq() when building SMP
Date: Mon, 28 Jul 2014 17:01:13 +0100 [thread overview]
Message-ID: <53D673C9.2070005@arm.com> (raw)
In-Reply-To: <1406480224-24628-1-git-send-email-broonie@kernel.org>
On 27/07/14 17:57, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> If building with CONFIG_SMP disbled (for example, with allnoconfig) then
> GCC complains that the static function gic_peek_irq() is defined but not
> used since the only reference is in the SMP initialisation code. Fix this
> by moving the function definition inside the ifdef.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Looks sane to me.
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-07-28 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 16:57 [PATCH] irqchip: gic-v3: Only define gic_peek_irq() when building SMP Mark Brown
2014-07-27 16:57 ` Mark Brown
2014-07-28 16:01 ` Marc Zyngier [this message]
2014-07-28 16:01 ` Marc Zyngier
2014-08-17 16:57 ` Jason Cooper
2014-08-17 16:57 ` Jason Cooper
2014-09-06 12:54 ` Mark Brown
2014-09-06 12:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D673C9.2070005@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.