All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: David Rientjes <rientjes@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
	mgorman@suse.de, Ingo Molnar <mingo@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	wangnan0@huawei.com, Linux MM <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] memory hotplug: update the variables after memory removed
Date: Tue, 29 Jul 2014 17:47:41 +0800	[thread overview]
Message-ID: <53D76DBD.9080403@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407290216520.13227@chino.kir.corp.google.com>

On 2014/7/29 17:18, David Rientjes wrote:
> On Tue, 29 Jul 2014, Zhang Zhen wrote:
> 
>>>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>>>> index df1a992..fd7bd6b 100644
>>>> --- a/arch/x86/mm/init_64.c
>>>> +++ b/arch/x86/mm/init_64.c
>>>> @@ -673,15 +673,11 @@ void __init paging_init(void)
>>>>   * After memory hotplug the variables max_pfn, max_low_pfn and high_memory need
>>>>   * updating.
>>>>   */
>>>> -static void  update_end_of_memory_vars(u64 start, u64 size)
>>>> +static void  update_end_of_memory_vars(u64 end_pfn)
>>>
>>> Extra space that can be removed here at the same time as a cleanup.
>>>
>> Sorry, where is the extra space here?
>>
> 
> There are two spaces between the function identifier and the function 
> type whereas there is traditionally only one.  It existed before your 
> patch, it would just be nice to clean it up since you're already touching 
> the line.
> 
Ok. Thanks.
> 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: David Rientjes <rientjes@google.com>
Cc: Dave Hansen <dave.hansen@intel.com>, <mgorman@suse.de>,
	Ingo Molnar <mingo@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>, <wangnan0@huawei.com>,
	Linux MM <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] memory hotplug: update the variables after memory removed
Date: Tue, 29 Jul 2014 17:47:41 +0800	[thread overview]
Message-ID: <53D76DBD.9080403@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407290216520.13227@chino.kir.corp.google.com>

On 2014/7/29 17:18, David Rientjes wrote:
> On Tue, 29 Jul 2014, Zhang Zhen wrote:
> 
>>>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>>>> index df1a992..fd7bd6b 100644
>>>> --- a/arch/x86/mm/init_64.c
>>>> +++ b/arch/x86/mm/init_64.c
>>>> @@ -673,15 +673,11 @@ void __init paging_init(void)
>>>>   * After memory hotplug the variables max_pfn, max_low_pfn and high_memory need
>>>>   * updating.
>>>>   */
>>>> -static void  update_end_of_memory_vars(u64 start, u64 size)
>>>> +static void  update_end_of_memory_vars(u64 end_pfn)
>>>
>>> Extra space that can be removed here at the same time as a cleanup.
>>>
>> Sorry, where is the extra space here?
>>
> 
> There are two spaces between the function identifier and the function 
> type whereas there is traditionally only one.  It existed before your 
> patch, it would just be nice to clean it up since you're already touching 
> the line.
> 
Ok. Thanks.
> 



  reply	other threads:[~2014-07-29  9:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1406619310-20555-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-07-29  7:36 ` [PATCH v2] memory hotplug: update the variables after memory removed Zhang Zhen
2014-07-29  7:36   ` Zhang Zhen
2014-07-29  7:53   ` David Rientjes
2014-07-29  7:53     ` David Rientjes
2014-07-29  8:40     ` Zhang Zhen
2014-07-29  8:40       ` Zhang Zhen
2014-07-29  9:18       ` David Rientjes
2014-07-29  9:18         ` David Rientjes
2014-07-29  9:47         ` Zhang Zhen [this message]
2014-07-29  9:47           ` Zhang Zhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D76DBD.9080403@huawei.com \
    --to=zhenzhang.zhang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rientjes@google.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.