* [PATCH] kprobes/x86: opt: free optinsn cache when range check fails @ 2014-07-28 12:20 Wang Nan 2014-07-29 1:43 ` Masami Hiramatsu 2014-08-27 18:36 ` [tip:perf/urgent] kprobes/x86: Free 'optinsn' " tip-bot for Wang Nan 0 siblings, 2 replies; 10+ messages in thread From: Wang Nan @ 2014-07-28 12:20 UTC (permalink / raw) To: Masami Hiramatsu, Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue Cc: x86, linux-kernel, wangnan0 This patch frees optinsn slot when range check error to prevent memory leaks. Before this patch, cache entry in kprobe_insn_cache won't be freed if kprobe optimizing fails due to range check failure. Signed-off-by: Wang Nan <wangnan0@huawei.com> --- arch/x86/kernel/kprobes/opt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c index f304773..f1314d0 100644 --- a/arch/x86/kernel/kprobes/opt.c +++ b/arch/x86/kernel/kprobes/opt.c @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) * a relative jump. */ rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; - if (abs(rel) > 0x7fffffff) + if (abs(rel) > 0x7fffffff) { + __arch_remove_optimized_kprobe(op, 0); return -ERANGE; + } buf = (u8 *)op->optinsn.insn; -- 1.8.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-07-28 12:20 [PATCH] kprobes/x86: opt: free optinsn cache when range check fails Wang Nan @ 2014-07-29 1:43 ` Masami Hiramatsu 2014-07-29 1:55 ` Wang Nan 2014-08-27 12:15 ` Wang Nan 2014-08-27 18:36 ` [tip:perf/urgent] kprobes/x86: Free 'optinsn' " tip-bot for Wang Nan 1 sibling, 2 replies; 10+ messages in thread From: Masami Hiramatsu @ 2014-07-29 1:43 UTC (permalink / raw) To: Wang Nan Cc: Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel (2014/07/28 21:20), Wang Nan wrote: > This patch frees optinsn slot when range check error to prevent memory > leaks. Before this patch, cache entry in kprobe_insn_cache won't be > freed if kprobe optimizing fails due to range check failure. > > Signed-off-by: Wang Nan <wangnan0@huawei.com> Oops, thank you for finding it! Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> BTW, would you really have hit this error? I'd like to know the case if this really happens. > --- > arch/x86/kernel/kprobes/opt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c > index f304773..f1314d0 100644 > --- a/arch/x86/kernel/kprobes/opt.c > +++ b/arch/x86/kernel/kprobes/opt.c > @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) > * a relative jump. > */ > rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; > - if (abs(rel) > 0x7fffffff) > + if (abs(rel) > 0x7fffffff) { > + __arch_remove_optimized_kprobe(op, 0); > return -ERANGE; > + } > > buf = (u8 *)op->optinsn.insn; > > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-07-29 1:43 ` Masami Hiramatsu @ 2014-07-29 1:55 ` Wang Nan 2014-07-29 11:36 ` Masami Hiramatsu 2014-08-27 12:15 ` Wang Nan 1 sibling, 1 reply; 10+ messages in thread From: Wang Nan @ 2014-07-29 1:55 UTC (permalink / raw) To: Masami Hiramatsu Cc: Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel On 2014/7/29 9:43, Masami Hiramatsu wrote: > (2014/07/28 21:20), Wang Nan wrote: >> This patch frees optinsn slot when range check error to prevent memory >> leaks. Before this patch, cache entry in kprobe_insn_cache won't be >> freed if kprobe optimizing fails due to range check failure. >> >> Signed-off-by: Wang Nan <wangnan0@huawei.com> > > Oops, thank you for finding it! > > Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > BTW, would you really have hit this error? > I'd like to know the case if this really happens. I'm not really hit it on x86_64. I found this problem when trying to implement kprobe opt on arm. On arm, relative jump can only branch on/backward 64MB, which makes it a realistic problem. > >> --- >> arch/x86/kernel/kprobes/opt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c >> index f304773..f1314d0 100644 >> --- a/arch/x86/kernel/kprobes/opt.c >> +++ b/arch/x86/kernel/kprobes/opt.c >> @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) >> * a relative jump. >> */ >> rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; >> - if (abs(rel) > 0x7fffffff) >> + if (abs(rel) > 0x7fffffff) { >> + __arch_remove_optimized_kprobe(op, 0); >> return -ERANGE; >> + } >> >> buf = (u8 *)op->optinsn.insn; >> >> > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-07-29 1:55 ` Wang Nan @ 2014-07-29 11:36 ` Masami Hiramatsu 2014-08-05 7:49 ` Wang Nan 0 siblings, 1 reply; 10+ messages in thread From: Masami Hiramatsu @ 2014-07-29 11:36 UTC (permalink / raw) To: Wang Nan Cc: Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel Hi Wang, (2014/07/29 10:55), Wang Nan wrote: > On 2014/7/29 9:43, Masami Hiramatsu wrote: >> (2014/07/28 21:20), Wang Nan wrote: >>> This patch frees optinsn slot when range check error to prevent memory >>> leaks. Before this patch, cache entry in kprobe_insn_cache won't be >>> freed if kprobe optimizing fails due to range check failure. >>> >>> Signed-off-by: Wang Nan <wangnan0@huawei.com> >> >> Oops, thank you for finding it! >> >> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> >> BTW, would you really have hit this error? >> I'd like to know the case if this really happens. > > I'm not really hit it on x86_64. I found this problem when trying to implement kprobe opt on arm. That's interesting :) > > On arm, relative jump can only branch on/backward 64MB, which makes it a realistic problem. Yeah, that is what I expected on RISC processor such as ARM. Perhaps you'll need to overwrite 2 words, one is for "ldr pc, [pc, #-4]" and one is for the address data. In this case, you have no branch range limitation in 32bit mode. This requires branch destination checking for safety as x86 optprobe does. Plus, you'll have to use same technique of x86 to make a detour code and deferred optimization for overwriting multiple instructions. Put a breakpoint at the probe point, wait for synchronize_sched(), put the 2nd instruction(.data) and overwrite the breakpoint with the "ldr". :) However, that is only for arm32. For ARM64, I'm not so sure about its ISA. I guess we need a scratchpad area for that.. Anyway, please CC to me when you've done the prototyping and sending RFC. I'll review and test it. :) Thank you, > >> >>> --- >>> arch/x86/kernel/kprobes/opt.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c >>> index f304773..f1314d0 100644 >>> --- a/arch/x86/kernel/kprobes/opt.c >>> +++ b/arch/x86/kernel/kprobes/opt.c >>> @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) >>> * a relative jump. >>> */ >>> rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; >>> - if (abs(rel) > 0x7fffffff) >>> + if (abs(rel) > 0x7fffffff) { >>> + __arch_remove_optimized_kprobe(op, 0); >>> return -ERANGE; >>> + } >>> >>> buf = (u8 *)op->optinsn.insn; >>> >>> >> >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-07-29 11:36 ` Masami Hiramatsu @ 2014-08-05 7:49 ` Wang Nan 0 siblings, 0 replies; 10+ messages in thread From: Wang Nan @ 2014-08-05 7:49 UTC (permalink / raw) To: Masami Hiramatsu Cc: Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel On 2014/7/29 19:36, Masami Hiramatsu wrote: > Hi Wang, > > (2014/07/29 10:55), Wang Nan wrote: >> On 2014/7/29 9:43, Masami Hiramatsu wrote: >>> (2014/07/28 21:20), Wang Nan wrote: >>>> This patch frees optinsn slot when range check error to prevent memory >>>> leaks. Before this patch, cache entry in kprobe_insn_cache won't be >>>> freed if kprobe optimizing fails due to range check failure. >>>> >>>> Signed-off-by: Wang Nan <wangnan0@huawei.com> >>> >>> Oops, thank you for finding it! >>> >>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>> >>> BTW, would you really have hit this error? >>> I'd like to know the case if this really happens. >> >> I'm not really hit it on x86_64. I found this problem when trying to implement kprobe opt on arm. > > That's interesting :) > >> >> On arm, relative jump can only branch on/backward 64MB, which makes it a realistic problem. > > Yeah, that is what I expected on RISC processor such as ARM. > > Perhaps you'll need to overwrite 2 words, one is for "ldr pc, [pc, #-4]" and one is for > the address data. In this case, you have no branch range limitation in 32bit mode. This > requires branch destination checking for safety as x86 optprobe does. > Plus, you'll have to use same technique of x86 to make a detour code and deferred > optimization for overwriting multiple instructions. Put a breakpoint at the probe point, > wait for synchronize_sched(), put the 2nd instruction(.data) and overwrite the breakpoint > with the "ldr". :) > > However, that is only for arm32. > For ARM64, I'm not so sure about its ISA. I guess we need a scratchpad area for that.. > > Anyway, please CC to me when you've done the prototyping and sending RFC. I'll review > and test it. :) > > Thank you, > Hi Masami, I have posted my RFC patch on LKML and ARM mailing list, and also CC you. Please see: http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/277809.html Please help me review my patch, Thank you! >> >>> >>>> --- >>>> arch/x86/kernel/kprobes/opt.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c >>>> index f304773..f1314d0 100644 >>>> --- a/arch/x86/kernel/kprobes/opt.c >>>> +++ b/arch/x86/kernel/kprobes/opt.c >>>> @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) >>>> * a relative jump. >>>> */ >>>> rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; >>>> - if (abs(rel) > 0x7fffffff) >>>> + if (abs(rel) > 0x7fffffff) { >>>> + __arch_remove_optimized_kprobe(op, 0); >>>> return -ERANGE; >>>> + } >>>> >>>> buf = (u8 *)op->optinsn.insn; >>>> >>>> >>> >>> >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-07-29 1:43 ` Masami Hiramatsu 2014-07-29 1:55 ` Wang Nan @ 2014-08-27 12:15 ` Wang Nan 2014-08-27 13:37 ` Masami Hiramatsu 1 sibling, 1 reply; 10+ messages in thread From: Wang Nan @ 2014-08-27 12:15 UTC (permalink / raw) To: Masami Hiramatsu Cc: Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel On 2014/7/29 9:43, Masami Hiramatsu wrote: > (2014/07/28 21:20), Wang Nan wrote: >> This patch frees optinsn slot when range check error to prevent memory >> leaks. Before this patch, cache entry in kprobe_insn_cache won't be >> freed if kprobe optimizing fails due to range check failure. >> >> Signed-off-by: Wang Nan <wangnan0@huawei.com> > > Oops, thank you for finding it! > > Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Hi Masami Hiramatsu, I don't find this patch in newest upstream. Is there any problem? > BTW, would you really have hit this error? > I'd like to know the case if this really happens. > >> --- >> arch/x86/kernel/kprobes/opt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c >> index f304773..f1314d0 100644 >> --- a/arch/x86/kernel/kprobes/opt.c >> +++ b/arch/x86/kernel/kprobes/opt.c >> @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) >> * a relative jump. >> */ >> rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; >> - if (abs(rel) > 0x7fffffff) >> + if (abs(rel) > 0x7fffffff) { >> + __arch_remove_optimized_kprobe(op, 0); >> return -ERANGE; >> + } >> >> buf = (u8 *)op->optinsn.insn; >> >> > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-08-27 12:15 ` Wang Nan @ 2014-08-27 13:37 ` Masami Hiramatsu 2014-09-15 1:26 ` Wang Nan 0 siblings, 1 reply; 10+ messages in thread From: Masami Hiramatsu @ 2014-08-27 13:37 UTC (permalink / raw) To: Wang Nan, Ingo Molnar Cc: Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel Hi Ingo, Could you pull this for a bugfix of a memory leak? (2014/08/27 21:15), Wang Nan wrote: > On 2014/7/29 9:43, Masami Hiramatsu wrote: >> (2014/07/28 21:20), Wang Nan wrote: >>> This patch frees optinsn slot when range check error to prevent memory >>> leaks. Before this patch, cache entry in kprobe_insn_cache won't be >>> freed if kprobe optimizing fails due to range check failure. >>> >>> Signed-off-by: Wang Nan <wangnan0@huawei.com> >> >> Oops, thank you for finding it! >> >> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >> > > Hi Masami Hiramatsu, > > I don't find this patch in newest upstream. Is there any problem? > >> BTW, would you really have hit this error? >> I'd like to know the case if this really happens. >> >>> --- >>> arch/x86/kernel/kprobes/opt.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c >>> index f304773..f1314d0 100644 >>> --- a/arch/x86/kernel/kprobes/opt.c >>> +++ b/arch/x86/kernel/kprobes/opt.c >>> @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) >>> * a relative jump. >>> */ >>> rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; >>> - if (abs(rel) > 0x7fffffff) >>> + if (abs(rel) > 0x7fffffff) { >>> + __arch_remove_optimized_kprobe(op, 0); >>> return -ERANGE; >>> + } >>> >>> buf = (u8 *)op->optinsn.insn; >>> >>> >> >> > > > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-08-27 13:37 ` Masami Hiramatsu @ 2014-09-15 1:26 ` Wang Nan 2014-09-16 8:59 ` Ingo Molnar 0 siblings, 1 reply; 10+ messages in thread From: Wang Nan @ 2014-09-15 1:26 UTC (permalink / raw) To: Masami Hiramatsu, Ingo Molnar Cc: Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel, Li Zefan Hi Ingo and Masami, I still unable to find this bugfix in mainline code. Is there any problem? Thank you! On 2014/8/27 21:37, Masami Hiramatsu wrote: > > Hi Ingo, > > Could you pull this for a bugfix of a memory leak? > > (2014/08/27 21:15), Wang Nan wrote: >> On 2014/7/29 9:43, Masami Hiramatsu wrote: >>> (2014/07/28 21:20), Wang Nan wrote: >>>> This patch frees optinsn slot when range check error to prevent memory >>>> leaks. Before this patch, cache entry in kprobe_insn_cache won't be >>>> freed if kprobe optimizing fails due to range check failure. >>>> >>>> Signed-off-by: Wang Nan <wangnan0@huawei.com> >>> >>> Oops, thank you for finding it! >>> >>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >>> >> >> Hi Masami Hiramatsu, >> >> I don't find this patch in newest upstream. Is there any problem? >> >>> BTW, would you really have hit this error? >>> I'd like to know the case if this really happens. >>> >>>> --- >>>> arch/x86/kernel/kprobes/opt.c | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c >>>> index f304773..f1314d0 100644 >>>> --- a/arch/x86/kernel/kprobes/opt.c >>>> +++ b/arch/x86/kernel/kprobes/opt.c >>>> @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) >>>> * a relative jump. >>>> */ >>>> rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; >>>> - if (abs(rel) > 0x7fffffff) >>>> + if (abs(rel) > 0x7fffffff) { >>>> + __arch_remove_optimized_kprobe(op, 0); >>>> return -ERANGE; >>>> + } >>>> >>>> buf = (u8 *)op->optinsn.insn; >>>> >>>> >>> >>> >> >> >> > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kprobes/x86: opt: free optinsn cache when range check fails 2014-09-15 1:26 ` Wang Nan @ 2014-09-16 8:59 ` Ingo Molnar 0 siblings, 0 replies; 10+ messages in thread From: Ingo Molnar @ 2014-09-16 8:59 UTC (permalink / raw) To: Wang Nan Cc: Masami Hiramatsu, Ingo Molnar, Thomas Gleixner, Andi Kleen, Pei Feiyue, x86, linux-kernel, Li Zefan * Wang Nan <wangnan0@huawei.com> wrote: > Hi Ingo and Masami, > > I still unable to find this bugfix in mainline code. Is there any problem? It's in tip:perf/urgent, on its way to Linus. Thanks, Ingo ^ permalink raw reply [flat|nested] 10+ messages in thread
* [tip:perf/urgent] kprobes/x86: Free 'optinsn' cache when range check fails 2014-07-28 12:20 [PATCH] kprobes/x86: opt: free optinsn cache when range check fails Wang Nan 2014-07-29 1:43 ` Masami Hiramatsu @ 2014-08-27 18:36 ` tip-bot for Wang Nan 1 sibling, 0 replies; 10+ messages in thread From: tip-bot for Wang Nan @ 2014-08-27 18:36 UTC (permalink / raw) To: linux-tip-commits Cc: linux-kernel, hpa, mingo, masami.hiramatsu.pt, peifeiyue, wangnan0, tglx Commit-ID: 256aae5eac6d328067d1a986a7c5df6f19bdc8b4 Gitweb: http://git.kernel.org/tip/256aae5eac6d328067d1a986a7c5df6f19bdc8b4 Author: Wang Nan <wangnan0@huawei.com> AuthorDate: Mon, 28 Jul 2014 20:20:19 +0800 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 27 Aug 2014 20:24:32 +0200 kprobes/x86: Free 'optinsn' cache when range check fails This patch frees the 'optinsn' slot when we get a range check error, to prevent memory leaks. Before this patch, cache entry in kprobe_insn_cache() won't be freed if kprobe optimizing fails due to range check failure. Signed-off-by: Wang Nan <wangnan0@huawei.com> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Pei Feiyue <peifeiyue@huawei.com> Link: http://lkml.kernel.org/r/1406550019-70935-1-git-send-email-wangnan0@huawei.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/kernel/kprobes/opt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c index f304773..f1314d0 100644 --- a/arch/x86/kernel/kprobes/opt.c +++ b/arch/x86/kernel/kprobes/opt.c @@ -338,8 +338,10 @@ int arch_prepare_optimized_kprobe(struct optimized_kprobe *op) * a relative jump. */ rel = (long)op->optinsn.insn - (long)op->kp.addr + RELATIVEJUMP_SIZE; - if (abs(rel) > 0x7fffffff) + if (abs(rel) > 0x7fffffff) { + __arch_remove_optimized_kprobe(op, 0); return -ERANGE; + } buf = (u8 *)op->optinsn.insn; ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-09-16 8:59 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-28 12:20 [PATCH] kprobes/x86: opt: free optinsn cache when range check fails Wang Nan 2014-07-29 1:43 ` Masami Hiramatsu 2014-07-29 1:55 ` Wang Nan 2014-07-29 11:36 ` Masami Hiramatsu 2014-08-05 7:49 ` Wang Nan 2014-08-27 12:15 ` Wang Nan 2014-08-27 13:37 ` Masami Hiramatsu 2014-09-15 1:26 ` Wang Nan 2014-09-16 8:59 ` Ingo Molnar 2014-08-27 18:36 ` [tip:perf/urgent] kprobes/x86: Free 'optinsn' " tip-bot for Wang Nan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.