From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, keir@xen.org,
suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com,
tim@xen.org, dietmar.hahn@ts.fujitsu.com,
xen-devel@lists.xen.org, David Vrabel <david.vrabel@citrix.com>,
jun.nakajima@intel.com
Subject: Re: [PATCH v8 00/19] x86/PMU: Xen PMU PV(H) support
Date: Tue, 29 Jul 2014 11:00:26 -0400 [thread overview]
Message-ID: <53D7B70A.2090702@oracle.com> (raw)
In-Reply-To: <53D7726D020000780002728F@mail.emea.novell.com>
On 07/29/2014 04:07 AM, Jan Beulich wrote:
>>>> On 01.07.14 at 16:37, <boris.ostrovsky@oracle.com> wrote:
>> Changes in v8:
>>
>> * Cleaned up a bit definitions of struct xenpf_symdata and xen_pmu_params
>> * Added compat checks for vpmu structures
>> * Converted vpmu flag manipulation macros to inline routines
>> * Reimplemented vpmu_unload_all() to avoid long loops
>> * Reworked PMU fault generation and handling (new patch #12)
>> * Added checks for domain->vcpu[] non-NULLness
>> * Added more comments, renamed some routines and macros, code style cleanup
> Having gone through this series once more (with often just minor
> comments), I'd say the series could go in once those comments
> got addressed.
Great!
There will be one more bug fix in the next revision. I need to swap the
order of 'context_saved(prev)' and 'vpmu_load(next)' in context_switch()
because I need prev->is_running to be clear.
> But since I didn't follow the discussion of the Linux
> side patches, interface-wise it wouldn't make sense if there were
> objections in that area there. Could you please summarize the
> status of the review process there?
The kernel part is being reviewed and the comments so far (mostly from
David) were not related to interfaces. I will post the new version soon.
The tool part (perf) has not been posted yet but it has no dependence on
interfaces.
-boris
prev parent reply other threads:[~2014-07-29 15:00 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 14:37 [PATCH v8 00/19] x86/PMU: Xen PMU PV(H) support Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 01/19] common/symbols: Export hypervisor symbols to privileged guest Boris Ostrovsky
2014-07-01 15:06 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 02/19] x86/VPMU: Set MSR bitmaps only for HVM/PVH guests Boris Ostrovsky
2014-07-28 13:48 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 03/19] x86/VPMU: Make vpmu macros a bit more efficient Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 04/19] intel/VPMU: Clean up Intel VPMU code Boris Ostrovsky
2014-07-28 14:00 ` Jan Beulich
2014-07-28 16:20 ` Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 05/19] vmx: Merge MSR management routines Boris Ostrovsky
2014-07-28 14:08 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 06/19] x86/VPMU: Handle APIC_LVTPC accesses Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 07/19] intel/VPMU: MSR_CORE_PERF_GLOBAL_CTRL should be initialized to zero Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 08/19] x86/VPMU: Add public xenpmu.h Boris Ostrovsky
2014-07-28 14:21 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 09/19] x86/VPMU: Make vpmu not HVM-specific Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 10/19] x86/VPMU: Interface for setting PMU mode and flags Boris Ostrovsky
2014-07-28 15:22 ` Jan Beulich
2014-07-28 16:29 ` Boris Ostrovsky
2014-07-28 16:36 ` Jan Beulich
2014-07-28 17:13 ` Boris Ostrovsky
2014-07-29 6:19 ` Jan Beulich
2014-07-29 14:31 ` Boris Ostrovsky
2014-07-29 15:21 ` Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 11/19] x86/VPMU: Initialize PMU for PV(H) guests Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 12/19] x86/VPMU: When handling MSR accesses, leave fault injection to callers Boris Ostrovsky
2014-07-28 16:26 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 13/19] x86/VPMU: Add support for PMU register handling on PV guests Boris Ostrovsky
2014-07-28 16:33 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 14/19] x86/VPMU: Handle PMU interrupts for " Boris Ostrovsky
2014-07-29 7:39 ` Jan Beulich
2014-07-01 14:37 ` [PATCH v8 15/19] x86/VPMU: Merge vpmu_rdmsr and vpmu_wrmsr Boris Ostrovsky
2014-07-29 7:46 ` Jan Beulich
2014-07-29 14:35 ` Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 16/19] x86/VPMU: Add privileged PMU mode Boris Ostrovsky
2014-07-29 7:55 ` Jan Beulich
2014-07-29 14:49 ` Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 17/19] x86/VPMU: Save VPMU state for PV guests during context switch Boris Ostrovsky
2014-07-01 14:37 ` [PATCH v8 18/19] x86/VPMU: NMI-based VPMU support Boris Ostrovsky
2014-07-29 8:03 ` Jan Beulich
2014-07-01 14:38 ` [PATCH v8 19/19] x86/VPMU: Move VPMU files up from hvm/ directory Boris Ostrovsky
2014-07-29 8:07 ` [PATCH v8 00/19] x86/PMU: Xen PMU PV(H) support Jan Beulich
2014-07-29 15:00 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7B70A.2090702@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.