* [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier()
@ 2014-07-30 7:07 ` Li Zefan
0 siblings, 0 replies; 4+ messages in thread
From: Li Zefan @ 2014-07-30 7:07 UTC (permalink / raw)
To: Tejun Heo; +Cc: Mike Qiu, cgroups, LKML
The WARN_ON() is used to check if we break the legal hierarchy, on
which the effective mems should be equal to configured mems.
Reported-by: Mike Qiu <qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Tested-by: Mike Qiu <qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
kernel/cpuset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 53a9bbf..baa155c 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1136,7 +1136,7 @@ static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
mutex_unlock(&callback_mutex);
WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
- nodes_equal(cp->mems_allowed, cp->effective_mems));
+ !nodes_equal(cp->mems_allowed, cp->effective_mems));
update_tasks_nodemask(cp);
--
1.8.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier()
@ 2014-07-30 7:07 ` Li Zefan
0 siblings, 0 replies; 4+ messages in thread
From: Li Zefan @ 2014-07-30 7:07 UTC (permalink / raw)
To: Tejun Heo; +Cc: Mike Qiu, cgroups, LKML
The WARN_ON() is used to check if we break the legal hierarchy, on
which the effective mems should be equal to configured mems.
Reported-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Tested-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
kernel/cpuset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 53a9bbf..baa155c 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1136,7 +1136,7 @@ static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
mutex_unlock(&callback_mutex);
WARN_ON(!cgroup_on_dfl(cp->css.cgroup) &&
- nodes_equal(cp->mems_allowed, cp->effective_mems));
+ !nodes_equal(cp->mems_allowed, cp->effective_mems));
update_tasks_nodemask(cp);
--
1.8.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier()
2014-07-30 7:07 ` Li Zefan
@ 2014-07-30 15:27 ` Tejun Heo
-1 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2014-07-30 15:27 UTC (permalink / raw)
To: Li Zefan; +Cc: Mike Qiu, cgroups, LKML
On Wed, Jul 30, 2014 at 03:07:13PM +0800, Li Zefan wrote:
> The WARN_ON() is used to check if we break the legal hierarchy, on
> which the effective mems should be equal to configured mems.
>
> Reported-by: Mike Qiu <qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Tested-by: Mike Qiu <qiudayu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied to cgroup/for-3.17.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier()
@ 2014-07-30 15:27 ` Tejun Heo
0 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2014-07-30 15:27 UTC (permalink / raw)
To: Li Zefan; +Cc: Mike Qiu, cgroups, LKML
On Wed, Jul 30, 2014 at 03:07:13PM +0800, Li Zefan wrote:
> The WARN_ON() is used to check if we break the legal hierarchy, on
> which the effective mems should be equal to configured mems.
>
> Reported-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> Tested-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Applied to cgroup/for-3.17.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-30 15:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 7:07 [PATCH] cpuset: fix the WARN_ON() in update_nodemasks_hier() Li Zefan
2014-07-30 7:07 ` Li Zefan
[not found] ` <53D899A1.3080003-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-07-30 15:27 ` Tejun Heo
2014-07-30 15:27 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.