From: Saul Wold <sgw@linux.intel.com>
To: Patrice B <pbfwdlist@gmail.com>, poky@yoctoproject.org
Subject: Re: [PATCH 1/1] Add patch 0001-Typo-in-fuser-makes-M-on-all-the-time.patch
Date: Wed, 30 Jul 2014 00:34:55 -0700 [thread overview]
Message-ID: <53D8A01F.9020305@linux.intel.com> (raw)
In-Reply-To: <1406699656.22364.4.camel@localhost.localdomain>
This patch should be sent to openembedded-core@
On 07/29/2014 10:54 PM, Patrice B wrote:
> This patch fixes a major bug in fuser that makes it behave as if -M
> option is always used ( http://bugs.debian.org/740275 ). Hoping the
> patches is correctly done...
>
> Signed-off-by: Patrice Bouchand <pbfwdlist at gmail.com>
>
> ---
> ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
> meta/recipes-extended/psmisc/psmisc_22.21.bb | 2 +
> 2 files changed, 46 insertions(+)
> create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch
>
> diff --git a/meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch b/meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch
> new file mode 100644
> index 0000000..3a4c9a9
> --- /dev/null
> +++ b/meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch
> @@ -0,0 +1,44 @@
> +From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001
> +From: Brad Jorsch <anomie@users.sourceforge.net>
> +Date: Fri, 28 Feb 2014 21:55:02 +1100
> +Subject: [PATCH] Typo in fuser makes -M on all the time
> +
> +Brad found that fuser had the -M option on all the time.
> +A simple but significant typo caused this, thanks the the patch.
> +
> +Bug-Debian: http://bugs.debian.org/740275
> +
> +Signed-off-by: Craig Small <csmall@enc.com.au>
This needs an Upstream-Status: Backport?
> +---
> + ChangeLog | 4 ++++
> + src/fuser.c | 2 +-
> + 2 files changed, 5 insertions(+), 1 deletion(-)
> +
> +diff --git a/ChangeLog b/ChangeLog
> +index fd1cccf..e5f784c 100644
> +--- a/ChangeLog
> ++++ b/ChangeLog
> +@@ -1,3 +1,7 @@
> ++Changes in 22.22
> ++================
> ++ * Fixed typo in fuser which has -M on Debian #740275
> ++
> + Changes in 22.21
> + ================
> + * Missing comma in fuser(1) added Debian #702391
> +diff --git a/src/fuser.c b/src/fuser.c
> +index b485f65..389b302 100644
> +--- a/src/fuser.c
> ++++ b/src/fuser.c
> +@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
> + usage(_("No process specification given"));
> +
> + /* Check if -M flag was used and if so check mounts */
> +- if (opts * OPT_ISMOUNTPOINT) {
> ++ if (opts & OPT_ISMOUNTPOINT) {
> + check_mountpoints(&mounts, &names_head, &names_tail);
> + }
> +
> +--
> +1.8.4.2
> +
> diff --git a/meta/recipes-extended/psmisc/psmisc_22.21.bb b/meta/recipes-extended/psmisc/psmisc_22.21.bb
> index 22f65c5..9f328bb 100644
> --- a/meta/recipes-extended/psmisc/psmisc_22.21.bb
> +++ b/meta/recipes-extended/psmisc/psmisc_22.21.bb
> @@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>
> SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
> SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
> +
> +SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"
>
next prev parent reply other threads:[~2014-07-30 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 5:54 [PATCH 1/1] Add patch 0001-Typo-in-fuser-makes-M-on-all-the-time.patch Patrice B
2014-07-30 6:05 ` Khem Raj
2014-07-30 6:16 ` Patrice B
2014-07-30 7:34 ` Saul Wold [this message]
2014-07-30 8:13 ` Martin Jansa
2014-07-30 12:58 ` Patrice B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D8A01F.9020305@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=pbfwdlist@gmail.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.