Re: [PATCH v18 02/11] libxl: add support for async. function calls when using libxl__ao_device

[Hongyang Yang <yanghy@cn.fujitsu.com>]

On 07/30/2014 01:24 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[PATCH v18 02/11] libxl: add support for async. function calls when using libxl__ao_device"):
>> Extend libxl__ao_device with a libxl__ev_child member, which can be
>> used to asynchronously execute functions that take a long time to complete.
>
> The code change is fine.
>
> I think the commit message and the comment should explain that this
> member is used only for syscalls where only a synchronous version is
> provided.
>
> How about
>
>   Extend libxl__ao_device with a libxl__ev_child member.
>
>   This can be used to fork children to allow the asynchronous execution
>   of system calls which only come in a synchronous variant.  This will
>   be useful for Remus, in the following patches.
>
> instead ?
>
>> +    /* for executing functions asynchronously */
>> +    libxl__ev_child child;
>
> And
>    +    /* for asynchronous execution of synchronous-only syscalls etc. */

It is better, thank you!

>
> Thanks,
> Ian.
> .
>

-- 
Thanks,
Yang.