Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

[Hannes Reinecke <hare@suse.de>]

On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> iscsi_get_host_stats was dropping the error code returned
> by drivers like qla4xxx.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>   drivers/scsi/scsi_transport_iscsi.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index b481e62..14bfa53 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -3467,6 +3467,10 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
>   		memset(buf, 0, host_stats_size);
>
>   		err = transport->get_host_stats(shost, buf, host_stats_size);
> +		if (err) {
> +			kfree(skbhost_stats);
> +			goto exit_host_stats;
> +		}
>
>   		actual_size = nlmsg_total_size(sizeof(*ev) + host_stats_size);
>   		skb_trim(skbhost_stats, NLMSG_ALIGN(actual_size));
>
What happens with the skbhost_stats allocated earlier? Shouldn't it 
be freed here, too?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html