Re: [PATCH 4/4] libiscsi: return new error code when nop times out

[Hannes Reinecke <hare@suse.de>]

On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> When a iscsi nop as ping timedout we were failing with the
> common connection error code, ISCSI_ERR_CONN_FAILED. This
> patch adds a new error code for this problem so can properly
> track/distinguish in userspace.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>   drivers/scsi/libiscsi.c |    2 +-
>   include/scsi/iscsi_if.h |    1 +
>   2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index f2db82b..b0813fd 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -2097,7 +2097,7 @@ static void iscsi_check_transport_timeouts(unsigned long data)
>   				  conn->ping_timeout, conn->recv_timeout,
>   				  last_recv, conn->last_ping, jiffies);
>   		spin_unlock(&session->frwd_lock);
> -		iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
> +		iscsi_conn_failure(conn, ISCSI_ERR_NOP_TIMEDOUT);
>   		return;
>   	}
>
> diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
> index fd0421c..95ed942 100644
> --- a/include/scsi/iscsi_if.h
> +++ b/include/scsi/iscsi_if.h
> @@ -527,6 +527,7 @@ enum iscsi_err {
>   	ISCSI_ERR_XMIT_FAILED		= ISCSI_ERR_BASE + 19,
>   	ISCSI_ERR_TCP_CONN_CLOSE	= ISCSI_ERR_BASE + 20,
>   	ISCSI_ERR_SCSI_EH_SESSION_RST	= ISCSI_ERR_BASE + 21,
> +	ISCSI_ERR_NOP_TIMEDOUT		= ISCSI_ERR_BASE + 22,
>   };
>
>   /*
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html