From: Gioh Kim <gioh.kim@lge.com>
To: Peter Zijlstra <peterz@infradead.org>, Jan Kara <jack@suse.cz>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>, Joonsoo Kim <js1304@gmail.com>
Subject: Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area
Date: Thu, 31 Jul 2014 08:45:57 +0900 [thread overview]
Message-ID: <53D983B5.3020903@lge.com> (raw)
In-Reply-To: <20140730101920.GI19379@twins.programming.kicks-ass.net>
2014-07-30 오후 7:19, Peter Zijlstra 쓴 글:
> On Wed, Jul 30, 2014 at 12:11:43PM +0200, Jan Kara wrote:
>>> sb_bread allocates page from movable area but it is not movable until the
>>> reference counter of the buffer-head becomes zero.
>>> There is no lock for the buffer but the reference counter acts like lock.
>> OK, but why do you care about a single page (of at most handful if you
>> have more filesystems) which isn't movable? That shouldn't make a big
>> difference to compaction...
>
> The thing is, CMA _must_ be able to clear all the pages in its range,
> otherwise its broken.
>
> So placing nonmovable pages in a movable block utterly wrecks that.
YES. Even a single page can make CMA migration fail.
>
> Now, Ted said that there's more effectively pinned stuff from
> filesystems (and I imagine those would be things like the root inode
> etc.) and those would equally wreck this..
>
> But Gioh didn't mention any of that.. he should I suppose.
Thanks to inform me.
I thought there are more pinned stuff but I didn't know what they are.
I tried CMA migration but it failed even after I moved the sb page-cache to non-movable area.
So I just guessed there are more pinned stuff.
I am newbie and not familiar with filesystem code.
Of course all of the pinned stuff should be moved to non-movable area.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Gioh Kim <gioh.kim@lge.com>
To: Peter Zijlstra <peterz@infradead.org>, Jan Kara <jack@suse.cz>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>, Joonsoo Kim <js1304@gmail.com>
Subject: Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area
Date: Thu, 31 Jul 2014 08:45:57 +0900 [thread overview]
Message-ID: <53D983B5.3020903@lge.com> (raw)
In-Reply-To: <20140730101920.GI19379@twins.programming.kicks-ass.net>
2014-07-30 i??i?? 7:19, Peter Zijlstra i?' e,?:
> On Wed, Jul 30, 2014 at 12:11:43PM +0200, Jan Kara wrote:
>>> sb_bread allocates page from movable area but it is not movable until the
>>> reference counter of the buffer-head becomes zero.
>>> There is no lock for the buffer but the reference counter acts like lock.
>> OK, but why do you care about a single page (of at most handful if you
>> have more filesystems) which isn't movable? That shouldn't make a big
>> difference to compaction...
>
> The thing is, CMA _must_ be able to clear all the pages in its range,
> otherwise its broken.
>
> So placing nonmovable pages in a movable block utterly wrecks that.
YES. Even a single page can make CMA migration fail.
>
> Now, Ted said that there's more effectively pinned stuff from
> filesystems (and I imagine those would be things like the root inode
> etc.) and those would equally wreck this..
>
> But Gioh didn't mention any of that.. he should I suppose.
Thanks to inform me.
I thought there are more pinned stuff but I didn't know what they are.
I tried CMA migration but it failed even after I moved the sb page-cache to non-movable area.
So I just guessed there are more pinned stuff.
I am newbie and not familiar with filesystem code.
Of course all of the pinned stuff should be moved to non-movable area.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Gioh Kim <gioh.kim@lge.com>
To: Peter Zijlstra <peterz@infradead.org>, Jan Kara <jack@suse.cz>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>, Joonsoo Kim <js1304@gmail.com>
Subject: Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area
Date: Thu, 31 Jul 2014 08:45:57 +0900 [thread overview]
Message-ID: <53D983B5.3020903@lge.com> (raw)
In-Reply-To: <20140730101920.GI19379@twins.programming.kicks-ass.net>
2014-07-30 오후 7:19, Peter Zijlstra 쓴 글:
> On Wed, Jul 30, 2014 at 12:11:43PM +0200, Jan Kara wrote:
>>> sb_bread allocates page from movable area but it is not movable until the
>>> reference counter of the buffer-head becomes zero.
>>> There is no lock for the buffer but the reference counter acts like lock.
>> OK, but why do you care about a single page (of at most handful if you
>> have more filesystems) which isn't movable? That shouldn't make a big
>> difference to compaction...
>
> The thing is, CMA _must_ be able to clear all the pages in its range,
> otherwise its broken.
>
> So placing nonmovable pages in a movable block utterly wrecks that.
YES. Even a single page can make CMA migration fail.
>
> Now, Ted said that there's more effectively pinned stuff from
> filesystems (and I imagine those would be things like the root inode
> etc.) and those would equally wreck this..
>
> But Gioh didn't mention any of that.. he should I suppose.
Thanks to inform me.
I thought there are more pinned stuff but I didn't know what they are.
I tried CMA migration but it failed even after I moved the sb page-cache to non-movable area.
So I just guessed there are more pinned stuff.
I am newbie and not familiar with filesystem code.
Of course all of the pinned stuff should be moved to non-movable area.
>
next prev parent reply other threads:[~2014-07-30 23:45 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 5:18 [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area Gioh Kim
2014-07-22 7:30 ` Peter Zijlstra
2014-07-22 8:14 ` Theodore Ts'o
2014-07-27 1:01 ` Theodore Ts'o
2014-07-30 7:56 ` Gioh Kim
2014-07-30 7:56 ` Gioh Kim
2014-07-22 9:38 ` Jan Kara
2014-07-22 9:38 ` Jan Kara
2014-07-30 7:44 ` Gioh Kim
2014-07-30 7:44 ` Gioh Kim
2014-07-30 7:44 ` Gioh Kim
2014-07-30 7:57 ` Kyungmin Park
2014-07-30 7:57 ` Kyungmin Park
2014-07-30 10:11 ` Jan Kara
2014-07-30 10:11 ` Jan Kara
2014-07-30 10:11 ` Jan Kara
2014-07-30 10:19 ` Peter Zijlstra
2014-07-30 23:45 ` Gioh Kim [this message]
2014-07-30 23:45 ` Gioh Kim
2014-07-30 23:45 ` Gioh Kim
2014-07-30 23:54 ` Gioh Kim
2014-07-30 23:54 ` Gioh Kim
2014-07-30 23:54 ` Gioh Kim
2014-07-31 0:03 ` Jan Kara
2014-07-31 0:03 ` Jan Kara
2014-07-31 0:03 ` Jan Kara
2014-07-31 0:37 ` Gioh Kim
2014-07-31 0:37 ` Gioh Kim
2014-07-31 0:37 ` Gioh Kim
2014-07-31 12:21 ` Jan Kara
2014-07-31 12:21 ` Jan Kara
2014-07-31 12:21 ` Jan Kara
2014-08-01 0:07 ` Gioh Kim
2014-08-01 0:07 ` Gioh Kim
2014-08-01 0:07 ` Gioh Kim
2014-08-01 1:06 ` Gioh Kim
2014-08-01 1:06 ` Gioh Kim
2014-08-01 1:06 ` Gioh Kim
2014-08-01 9:57 ` Jan Kara
2014-08-01 9:57 ` Jan Kara
2014-08-01 13:36 ` Peter Zijlstra
2014-08-01 15:24 ` Jan Kara
2014-08-01 15:24 ` Jan Kara
2014-08-01 16:04 ` Peter Zijlstra
2014-08-06 6:15 ` Gioh Kim
2014-08-06 6:15 ` Gioh Kim
2014-08-06 6:15 ` Gioh Kim
2014-08-01 8:34 ` Joonsoo Kim
2014-08-01 8:34 ` Joonsoo Kim
2014-08-01 8:34 ` Joonsoo Kim
2014-08-01 9:15 ` Jan Kara
2014-08-01 9:15 ` Jan Kara
2014-08-01 9:15 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D983B5.3020903@lge.com \
--to=gioh.kim@lge.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=js1304@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.