[PATCH] ARM: mvebu: Add RTC support for Armada 375

[PATCH] ARM: mvebu: Add RTC support for Armada 375

[Gregory CLEMENT]

The Armada 375 XP Socs have the same controller that the one used in
the orion platforms. This patch updates the device tree for these
SoCs.

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
Hi Jason,

We missed it for the initial support of the SoC.

I know that it is very late for including for 3.17, so if it is
postpone for 3.18, it's fine.

However given the little change, maybe it is still possible to push it
in 3.17 ^_^

Thanks,

Gregory


 arch/arm/boot/dts/armada-375.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
index 893e2a93eba0..f6fe2c270938 100644
--- a/arch/arm/boot/dts/armada-375.dtsi
+++ b/arch/arm/boot/dts/armada-375.dtsi
@@ -185,6 +185,12 @@
 				};
 			};
 
+			rtc at 10300 {
+				compatible = "marvell,orion-rtc";
+				reg = <0x10300 0x20>;
+				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+			};
+
 			spi0: spi at 10600 {
 				compatible = "marvell,orion-spi";
 				reg = <0x10600 0x50>;
-- 
1.8.1.2

[PATCH] ARM: mvebu: Add RTC support for Armada 375

[Gregory CLEMENT]

Hi,


of course it only when the patch is setn that I found a typo:

On 31/07/2014 15:44, Gregory CLEMENT wrote:
> The Armada 375 XP Socs have the same controller that the one used in

It is Armada 375 not Armada 375 XP!


Thanks,

Gregory

> the orion platforms. This patch updates the device tree for these
> SoCs.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi Jason,
> 
> We missed it for the initial support of the SoC.
> 
> I know that it is very late for including for 3.17, so if it is
> postpone for 3.18, it's fine.
> 
> However given the little change, maybe it is still possible to push it
> in 3.17 ^_^
> 
> Thanks,
> 
> Gregory
> 
> 
>  arch/arm/boot/dts/armada-375.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
> index 893e2a93eba0..f6fe2c270938 100644
> --- a/arch/arm/boot/dts/armada-375.dtsi
> +++ b/arch/arm/boot/dts/armada-375.dtsi
> @@ -185,6 +185,12 @@
>  				};
>  			};
>  
> +			rtc at 10300 {
> +				compatible = "marvell,orion-rtc";
> +				reg = <0x10300 0x20>;
> +				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			};
> +
>  			spi0: spi at 10600 {
>  				compatible = "marvell,orion-spi";
>  				reg = <0x10600 0x50>;
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH] ARM: mvebu: Add RTC support for Armada 375

[Thomas Petazzoni]

Dear Gregory CLEMENT,

On Thu, 31 Jul 2014 15:44:36 +0200, Gregory CLEMENT wrote:

> The Armada 375 XP Socs have the same controller that the one used in
> the orion platforms. This patch updates the device tree for these
> SoCs.

Actually there's only one Armada 375 SoC, so singular would be good.
And s/that/than/ as well. And "controller" is a bit vague. Proposal:

"""
The Armada 375 SoC has the same real time clock as the one used in
other Marvell EBU platforms. This patch consequently updates the Device
Tree of the Armada 375 SoC to describe the internal RTC.
"""

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH] ARM: mvebu: Add RTC support for Armada 375

[Gregory CLEMENT]

Hi Thomas,

On 31/07/2014 16:15, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> On Thu, 31 Jul 2014 15:44:36 +0200, Gregory CLEMENT wrote:
> 
>> The Armada 375 XP Socs have the same controller that the one used in
>> the orion platforms. This patch updates the device tree for these
>> SoCs.
> 
> Actually there's only one Armada 375 SoC, so singular would be good.

On this point I was referring to the chips not to the family. But I agree
that it can be understood in both way.

> And s/that/than/ as well. And "controller" is a bit vague. Proposal:
> 
> """
> The Armada 375 SoC has the same real time clock as the one used in
> other Marvell EBU platforms. This patch consequently updates the Device
> Tree of the Armada 375 SoC to describe the internal RTC.
> """

I agree with your proposal I will sent a new version soon.

Thanks,

Gregory


> 
> Thanks,
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com