Re: [PATCH] drm/msm/hdmi: enable lpm-mux if it is present

["Andreas Färber" <afaerber@suse.de>]

Hi,

Am 31.07.2014 16:46, schrieb Stephane Viau:
> From: Beeresh Gopal <gbeeresh@codeaurora.org>
> 
> lpm-mux is programmed to enable HDMI connector
> on the docking station for S805 chipset based
> devices.
> 
> Signed-off-by: Beeresh Gopal <gbeeresh@codeaurora.org>

You forgot to sign off yourself.

[...]
> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> index 93d1551..1301d03 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c
> @@ -63,7 +63,8 @@ static int gpio_config(struct hdmi *hdmi, bool on)
>  			ret = gpio_request(config->mux_en_gpio, "HDMI_MUX_EN");
>  			if (ret) {
>  				dev_err(dev->dev, "'%s'(%d) gpio_request failed: %d\n",
> -					"HDMI_MUX_SEL", config->mux_en_gpio, ret);
> +					"HDMI_MUX_EN",
> +					config->mux_en_gpio, ret);
>  				goto error4;
>  			}
>  			gpio_set_value_cansleep(config->mux_en_gpio, 1);

This hunk looks like an unrelated typo fix, which should then probably
go into its own patch.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg