From: Kukjin Kim <kgene.kim@samsung.com>
To: Doug Anderson <dianders@google.com>
Cc: "Jaehoon Chung" <jh80.chung@samsung.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
"Chris Ball" <chris@printf.net>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Seungwon Jeon" <tgih.jun@samsung.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Dinh Nguyen" <dinguyen@altera.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kukjin Kim" <kgene.kim@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Andreas Färber" <afaerber@suse.de>, cpgs <cpgs@samsung.com>
Subject: Re: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk "disable-wp" is deprecated.
Date: Fri, 01 Aug 2014 03:35:38 +0900 [thread overview]
Message-ID: <53DA8C7A.60205@samsung.com> (raw)
In-Reply-To: <CAD=FV=VfXOqt1A=8-1kq5nhnMrk7PbpCWj-A-UWQN12_U8sW4g@mail.gmail.com>
On 08/01/14 01:02, Doug Anderson wrote:
> Jaehoon
>
> On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chung<jh80.chung@samsung.com> wrote:
>> Slot quirks "disable-wp" is deprecated.
>> Instead, use the host quirk "disable-wp".
>> (Because the slot-node is removed in dt-file.)
>>
>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>> Tested-by: Sachin Kamat<sachin.kamat@samsung.com>
>> Acked-by: Seungwon Jeon<tgih.jun@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 11 +++++++++--
>> include/linux/mmc/dw_mmc.h | 2 ++
>> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> Thanks for taking my suggestion and making it backward compatible.
> This looks great to me. It tested this in both the backward
> compatible way (with the warning) and the non-backward compatible way.
> I think we should land and patch #2 ASAP and then we can land the rest
> of the series as SoC maintainers see fit.
>
Yes, right if we don't want to see useless merge conflicts...
- Kukjin
> Reviewed-by: Doug Anderson<dianders@chromium.org>
> Tested-by: Doug Anderson<dianders@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk "disable-wp" is deprecated.
Date: Fri, 01 Aug 2014 03:35:38 +0900 [thread overview]
Message-ID: <53DA8C7A.60205@samsung.com> (raw)
In-Reply-To: <CAD=FV=VfXOqt1A=8-1kq5nhnMrk7PbpCWj-A-UWQN12_U8sW4g@mail.gmail.com>
On 08/01/14 01:02, Doug Anderson wrote:
> Jaehoon
>
> On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chung<jh80.chung@samsung.com> wrote:
>> Slot quirks "disable-wp" is deprecated.
>> Instead, use the host quirk "disable-wp".
>> (Because the slot-node is removed in dt-file.)
>>
>> Signed-off-by: Jaehoon Chung<jh80.chung@samsung.com>
>> Tested-by: Sachin Kamat<sachin.kamat@samsung.com>
>> Acked-by: Seungwon Jeon<tgih.jun@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 11 +++++++++--
>> include/linux/mmc/dw_mmc.h | 2 ++
>> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> Thanks for taking my suggestion and making it backward compatible.
> This looks great to me. It tested this in both the backward
> compatible way (with the warning) and the non-backward compatible way.
> I think we should land and patch #2 ASAP and then we can land the rest
> of the series as SoC maintainers see fit.
>
Yes, right if we don't want to see useless merge conflicts...
- Kukjin
> Reviewed-by: Doug Anderson<dianders@chromium.org>
> Tested-by: Doug Anderson<dianders@chromium.org>
next prev parent reply other threads:[~2014-07-31 18:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 5:35 [PATCHv9 0/5] ARM: remove the sub-node and deprecate supports-highspeed property for dwmmc Jaehoon Chung
2014-07-31 5:35 ` Jaehoon Chung
2014-07-31 5:35 ` [PATCHv9 1/5] mmc: dw_mmc: Slot quirk "disable-wp" is deprecated Jaehoon Chung
2014-07-31 5:35 ` Jaehoon Chung
2014-07-31 16:02 ` Doug Anderson
2014-07-31 16:02 ` Doug Anderson
2014-07-31 18:35 ` Kukjin Kim [this message]
2014-07-31 18:35 ` Kukjin Kim
2014-07-31 18:36 ` Kukjin Kim
2014-07-31 18:36 ` Kukjin Kim
2014-08-01 4:26 ` Jaehoon Chung
2014-08-01 4:26 ` Jaehoon Chung
2014-08-01 8:58 ` Heiko Stübner
2014-08-01 8:58 ` Heiko Stübner
2014-07-31 5:35 ` [PATCHv9 2/5] mmc: dw_mmc: modify the dt-binding for removing slot-node and supports-highspeed Jaehoon Chung
2014-07-31 5:35 ` Jaehoon Chung
2014-07-31 5:35 ` [PATCHv9 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc Jaehoon Chung
2014-07-31 5:35 ` Jaehoon Chung
2014-07-31 5:35 ` [PATCHv9 4/5] ARM: dts: socfpga: " Jaehoon Chung
2014-07-31 5:35 ` Jaehoon Chung
2014-07-31 5:35 ` [PATCHv9 5/5] ARM: dts: rockchip: " Jaehoon Chung
2014-07-31 5:35 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DA8C7A.60205@samsung.com \
--to=kgene.kim@samsung.com \
--cc=afaerber@suse.de \
--cc=chris@printf.net \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=dinguyen@altera.com \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.