[meta-initramfs][PATCH] kexecboot: remove trailing slash in do_install

[meta-initramfs][PATCH] kexecboot: remove trailing slash in do_install

[Andrea Adami]

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb b/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
index d0176c5..1fb5f0d 100644
--- a/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
+++ b/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
@@ -48,7 +48,7 @@ EXTRA_OECONF = "--enable-delay=2 --enable-evdev-rate=1000,250"
 
 do_install () {
     install -d ${D}${bindir}
-    install -m 0755 kexecboot ${D}${bindir}/
+    install -m 0755 kexecboot ${D}${bindir}
     install -d ${D}/proc
     install -d ${D}/mnt
     install -d ${D}/dev
-- 
1.9.1

Re: [meta-initramfs][PATCH] kexecboot: remove trailing slash in do_install

[Gary Thomas]

On 2014-07-31 16:46, Andrea Adami wrote:
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
>   meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb b/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
> index d0176c5..1fb5f0d 100644
> --- a/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
> +++ b/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
> @@ -48,7 +48,7 @@ EXTRA_OECONF = "--enable-delay=2 --enable-evdev-rate=1000,250"
>
>   do_install () {
>       install -d ${D}${bindir}
> -    install -m 0755 kexecboot ${D}${bindir}/
> +    install -m 0755 kexecboot ${D}${bindir}
>       install -d ${D}/proc
>       install -d ${D}/mnt
>       install -d ${D}/dev
>

What is the reason for this change.  Using XXX/ is quite common
in OE recipes.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-initramfs][PATCH] kexecboot: remove trailing slash in do_install

[Andrea Adami]

On Fri, Aug 1, 2014 at 12:56 AM, Gary Thomas <gary@mlbassoc.com> wrote:
> On 2014-07-31 16:46, Andrea Adami wrote:
>>
>> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
>> ---
>>   meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
>> b/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
>> index d0176c5..1fb5f0d 100644
>> --- a/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
>> +++ b/meta-initramfs/recipes-bsp/kexecboot/kexecboot_0.6.bb
>> @@ -48,7 +48,7 @@ EXTRA_OECONF = "--enable-delay=2
>> --enable-evdev-rate=1000,250"
>>
>>   do_install () {
>>       install -d ${D}${bindir}
>> -    install -m 0755 kexecboot ${D}${bindir}/
>> +    install -m 0755 kexecboot ${D}${bindir}
>>       install -d ${D}/proc
>>       install -d ${D}/mnt
>>       install -d ${D}/dev
>>
>
> What is the reason for this change.  Using XXX/ is quite common
> in OE recipes.
>

Hi Gary,

thanks for reviewing, I recently spotted this slash and imho is just
one extra unnecessary char.

About the 'best practice' here, the POSIX synopsis seems not
describing an ending slash for <target>
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

Cheers

Andrea


> --
> ------------------------------------------------------------
> Gary Thomas                 |  Consulting for the
> MLB Associates              |    Embedded world
> ------------------------------------------------------------
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel